fix corner case in hoist_props (#4024)

fixes #4023
This commit is contained in:
Alex Lam S.L
2020-07-26 02:27:34 +01:00
committed by GitHub
parent a98ba994bd
commit 1bc0df1569
2 changed files with 34 additions and 3 deletions

View File

@@ -5071,6 +5071,7 @@ merge(Compressor.prototype, {
}
}));
self.transform(new TreeTransformer(function(node, descend) {
if (node instanceof AST_Binary) return replace("right");
if (node instanceof AST_PropAccess) {
if (!(node.expression instanceof AST_SymbolRef)) return;
var defs = defs_by_id[node.expression.definition().id];
@@ -5086,10 +5087,15 @@ merge(Compressor.prototype, {
}
if (node instanceof AST_Unary) {
if (unary_side_effects[node.operator]) return;
if (!(node.expression instanceof AST_SymbolRef)) return;
if (!(node.expression.definition().id in defs_by_id)) return;
return replace("expression");
}
function replace(prop) {
var sym = node[prop];
if (!(sym instanceof AST_SymbolRef)) return;
if (!(sym.definition().id in defs_by_id)) return;
var opt = node.clone();
opt.expression = make_node(AST_Object, node, {
opt[prop] = make_node(AST_Object, sym, {
properties: []
});
return opt;

View File

@@ -1016,3 +1016,28 @@ issue_3945_2: {
}
expect_stdout: "undefined"
}
issue_4023: {
options = {
comparisons: true,
hoist_props: true,
inline: true,
reduce_vars: true,
toplevel: true,
typeofs: true,
unused: true,
}
input: {
function f() {
var a = function() {
return { p: 0 };
}();
return console.log("undefined" != typeof a);
}
f();
}
expect: {
console.log(void 0 !== {});
}
expect_stdout: "true"
}