Compare commits

...

175 Commits

Author SHA1 Message Date
Mihai Bazon
448a8d3845 v2.4.13 2014-03-11 15:22:37 +02:00
Mihai Bazon
f5c09d0bbf Merge pull request #439 from Arnavion/null-source-in-sourcemap
Handle the case when SourceMapConsumer.originalPositionFor returns null source.
2014-03-03 09:19:39 +02:00
Arnavion
014f655c5f Handle the case when SourceMapConsumer.originalPositionFor returns null source.
This happens when SourceMapConsumer does not have a valid position to map the input line and column. This is a change in mozilla/source-map starting from version 0.1.33

Fixes #436
2014-03-02 19:20:19 -08:00
Mihai Bazon
bf30dc3038 Mangle name of exception when --screw-ie8. Fix #430.
The effect of not mangling it was visible only with --screw-ie8 (otherwise
the names would be mangled exactly because they leaked into the parent
scope).
2014-02-14 13:58:14 +02:00
Mihai Bazon
ef2ef07cbd Add option keep_fargs.
By default it's `false`.  Pass `true` if you need to keep unused function
arguments.

Close #188.
2014-02-08 12:33:56 +02:00
Mihai Bazon
1a4440080d Merge pull request #424 from mattbasta/simplify_conditionals
Simplify nested conditionals if possible
2014-02-07 11:31:11 +02:00
Matt Basta
ac0086a745 Simplify nested conditionals if possible 2014-02-06 12:39:13 -08:00
Mihai Bazon
2494daaf68 Merge pull request #422 from mourner/patch-1
Fix readme typo (when -> with)
2014-02-06 18:13:10 +02:00
Vladimir Agafonkin
9b404f9de6 fix readme typo (when -> with) 2014-02-06 18:11:33 +02:00
Mihai Bazon
5344b7dab8 Fix if_return dropping the alternative. Close #413 2014-01-31 10:44:13 +02:00
Mihai Bazon
0007a53b9c Update source-map 2014-01-26 10:18:20 +02:00
Mihai Bazon
1dd05f44eb Merge branch 'sourcesContent' of https://github.com/arty-name/UglifyJS2 into arty-name-sourcesContent 2014-01-26 10:15:24 +02:00
Mihai Bazon
bf7b122ab2 v2.4.12 2014-01-26 10:11:00 +02:00
Mihai Bazon
e29048b54a Merge branch 'master' of github.com:mishoo/UglifyJS2 2014-01-26 10:07:10 +02:00
Mihai Bazon
2eeb640eca Merge pull request #408 from danielstutzman/escape-null-in-regex
Don't unescape \x00 in regexes (it breaks IE8)
2014-01-26 00:06:19 -08:00
Mihai Bazon
ceb200fe81 Move unescaping regexps under a codegen option (unescape_regexps) 2014-01-26 10:05:55 +02:00
Daniel Stutzman
f5f8239057 Don't unescape \x00 in regexes (it breaks IE8) 2014-01-25 11:55:39 -07:00
Mihai Bazon
6f9d051784 v2.4.11 2014-01-21 11:44:28 +02:00
Mihai Bazon
931862e97f More chars that cannot be unescaped in regexps. 2014-01-21 11:44:00 +02:00
Mihai Bazon
1d0127de21 Fix end token for conditionals. Close #404 2014-01-21 10:38:59 +02:00
Mihai Bazon
2d8fc61677 Merge pull request #402 from lautis/bom-regexps
Don't unescape byte order marks in regexps
2014-01-19 06:14:12 -08:00
Ville Lautanala
1e31011874 Don't unescape byte order marks in regexps 2014-01-19 12:27:03 +02:00
Mihai Bazon
75cdbf19aa v2.4.10 2014-01-18 12:32:45 +02:00
Mihai Bazon
4339bd5cfa Don't unescape \x2f (slash) in regexps. #54 2014-01-18 12:31:50 +02:00
Mihai Bazon
1ab2fdaa10 Fix example 2014-01-17 15:48:47 +02:00
Mihai Bazon
eda540f6ec v2.4.9 2014-01-15 22:31:09 +02:00
Mihai Bazon
90a330da16 simplify 2014-01-10 10:36:15 +02:00
Mihai Bazon
cad1f9cbd1 Unescape Unicode sequences in regexps when ascii_only is false. #54 2014-01-10 10:33:58 +02:00
Artemy Tregubenko
f6203bd5a8 added hasOwnProperty check to avoid warnings 2014-01-09 15:20:05 +01:00
Artemy Tregubenko
03cf94ebe8 Added support for sourcesContent property of source map 2014-01-09 15:12:00 +01:00
Mihai Bazon
c3087dd179 Better process_for_angular before other statement reductions. #395 2014-01-08 11:39:24 +02:00
Mihai Bazon
2c305af478 Support @ngInject with angular compressor option. Close #395. 2014-01-08 11:28:32 +02:00
Mihai Bazon
72e6f64ca8 Disable node 0.6 since the build fails consistently and it's not our fault. 2014-01-07 18:56:18 +02:00
Mihai Bazon
b9fac687ff Support SpiderMonkey AST in UglifyJS.minify. Fix #393. 2014-01-07 18:42:48 +02:00
Mihai Bazon
2c88eb6fbe doh. 2014-01-07 12:54:14 +02:00
Mihai Bazon
a67e3bfdd3 Fix #392 2014-01-07 12:48:54 +02:00
Mihai Bazon
27142df4f5 minor: exp["10"] => exp[10] 2014-01-07 12:48:21 +02:00
Mihai Bazon
5e4c7f4245 Fix parens for property access -- (foo, bar)["baz"] 2014-01-05 11:48:01 +02:00
Mihai Bazon
b521b4b926 Conditional/call optimization
foo ? bar(x) : bar(y)  ==>  bar(foo ? x : y)
2013-12-29 10:31:30 +02:00
Mihai Bazon
aa9de76370 Mark yield as reserved word. Close #375. 2013-12-22 20:52:19 +02:00
Mihai Bazon
5a083a938d Optimize seq,void 0. Close #377.
(x, void 0)    => void x
    (x, undefined) => void x
2013-12-22 11:36:45 +02:00
Mihai Bazon
7a30d826b8 Better fix for comments in AST_Exit
Close #374
2013-12-18 15:54:12 +02:00
Mihai Bazon
be55a09edf Take out all comments from an AST_Exit's value
Fix #372
2013-12-18 13:30:26 +02:00
Mihai Bazon
15a148ff6d v2.4.8 2013-12-18 12:10:43 +02:00
Mihai Bazon
428e19fed2 Add option to adjust the src/target line in the source map 2013-12-18 12:10:02 +02:00
Mihai Bazon
f65e55dff4 minor 2013-12-16 20:37:09 +02:00
Mihai Bazon
b634018618 Merge pull request #371 from colorhook/master
bugfix #242
2013-12-16 00:21:07 -08:00
colorhook
fa3300f314 bugfix #242 2013-12-16 15:53:43 +08:00
Mihai Bazon
bd0886a2c0 semicolons 2013-12-10 20:24:27 +02:00
Mihai Bazon
248f304f02 Merge pull request #245 from ForbesLindesay/patch-1
Make `DefaultsError` a real `Error` object
2013-12-10 10:23:29 -08:00
Mihai Bazon
dc5f70eab5 Add drop_console option to the compressor 2013-12-10 19:44:41 +02:00
Mihai Bazon
df8c5623af minor 2013-12-10 19:39:03 +02:00
Mihai Bazon
a790c09c91 v2.4.7 2013-12-09 12:09:31 +02:00
Mihai Bazon
8f35a363d9 AST_Catch shouldn't really inherit from AST_Scope. Fix #363
I hereby acknowledge that figure_out_scope has become a mess.
2013-12-05 13:30:29 +02:00
Mihai Bazon
d2190c2bf3 Properly scope catch identifier when --screw-ie8
Fix #344
2013-11-28 16:43:30 +02:00
Mihai Bazon
ea10642572 v2.4.6, because npm is foobar 2013-11-28 15:05:32 +02:00
Mihai Bazon
547561a568 v2.4.5 2013-11-28 13:15:27 +02:00
Mihai Bazon
c16d538ce7 Add --noerr to turn off argument name checking
for now only used for keys passed to `-c` or `-b`.
2013-11-28 13:15:01 +02:00
Mihai Bazon
73d082df2e v2.4.4 2013-11-27 14:24:26 +02:00
Mihai Bazon
50b8d7272c Fix faulty compression
`String(x + 5)` is not always the same as `x + "5"`.  Overlooked that. :-(

Close #350
2013-11-20 21:13:16 +02:00
Mihai Bazon
7d11b96f48 Only descend twice after drop_unused if it's the same node type.
Fix #345
2013-11-08 11:57:17 +02:00
Mihai Bazon
eab99a1c3d Better fix for #343
We can in fact lift sequences, but only if the operation is assignment and
the left-hand side has no side effects nor property access -- that should
guarantee that whatever we place before it cannot affect the sense of the
assignment.

Dropped contrived test case (too hard to support it now), added a more
meaningful one.
2013-11-06 10:48:48 +02:00
Mihai Bazon
19e2fb134d v2.4.3 2013-11-06 10:21:29 +02:00
Mihai Bazon
f4919e3a25 Do not lift sequence from right-hand side of binary operation. Fix #343 2013-11-06 10:18:28 +02:00
Mihai Bazon
bb700daa4c v2.4.2 2013-11-03 23:41:07 +02:00
Mihai Bazon
263577d5eb [README] Fix #278 2013-10-30 14:13:30 +02:00
Mihai Bazon
63287c0e68 Workaround for Safari bug
Close #313
2013-10-30 13:59:59 +02:00
Mihai Bazon
c5ed2292bf Fix parsing setters/getters (allow keywords for name).
The "key" property was always "set" or "get", which didn't make much sense.
Now it'll be the actual name of the setter/getter (AST_Node), and the
AST_Accessor object itself, which represents the function, won't store any
name.

Close #319
2013-10-30 11:50:22 +02:00
Mihai Bazon
b70670b69f Fix regression after e4c5302406
`x * (y * z)` ==> `x * y * z` -- the better place to do this is in the
compressor rather than codegen.
2013-10-30 10:45:58 +02:00
Mihai Bazon
9dd97605bc indentation 2013-10-30 10:44:50 +02:00
Mihai Bazon
e4c5302406 Fix output for x = 2 * (a % b / b * c)
(issue #337)
2013-10-30 09:11:55 +02:00
Mihai Bazon
bea3d90771 minor 2013-10-30 09:10:56 +02:00
Richard van Velzen
785c6064cc Disallow reversal where lhs has higher or equal precedence
Fixes #267
2013-10-29 21:37:36 +01:00
Mihai Bazon
b214d3786f Fix typo 2013-10-29 15:53:54 +02:00
Mihai Bazon
7cf79c302b Fix reading arguments
i.e. read `-c unsafe,unsafe-comps` as `-c unsafe=true,unsafe_comps=true`
2013-10-29 14:01:26 +02:00
Mihai Bazon
a14c6b6574 Avoid shadowing name of function expression with function argument
Close #179, #326, #327
2013-10-29 13:18:09 +02:00
Mihai Bazon
f1b7094a57 Add "preamble" output option
Close #335
2013-10-29 11:09:18 +02:00
Mihai Bazon
0358e376f0 Fix codegen for when comments_before is undefined.
Fix #333
2013-10-28 09:39:29 +02:00
Mihai Bazon
b47f7b76b9 Merge branch 'master' of github.com:mishoo/UglifyJS2 2013-10-27 10:03:01 +02:00
Mihai Bazon
582cc55cff Display number of failed tests and corresponding files 2013-10-27 10:02:44 +02:00
Mihai Bazon
8979579e55 Merge pull request #330 from markjaquith/master
Unit test to detect issue in 8d14efe for #126 that causes aggressive parenthesis removal, functional differences
2013-10-27 01:01:57 -07:00
Mihai Bazon
0d6e08c541 Merge pull request #331 from rvanvelzen/rhs-strings-fix
Fix RHS concat (raised in #330)
2013-10-27 01:01:11 -07:00
Richard van Velzen
e2daee9a65 Fix RHS concat (raised in #330)
When attempting to concat the left-side of the rhs, make sure the rhs is
a string.
2013-10-26 18:44:52 +02:00
Mark Jaquith
9cd118ca3d Add a unit test for issue-126
Add a unit test to test to test for aggressive parenthesis removal that causes functional changes.
2013-10-25 16:28:15 -04:00
Mihai Bazon
cfd5c6155c Merge pull request #325 from rvanvelzen/fix-269
Fix #269
2013-10-24 02:39:07 -07:00
Richard van Velzen
1a5a4bd631 Fix #269
Shorten most primitives where possible. Also optimize some edge cases.
2013-10-24 11:08:33 +02:00
Mihai Bazon
63e1a8e1fd Merge pull request #323 from rvanvelzen/undefined-drop-vars-fix
Fix #280
2013-10-23 13:58:09 -07:00
Richard van Velzen
7055af8221 Fix #280
The `init` of the `ForStatement` is not a `BlockStatement` before it was
descended. The descend has to happen first, and *then* the actual
checks.
2013-10-23 22:26:04 +02:00
Mihai Bazon
aafe2e1db3 Merge pull request #322 from rvanvelzen/test-exit-code-1
Add an exit code to the test suite
2013-10-23 11:37:36 -07:00
Richard van Velzen
118105db43 Add an exit code to the test suite
By adding the exit code 1 (or any other non-zero exit code) `npm test`
will know the tests didn't perform correctly. This way it's easier to
know if pull requests are good or bad.
2013-10-23 20:24:58 +02:00
Mihai Bazon
63d04fff69 Revert #3a81f60 for now
(with it some tests break and it can generate invalid output, see issue #44)
2013-10-22 21:50:55 +03:00
Mihai Bazon
8c9cc920fb v2.4.1 2013-10-22 21:31:01 +03:00
Mihai Bazon
d09f0adae3 arguments outside of a function is an ordinary variable.
Fix #501
2013-10-17 18:20:33 +03:00
Mihai Bazon
3fa9265ce4 wrap up 2013-10-09 22:15:43 +03:00
Mihai Bazon
3a81f60982 Don't drop_unused before compression.
Fix #280, #282
2013-10-09 19:15:09 +03:00
Mihai Bazon
f2348dd98b Rename clean_getters to pure_getters; add pure_funcs. 2013-10-04 13:17:25 +03:00
Mihai Bazon
253c7c2325 Merge pull request #308 from meteor/fix-unicode-keys
Only allow identifier start characters at the beginning of identifiers.
2013-10-04 00:13:52 -07:00
David Glasser
bb0a762d12 Only allow identifier start characters at the beginning of identifiers.
Without this fix, the following source:

   x = {"\u200c": 42};

would incorrectly be converted into a quoteless key. But while \u200c is allowed
to be in identifiers, it cannot be at the beginning, as per ES5.

(For example, the SockJS client library doesn't work under uglify starting with
d9ad3c7c.)
2013-10-03 17:02:19 -07:00
Mihai Bazon
8cc86fee60 add clean_getters compressor option (default false)
allows one to specify if `foo.bar` is considered to have side effects.
2013-10-02 19:38:01 +03:00
Mihai Bazon
88fb83aa81 minor optimization
unlikely to help in hand-written code:

    (something() ? foo : bar) == foo  ==>  something()
2013-10-02 15:31:31 +03:00
Mihai Bazon
95b4507c02 Fix error in the output minifying Function("return this")() 2013-09-30 11:49:29 +03:00
Mihai Bazon
afdaeba37d More attempts to determine when addition is associative
Somebody hit me with bug reports on this. :)

Refs #300
2013-09-22 15:26:10 +03:00
Mihai Bazon
037199bfe2 Actually let's move away those monsters from the evaluate function
ev() should do a single thing — evaluate constant expressions.  if that's
not possible, just return the original node.  it's not the best place for
partial evaluation there, instead doing it in the compress functions.
2013-09-22 15:00:42 +03:00
Mihai Bazon
583fac0a0f More dirty handling of [ ... ].join() in unsafe mode
Close #300
2013-09-22 13:14:42 +03:00
Dan Wolff
e8158279ff Evaluate [...].join() if possible: minor bugfix
Follow-up to 78e98d2.
2013-09-22 11:34:30 +03:00
Mihai Bazon
78e98d2611 When unsafe is set, evaluate [...].join() if possible
Close #298
2013-09-19 18:20:45 +03:00
Dan Wolff
8d14efe818 Concatenate strings also on the right-hand side of an expression that cannot be evaluated. Fix #126
E.g. converts:
  a+'Hello'+'World'
to
  a+'HelloWorld'
2013-09-19 13:03:03 +03:00
Mihai Bazon
83ba338bd0 Avoid printing <!-- in the output (HTML5 comment) 2013-09-06 10:10:45 +03:00
Mihai Bazon
7c10b25346 Support HTML5 comment syntax (enabled by default!)
See http://javascript.spec.whatwg.org/#comment-syntax
    https://github.com/mishoo/UglifyJS/issues/503
    https://github.com/marijnh/acorn/issues/62
2013-09-06 09:54:30 +03:00
Mihai Bazon
cb9d16fbe4 minor 2013-09-06 09:52:56 +03:00
Mihai Bazon
5d8da864c5 Fix names. 2013-09-02 19:38:00 +03:00
Mihai Bazon
85b527ba3d Disallow continue referring to a non-IterationStatement. Fix #287
Simplifies handling of labels (their definition/references can be easily
figured out at parse time, no need to do it in `figure_out_scope`).
2013-09-02 19:36:16 +03:00
Mihai Bazon
1c6efdae34 Better fix for #286 2013-09-02 11:36:48 +03:00
Mihai Bazon
b0ca896d98 Fix parsing a.case /= 1
Close #286
2013-09-02 11:09:54 +03:00
Mihai Bazon
78a217b94c Fix parsing regexp after unary-prefix operator
++/x/.y

Fix #284
2013-09-02 09:56:27 +03:00
Mihai Bazon
a89d233318 Better reporting of parse errors 2013-09-02 09:55:34 +03:00
Mihai Bazon
c28e1a0237 v2.4.0 2013-08-22 15:06:42 +03:00
Mihai Bazon
1a95007ec1 Remove --ie-proof from the readme.
Fix #276
2013-08-22 10:10:25 +03:00
Mihai Bazon
ed80b4a534 Move support for negate_iife in the compressor, rather than code generator
(the code generator doesn't maintain enough context to know whether
the return value is important or discarded)

Fixes #272
2013-08-20 17:45:52 +03:00
Mihai Bazon
4f09df238e Merge pull request #270 from michaelficarra/GH-259
fixes #259: don't unnecessarily quote object properties when --screw-ie8
2013-08-19 00:21:08 -07:00
Michael Ficarra
d9ad3c7cbf fixes #259: don't unnecessarily quote object properties when --screw-ie8 2013-08-18 19:45:06 -05:00
Mihai Bazon
6ea3f7fe34 fix usage 2013-08-08 09:15:13 +03:00
Mihai Bazon
4c4dc2137c Don't drop unused setter argument.
Fix #257
2013-08-07 12:04:58 +03:00
Mihai Bazon
4aa4b3e694 Support -p relative. Fix #256 2013-08-07 11:43:47 +03:00
Forbes Lindesay
2604aadb37 Add support for browserify 2013-08-07 11:21:30 +03:00
Mihai Bazon
964d5b9aa4 Don't pretend to evaluate lambdas
Fix #255
2013-08-04 21:44:17 +03:00
Mihai Bazon
b7adbcab1f Fix #251 2013-07-30 12:16:29 +03:00
Mihai Bazon
3435af494f Don't require arguments to --enclose 2013-07-28 11:11:11 +03:00
Mihai Bazon
41c627379c Reverting "added option for dropping unused params"
Revert "added option for dropping unused params"

(turns out we already had the `unused` option for this.)

This reverts commit e54df2226f.
2013-07-25 18:08:36 +03:00
Dusan Bartos
e54df2226f added option for dropping unused params 2013-07-25 17:37:47 +03:00
Forbes Lindesay
dfa395f6ff Make DefaultsError a real Error object 2013-07-22 01:44:03 +01:00
David Glasser
b1febde3e9 Fix output for arrays whose last element is a hole: [1,,]
1529ab96 started to do this (by considering holes to be separate from
"undefined") but it still converted
   [1,,]    (length 2, last element hole, trailing comma)
to
   [1,]     (length 1, trailing comma)

Unfortunately the test suite doesn't really make this clear: the new test here
passes with or without this patch because run-tests.js beautifys the expected
output (in "make_code"), which does the incorrect transformation! If you make
some manual change to arrays.js to make the test fail and see the INPUT and
OUTPUT, then you can see that without this fix, [1,,] -> [1,], and with this fix
it stays [1,,].
2013-07-18 15:39:22 +03:00
Mihai Bazon
193049af19 Revert previous patch, it was no good. 2013-07-15 11:59:23 +03:00
Mihai Bazon
4a0bab0fa3 Add "position" option to parser, to specify initial pos/line/col
(for parsing embedded scripts)
2013-07-15 11:27:11 +03:00
Mihai Bazon
9243b0cb9d Apply transformer to AST_VarDef's name
Fix #237
2013-07-14 13:24:09 +03:00
Mihai Bazon
fc9ba323c4 Fix typo.
Close #239
2013-07-12 09:56:58 +03:00
Mihai Bazon
d0689c81bb Reset the base54 counters every time minify is called.
Close #229
2013-06-28 10:08:13 +03:00
Mihai Bazon
02a84385a0 Don't swap binary ops when "use asm" is in effect.
Refs #167
2013-06-07 12:52:09 +03:00
Mihai Bazon
a4889a0f2e Merge pull request #220 from lautis/escape-null
Escape null characters as \x00
2013-06-03 11:10:14 -07:00
Ville Lautanala
f29f07aabd Escape null characters as \x00
Since \0 might be mistakenly interpreted as octal if followed by a
number and using literal null is in some cases interpreted as end of
string, escape null as \x00.
2013-06-03 20:46:42 +03:00
Mihai Bazon
188e28efd7 v2.3.6 2013-05-23 23:42:32 +03:00
Mihai Bazon
2df48924cc Merge pull request #213 from mattrobenolt/patch-1
SourceMapping pragma has changed to //#
2013-05-22 11:30:54 -07:00
Mihai Bazon
9fc6796d2a Add negate_iife option to the code generator.
See discussion in a9511dfbe5
2013-05-22 21:22:14 +03:00
Mihai Bazon
9fc8a52142 Set "global" on undeclared SymbolDef-s 2013-05-22 13:08:19 +03:00
Matt Robenolt
3a21861580 The extra /* */ isn't needed now 2013-05-21 08:50:21 -06:00
Matt Robenolt
1dbffd48ea SourceMapping pragma has changed to //#
See: https://docs.google.com/document/d/1U1RGAehQwRypUTovF1KRlpiOFze0b-_2gc6fAH0KY0k/edit

The spec was updated on May 16th since `//@` was causing some issues with IE.
2013-05-21 08:46:27 -06:00
Mihai Bazon
22a038e6a2 Fix output of statement: new function(){...};
Close #209
2013-05-20 08:27:37 +03:00
Mihai Bazon
f652372c9a v2.3.5 2013-05-19 14:25:05 +03:00
Mihai Bazon
ad1fc3b71a Fix package.json (use repository instead of repositories) 2013-05-19 14:24:33 +03:00
Mihai Bazon
2b40a5ac62 v2.3.4 2013-05-15 13:27:40 +03:00
Mihai Bazon
ca3388cf5a Add --expr, an option to parse a single expression (suitable for JSON) 2013-05-15 13:27:23 +03:00
Mihai Bazon
caa8896a8a Only compress code in new Function if all arguments are strings. 2013-05-14 18:36:31 +03:00
Mihai Bazon
d13aa3954d v2.3.3 2013-05-14 11:33:28 +03:00
Mihai Bazon
f64539fb76 Compress code passed to new Function if it's a constant.
Only for `--unsafe`.

Close #203
2013-05-14 10:47:06 +03:00
Mihai Bazon
d56ebd7d7b Fix a["1_1"]
Close #204
2013-05-14 10:42:34 +03:00
Mihai Bazon
3edfe7d0ee Merge pull request #202 from nschonni/add-travis-ci
Add CI build for supported Node versions
2013-05-10 02:56:24 -07:00
Mihai Bazon
7f77edadb3 v2.3.2 2013-05-09 08:58:55 +03:00
Mihai Bazon
a9511dfbe5 Use the negation hack rather than parens for a toplevel function expression call
(only in !beautify mode)
2013-05-09 08:58:47 +03:00
Mihai Bazon
064e7aa1bb Fix is_assignable
(not likely to be noticed, it's only used in `strict` parse mode)
2013-05-09 08:44:24 +03:00
Nick Schonning
46814f88d9 Add Travis build badge to README 2013-05-08 23:48:12 -04:00
Nick Schonning
4a19802d0c Add CI build for supported Node versions 2013-05-08 23:42:06 -04:00
Trey Griffith
1e9f98aa51 add a test for zero-length string in is_identifier_string, which is used in property compression. Also added a test exercising the change. 2013-05-08 22:43:20 +03:00
Mihai Bazon
11e24d53a1 Fix property names
Close #199
2013-05-08 22:37:48 +03:00
Mihai Bazon
0f509f8336 v2.3.1 2013-05-08 16:45:36 +03:00
Mihai Bazon
a6ed2c84ac Better fix for equality of typeof ... against "undefined" 2013-05-08 16:22:48 +03:00
Justin Lau
a1958aad56 Fixed typeof undefined optimization and updated related test case to
accomodates the sort behaviour changes made in commit
mishoo/UglifyJS2@aebafad41e.
Signed-off-by: Justin Lau <justin@tclau.com>
2013-05-08 16:22:48 +03:00
Justin Lau
672699613e Added test cases for #104.
Signed-off-by: Justin Lau <justin@tclau.com>
2013-05-08 16:22:48 +03:00
Mihai Bazon
645d5bdbc5 Merge pull request #195 from kjbekkelund/typo
Fix typo in bin and readme
2013-05-08 05:51:52 -07:00
Justin Lau
9af2bbffde Fixed dot properties not optimizing unicode identifiers. Signed-off-by: Justin Lau <justin@tclau.com> 2013-05-07 14:20:19 +03:00
Justin Lau
fcd544cc10 Added test scenario with unicode in properties name.
Signed-off-by: Justin Lau <justin@tclau.com>
2013-05-06 01:26:33 +08:00
Justin Lau
1e3bc0caa0 Fixed dot property issue with invlid identifier names.
Signed-off-by: Justin Lau <justin@tclau.com>
2013-05-05 22:27:43 +08:00
Justin Lau
8227e8795b Added scenario in test case where properties shouldn't be accessed with
dotted syntax even with screw_ie8 option.
Signed-off-by: Justin Lau <justin@tclau.com>
2013-05-05 22:08:13 +08:00
Kim Joar Bekkelund
790b3bcdc6 Fix typo in bin and readme 2013-05-02 11:15:33 +02:00
Mihai Bazon
d6e6458f68 Merge pull request #194 from ulikoehler/master
Add README syntax highlighting
2013-05-01 07:04:01 -07:00
Uli Köhler
a54b6703c0 Add README syntax highlighting 2013-05-01 15:56:20 +02:00
26 changed files with 1720 additions and 533 deletions

6
.travis.yml Normal file
View File

@@ -0,0 +1,6 @@
language: node_js
node_js:
- "0.4"
- "0.8"
- "0.10"
- "0.11"

339
README.md
View File

@@ -1,5 +1,6 @@
UglifyJS 2 UglifyJS 2
========== ==========
[![Build Status](https://travis-ci.org/mishoo/UglifyJS2.png)](https://travis-ci.org/mishoo/UglifyJS2)
UglifyJS is a JavaScript parser, minifier, compressor or beautifier toolkit. UglifyJS is a JavaScript parser, minifier, compressor or beautifier toolkit.
@@ -45,55 +46,72 @@ files.
The available options are: The available options are:
--source-map Specify an output file where to generate source map. ```
[string] --source-map Specify an output file where to generate source map.
--source-map-root The path to the original source to be included in the [string]
source map. [string] --source-map-root The path to the original source to be included in the
--source-map-url The path to the source map to be added in //@ source map. [string]
sourceMappingURL. Defaults to the value passed with --source-map-url The path to the source map to be added in //#
--source-map. [string] sourceMappingURL. Defaults to the value passed with
--in-source-map Input source map, useful if you're compressing JS that was --source-map. [string]
generated from some other original code. --source-map-include-sources
--screw-ie8 Pass this flag if you don't care about full compliance with Pass this flag if you want to include the content of
Internet Explorer 6-8 quirks (by default UglifyJS will try source files in the source map as sourcesContent
to be IE-proof). property. [boolean]
-p, --prefix Skip prefix for original filenames that appear in source --in-source-map Input source map, useful if you're compressing JS that was
maps. For example -p 3 will drop 3 directories from file generated from some other original code.
names and ensure they are relative paths. --screw-ie8 Pass this flag if you don't care about full compliance
-o, --output Output file (default STDOUT). with Internet Explorer 6-8 quirks (by default UglifyJS
-b, --beautify Beautify output/specify output options. [string] will try to be IE-proof). [boolean]
-m, --mangle Mangle names/pass mangler options. [string] --expr Parse a single expression, rather than a program (for
-r, --reserved Reserved names to exclude from mangling. parsing JSON) [boolean]
-c, --compress Enable compressor/pass compressor options. Pass options -p, --prefix Skip prefix for original filenames that appear in source
like -c hoist_vars=false,if_return=false. Use -c with no maps. For example -p 3 will drop 3 directories from file
argument to use the default compression options. [string] names and ensure they are relative paths. You can also
-d, --define Global definitions [string] specify -p relative, which will make UglifyJS figure out
--comments Preserve copyright comments in the output. By default this itself the relative paths between original sources, the
works like Google Closure, keeping JSDoc-style comments source map and the output file. [string]
that contain "@license" or "@preserve". You can optionally -o, --output Output file (default STDOUT).
pass one of the following arguments to this flag: -b, --beautify Beautify output/specify output options. [string]
- "all" to keep all comments -m, --mangle Mangle names/pass mangler options. [string]
- a valid JS regexp (needs to start with a slash) to keep -r, --reserved Reserved names to exclude from mangling.
only comments that match. -c, --compress Enable compressor/pass compressor options. Pass options
Note that currently not *all* comments can be kept when like -c hoist_vars=false,if_return=false. Use -c with no
compression is on, because of dead code removal or argument to use the default compression options. [string]
cascading statements into sequences. [string] -d, --define Global definitions [string]
--stats Display operations run time on STDERR. [boolean] -e, --enclose Embed everything in a big function, with a configurable
--acorn Use Acorn for parsing. [boolean] parameter/argument list. [string]
--spidermonkey Assume input fles are SpiderMonkey AST format (as JSON). --comments Preserve copyright comments in the output. By default this
[boolean] works like Google Closure, keeping JSDoc-style comments
--self Build itself (UglifyJS2) as a library (implies that contain "@license" or "@preserve". You can optionally
--wrap=UglifyJS --export-all) [boolean] pass one of the following arguments to this flag:
--wrap Embed everything in a big function, making the “exports - "all" to keep all comments
and “global” variables available. You need to pass an - a valid JS regexp (needs to start with a slash) to keep
argument to this option to specify the name that your only comments that match.
module will take when included in, say, a browser. Note that currently not *all* comments can be kept when
[string] compression is on, because of dead code removal or
--export-all Only used when --wrap, this tells UglifyJS to add code to cascading statements into sequences. [string]
automatically export all globals. [boolean] --preamble Preamble to prepend to the output. You can use this to
--lint Display some scope warnings [boolean] insert a comment, for example for licensing information.
-v, --verbose Verbose [boolean] This will not be parsed, but the source map will adjust
-V, --version Print version number and exit. [boolean] for its presence.
--stats Display operations run time on STDERR. [boolean]
--acorn Use Acorn for parsing. [boolean]
--spidermonkey Assume input files are SpiderMonkey AST format (as JSON).
[boolean]
--self Build itself (UglifyJS2) as a library (implies
--wrap=UglifyJS --export-all) [boolean]
--wrap Embed everything in a big function, making the “exports”
and “global” variables available. You need to pass an
argument to this option to specify the name that your
module will take when included in, say, a browser.
[string]
--export-all Only used when --wrap, this tells UglifyJS to add code to
automatically export all globals. [boolean]
--lint Display some scope warnings [boolean]
-v, --verbose Verbose [boolean]
-V, --version Print version number and exit. [boolean]
```
Specify `--output` (`-o`) to declare the output file. Otherwise the output Specify `--output` (`-o`) to declare the output file. Otherwise the output
goes to STDOUT. goes to STDOUT.
@@ -155,7 +173,7 @@ To enable the mangler you need to pass `--mangle` (`-m`). The following
- `toplevel` — mangle names declared in the toplevel scope (disabled by - `toplevel` — mangle names declared in the toplevel scope (disabled by
default). default).
- `eval` — mangle names visible in scopes where `eval` or `when` are used - `eval` — mangle names visible in scopes where `eval` or `with` are used
(disabled by default). (disabled by default).
When mangling is enabled but you want to prevent certain names from being When mangling is enabled but you want to prevent certain names from being
@@ -174,32 +192,70 @@ you can pass a comma-separated list of options. Options are in the form
to set `true`; it's effectively a shortcut for `foo=true`). to set `true`; it's effectively a shortcut for `foo=true`).
- `sequences` -- join consecutive simple statements using the comma operator - `sequences` -- join consecutive simple statements using the comma operator
- `properties` -- rewrite property access using the dot notation, for - `properties` -- rewrite property access using the dot notation, for
example `foo["bar"] → foo.bar` example `foo["bar"] → foo.bar`
- `dead_code` -- remove unreachable code - `dead_code` -- remove unreachable code
- `drop_debugger` -- remove `debugger;` statements - `drop_debugger` -- remove `debugger;` statements
- `unsafe` (default: false) -- apply "unsafe" transformations (discussion below) - `unsafe` (default: false) -- apply "unsafe" transformations (discussion below)
- `conditionals` -- apply optimizations for `if`-s and conditional - `conditionals` -- apply optimizations for `if`-s and conditional
expressions expressions
- `comparisons` -- apply certain optimizations to binary nodes, for example: - `comparisons` -- apply certain optimizations to binary nodes, for example:
`!(a <= b) → a > b` (only when `unsafe`), attempts to negate binary nodes, `!(a <= b) → a > b` (only when `unsafe`), attempts to negate binary nodes,
e.g. `a = !b && !c && !d && !e → a=!(b||c||d||e)` etc. e.g. `a = !b && !c && !d && !e → a=!(b||c||d||e)` etc.
- `evaluate` -- attempt to evaluate constant expressions - `evaluate` -- attempt to evaluate constant expressions
- `booleans` -- various optimizations for boolean context, for example `!!a - `booleans` -- various optimizations for boolean context, for example `!!a
? b : c → a ? b : c` ? b : c → a ? b : c`
- `loops` -- optimizations for `do`, `while` and `for` loops when we can - `loops` -- optimizations for `do`, `while` and `for` loops when we can
statically determine the condition statically determine the condition
- `unused` -- drop unreferenced functions and variables - `unused` -- drop unreferenced functions and variables
- `hoist_funs` -- hoist function declarations - `hoist_funs` -- hoist function declarations
- `hoist_vars` (default: false) -- hoist `var` declarations (this is `false` - `hoist_vars` (default: false) -- hoist `var` declarations (this is `false`
by default because it seems to increase the size of the output in general) by default because it seems to increase the size of the output in general)
- `if_return` -- optimizations for if/return and if/continue - `if_return` -- optimizations for if/return and if/continue
- `join_vars` -- join consecutive `var` statements - `join_vars` -- join consecutive `var` statements
- `cascade` -- small optimization for sequences, transform `x, x` into `x` - `cascade` -- small optimization for sequences, transform `x, x` into `x`
and `x = something(), x` into `x = something()` and `x = something(), x` into `x = something()`
- `warnings` -- display warnings when dropping unreachable code or unused - `warnings` -- display warnings when dropping unreachable code or unused
declarations etc. declarations etc.
- `negate_iife` -- negate "Immediately-Called Function Expressions"
where the return value is discarded, to avoid the parens that the
code generator would insert.
- `pure_getters` -- the default is `false`. If you pass `true` for
this, UglifyJS will assume that object property access
(e.g. `foo.bar` or `foo["bar"]`) doesn't have any side effects.
- `pure_funcs` -- default `null`. You can pass an array of names and
UglifyJS will assume that those functions do not produce side
effects. DANGER: will not check if the name is redefined in scope.
An example case here, for instance `var q = Math.floor(a/b)`. If
variable `q` is not used elsewhere, UglifyJS will drop it, but will
still keep the `Math.floor(a/b)`, not knowing what it does. You can
pass `pure_funcs: [ 'Math.floor' ]` to let it know that this
function won't produce any side effect, in which case the whole
statement would get discarded. The current implementation adds some
overhead (compression will be slower).
- `drop_console` -- default `false`. Pass `true` to discard calls to
`console.*` functions.
### The `unsafe` option ### The `unsafe` option
It enables some transformations that *might* break code logic in certain It enables some transformations that *might* break code logic in certain
@@ -212,7 +268,7 @@ when this flag is on:
- `String(exp)` or `exp.toString()` → `"" + exp` - `String(exp)` or `exp.toString()` → `"" + exp`
- `new Object/RegExp/Function/Error/Array (...)` → we discard the `new` - `new Object/RegExp/Function/Error/Array (...)` → we discard the `new`
- `typeof foo == "undefined"` → `foo === void 0` - `typeof foo == "undefined"` → `foo === void 0`
- `void 0` → `"undefined"` (if there is a variable named "undefined" in - `void 0` → `undefined` (if there is a variable named "undefined" in
scope; we do it because the variable name will be mangled, typically scope; we do it because the variable name will be mangled, typically
reduced to a single character). reduced to a single character).
@@ -222,10 +278,11 @@ You can use the `--define` (`-d`) switch in order to declare global
variables that UglifyJS will assume to be constants (unless defined in variables that UglifyJS will assume to be constants (unless defined in
scope). For example if you pass `--define DEBUG=false` then, coupled with scope). For example if you pass `--define DEBUG=false` then, coupled with
dead code removal UglifyJS will discard the following from the output: dead code removal UglifyJS will discard the following from the output:
```javascript
if (DEBUG) { if (DEBUG) {
console.log("debug stuff"); console.log("debug stuff");
} }
```
UglifyJS will warn about the condition being always false and about dropping UglifyJS will warn about the condition being always false and about dropping
unreachable code; for now there is no option to turn off only this specific unreachable code; for now there is no option to turn off only this specific
@@ -234,10 +291,11 @@ warning, you can pass `warnings=false` to turn off *all* warnings.
Another way of doing that is to declare your globals as constants in a Another way of doing that is to declare your globals as constants in a
separate file and include it into the build. For example you can have a separate file and include it into the build. For example you can have a
`build/defines.js` file with the following: `build/defines.js` file with the following:
```javascript
const DEBUG = false; const DEBUG = false;
const PRODUCTION = true; const PRODUCTION = true;
// etc. // etc.
```
and build your code like this: and build your code like this:
@@ -274,9 +332,6 @@ can pass additional arguments that control the code output:
It doesn't work very well currently, but it does make the code generated It doesn't work very well currently, but it does make the code generated
by UglifyJS more readable. by UglifyJS more readable.
- `max-line-len` (default 32000) -- maximum line length (for uglified code) - `max-line-len` (default 32000) -- maximum line length (for uglified code)
- `ie-proof` (default `true`) -- generate “IE-proof” code (for now this
means add brackets around the do/while in code like this: `if (foo) do
something(); while (bar); else ...`.
- `bracketize` (default `false`) -- always insert brackets in `if`, `for`, - `bracketize` (default `false`) -- always insert brackets in `if`, `for`,
`do`, `while` or `with` statements, even if their body is a single `do`, `while` or `with` statements, even if their body is a single
statement. statement.
@@ -284,6 +339,10 @@ can pass additional arguments that control the code output:
you pass `false` then whenever possible we will use a newline instead of a you pass `false` then whenever possible we will use a newline instead of a
semicolon, leading to more readable output of uglified code (size before semicolon, leading to more readable output of uglified code (size before
gzip could be smaller; size after gzip insignificantly larger). gzip could be smaller; size after gzip insignificantly larger).
- `preamble` (default `null`) -- when passed it must be a string and
it will be prepended to the output literally. The source map will
adjust for this text. Can be used to insert a comment containing
licensing information, for example.
### Keeping copyright notices or other comments ### Keeping copyright notices or other comments
@@ -296,14 +355,15 @@ keep only comments that match this regexp. For example `--comments
Note, however, that there might be situations where comments are lost. For Note, however, that there might be situations where comments are lost. For
example: example:
```javascript
function f() { function f() {
/** @preserve Foo Bar */ /** @preserve Foo Bar */
function g() { function g() {
// this function is never called // this function is never called
} }
return something(); return something();
} }
```
Even though it has "@preserve", the comment will be lost because the inner Even though it has "@preserve", the comment will be lost because the inner
function `g` (which is the AST node to which the comment is attached to) is function `g` (which is the AST node to which the comment is attached to) is
@@ -345,8 +405,9 @@ API Reference
Assuming installation via NPM, you can load UglifyJS in your application Assuming installation via NPM, you can load UglifyJS in your application
like this: like this:
```javascript
var UglifyJS = require("uglify-js"); var UglifyJS = require("uglify-js");
```
It exports a lot of names, but I'll discuss here the basics that are needed It exports a lot of names, but I'll discuss here the basics that are needed
for parsing, mangling and compressing a piece of code. The sequence is (1) for parsing, mangling and compressing a piece of code. The sequence is (1)
@@ -357,45 +418,49 @@ parse, (2) compress, (3) mangle, (4) generate output code.
There's a single toplevel function which combines all the steps. If you There's a single toplevel function which combines all the steps. If you
don't need additional customization, you might want to go with `minify`. don't need additional customization, you might want to go with `minify`.
Example: Example:
```javascript
var result = UglifyJS.minify("/path/to/file.js"); var result = UglifyJS.minify("/path/to/file.js");
console.log(result.code); // minified output console.log(result.code); // minified output
// if you need to pass code instead of file name // if you need to pass code instead of file name
var result = UglifyJS.minify("var b = function () {};", {fromString: true}); var result = UglifyJS.minify("var b = function () {};", {fromString: true});
```
You can also compress multiple files: You can also compress multiple files:
```javascript
var result = UglifyJS.minify([ "file1.js", "file2.js", "file3.js" ]); var result = UglifyJS.minify([ "file1.js", "file2.js", "file3.js" ]);
console.log(result.code); console.log(result.code);
```
To generate a source map: To generate a source map:
```javascript
var result = UglifyJS.minify([ "file1.js", "file2.js", "file3.js" ], { var result = UglifyJS.minify([ "file1.js", "file2.js", "file3.js" ], {
outSourceMap: "out.js.map" outSourceMap: "out.js.map"
}); });
console.log(result.code); // minified output console.log(result.code); // minified output
console.log(result.map); console.log(result.map);
```
Note that the source map is not saved in a file, it's just returned in Note that the source map is not saved in a file, it's just returned in
`result.map`. The value passed for `outSourceMap` is only used to set the `result.map`. The value passed for `outSourceMap` is only used to set the
`file` attribute in the source map (see [the spec][sm-spec]). `file` attribute in the source map (see [the spec][sm-spec]).
You can also specify sourceRoot property to be included in source map: You can also specify sourceRoot property to be included in source map:
```javascript
var result = UglifyJS.minify([ "file1.js", "file2.js", "file3.js" ], { var result = UglifyJS.minify([ "file1.js", "file2.js", "file3.js" ], {
outSourceMap: "out.js.map", outSourceMap: "out.js.map",
sourceRoot: "http://example.com/src" sourceRoot: "http://example.com/src"
}); });
```
If you're compressing compiled JavaScript and have a source map for it, you If you're compressing compiled JavaScript and have a source map for it, you
can use the `inSourceMap` argument: can use the `inSourceMap` argument:
```javascript
var result = UglifyJS.minify("compiled.js", { var result = UglifyJS.minify("compiled.js", {
inSourceMap: "compiled.js.map", inSourceMap: "compiled.js.map",
outSourceMap: "minified.js.map" outSourceMap: "minified.js.map"
}); });
// same as before, it returns `code` and `map` // same as before, it returns `code` and `map`
```
The `inSourceMap` is only used if you also request `outSourceMap` (it makes The `inSourceMap` is only used if you also request `outSourceMap` (it makes
no sense otherwise). no sense otherwise).
@@ -425,8 +490,9 @@ Following there's more detailed API info, in case the `minify` function is
too simple for your needs. too simple for your needs.
#### The parser #### The parser
```javascript
var toplevel_ast = UglifyJS.parse(code, options); var toplevel_ast = UglifyJS.parse(code, options);
```
`options` is optional and if present it must be an object. The following `options` is optional and if present it must be an object. The following
properties are available: properties are available:
@@ -440,15 +506,16 @@ properties are available:
The last two options are useful when you'd like to minify multiple files and The last two options are useful when you'd like to minify multiple files and
get a single file as the output and a proper source map. Our CLI tool does get a single file as the output and a proper source map. Our CLI tool does
something like this: something like this:
```javascript
var toplevel = null; var toplevel = null;
files.forEach(function(file){ files.forEach(function(file){
var code = fs.readFileSync(file); var code = fs.readFileSync(file, "utf8");
toplevel = UglifyJS.parse(code, { toplevel = UglifyJS.parse(code, {
filename: file, filename: file,
toplevel: toplevel toplevel: toplevel
}); });
}); });
```
After this, we have in `toplevel` a big AST containing all our files, with After this, we have in `toplevel` a big AST containing all our files, with
each token having proper information about where it came from. each token having proper information about where it came from.
@@ -462,15 +529,17 @@ referenced, if it is a global or not, if a function is using `eval` or the
`with` statement etc. I will discuss this some place else, for now what's `with` statement etc. I will discuss this some place else, for now what's
important to know is that you need to call the following before doing important to know is that you need to call the following before doing
anything with the tree: anything with the tree:
```javascript
toplevel.figure_out_scope() toplevel.figure_out_scope()
```
#### Compression #### Compression
Like this: Like this:
```javascript
var compressor = UglifyJS.Compressor(options); var compressor = UglifyJS.Compressor(options);
var compressed_ast = toplevel.transform(compressor); var compressed_ast = toplevel.transform(compressor);
```
The `options` can be missing. Available options are discussed above in The `options` can be missing. Available options are discussed above in
“Compressor options”. Defaults should lead to best compression in most “Compressor options”. Defaults should lead to best compression in most
@@ -486,23 +555,26 @@ the compressor might drop unused variables / unreachable code and this might
change the number of identifiers or their position). Optionally, you can change the number of identifiers or their position). Optionally, you can
call a trick that helps after Gzip (counting character frequency in call a trick that helps after Gzip (counting character frequency in
non-mangleable words). Example: non-mangleable words). Example:
```javascript
compressed_ast.figure_out_scope(); compressed_ast.figure_out_scope();
compressed_ast.compute_char_frequency(); compressed_ast.compute_char_frequency();
compressed_ast.mangle_names(); compressed_ast.mangle_names();
```
#### Generating output #### Generating output
AST nodes have a `print` method that takes an output stream. Essentially, AST nodes have a `print` method that takes an output stream. Essentially,
to generate code you do this: to generate code you do this:
```javascript
var stream = UglifyJS.OutputStream(options); var stream = UglifyJS.OutputStream(options);
compressed_ast.print(stream); compressed_ast.print(stream);
var code = stream.toString(); // this is your minified code var code = stream.toString(); // this is your minified code
```
or, for a shortcut you can do: or, for a shortcut you can do:
```javascript
var code = compressed_ast.print_to_string(options); var code = compressed_ast.print_to_string(options);
```
As usual, `options` is optional. The output stream accepts a lot of otions, As usual, `options` is optional. The output stream accepts a lot of otions,
most of them documented above in section “Beautifier options”. The two most of them documented above in section “Beautifier options”. The two
@@ -540,16 +612,17 @@ to be a `SourceMap` object (which is a thin wrapper on top of the
[source-map][source-map] library). [source-map][source-map] library).
Example: Example:
```javascript
var source_map = UglifyJS.SourceMap(source_map_options);
var stream = UglifyJS.OutputStream({
...
source_map: source_map
});
compressed_ast.print(stream);
var source_map = UglifyJS.SourceMap(source_map_options); var code = stream.toString();
var stream = UglifyJS.OutputStream({ var map = source_map.toString(); // json output for your source map
... ```
source_map: source_map
});
compressed_ast.print(stream);
var code = stream.toString();
var map = source_map.toString(); // json output for your source map
The `source_map_options` (optional) can contain the following properties: The `source_map_options` (optional) can contain the following properties:

View File

@@ -7,6 +7,7 @@ var UglifyJS = require("../tools/node");
var sys = require("util"); var sys = require("util");
var optimist = require("optimist"); var optimist = require("optimist");
var fs = require("fs"); var fs = require("fs");
var path = require("path");
var async = require("async"); var async = require("async");
var acorn; var acorn;
var ARGS = optimist var ARGS = optimist
@@ -20,11 +21,15 @@ mangling you need to use `-c` and `-m`.\
") ")
.describe("source-map", "Specify an output file where to generate source map.") .describe("source-map", "Specify an output file where to generate source map.")
.describe("source-map-root", "The path to the original source to be included in the source map.") .describe("source-map-root", "The path to the original source to be included in the source map.")
.describe("source-map-url", "The path to the source map to be added in //@ sourceMappingURL. Defaults to the value passed with --source-map.") .describe("source-map-url", "The path to the source map to be added in //# sourceMappingURL. Defaults to the value passed with --source-map.")
.describe("source-map-include-sources", "Pass this flag if you want to include the content of source files in the source map as sourcesContent property.")
.describe("in-source-map", "Input source map, useful if you're compressing JS that was generated from some other original code.") .describe("in-source-map", "Input source map, useful if you're compressing JS that was generated from some other original code.")
.describe("screw-ie8", "Pass this flag if you don't care about full compliance with Internet Explorer 6-8 quirks (by default UglifyJS will try to be IE-proof).") .describe("screw-ie8", "Pass this flag if you don't care about full compliance with Internet Explorer 6-8 quirks (by default UglifyJS will try to be IE-proof).")
.describe("expr", "Parse a single expression, rather than a program (for parsing JSON)")
.describe("p", "Skip prefix for original filenames that appear in source maps. \ .describe("p", "Skip prefix for original filenames that appear in source maps. \
For example -p 3 will drop 3 directories from file names and ensure they are relative paths.") For example -p 3 will drop 3 directories from file names and ensure they are relative paths. \
You can also specify -p relative, which will make UglifyJS figure out itself the relative paths between original sources, \
the source map and the output file.")
.describe("o", "Output file (default STDOUT).") .describe("o", "Output file (default STDOUT).")
.describe("b", "Beautify output/specify output options.") .describe("b", "Beautify output/specify output options.")
.describe("m", "Mangle names/pass mangler options.") .describe("m", "Mangle names/pass mangler options.")
@@ -44,9 +49,13 @@ You can optionally pass one of the following arguments to this flag:\n\
Note that currently not *all* comments can be kept when compression is on, \ Note that currently not *all* comments can be kept when compression is on, \
because of dead code removal or cascading statements into sequences.") because of dead code removal or cascading statements into sequences.")
.describe("preamble", "Preamble to prepend to the output. You can use this to insert a \
comment, for example for licensing information. This will not be \
parsed, but the source map will adjust for its presence.")
.describe("stats", "Display operations run time on STDERR.") .describe("stats", "Display operations run time on STDERR.")
.describe("acorn", "Use Acorn for parsing.") .describe("acorn", "Use Acorn for parsing.")
.describe("spidermonkey", "Assume input fles are SpiderMonkey AST format (as JSON).") .describe("spidermonkey", "Assume input files are SpiderMonkey AST format (as JSON).")
.describe("self", "Build itself (UglifyJS2) as a library (implies --wrap=UglifyJS --export-all)") .describe("self", "Build itself (UglifyJS2) as a library (implies --wrap=UglifyJS --export-all)")
.describe("wrap", "Embed everything in a big function, making the “exports” and “global” variables available. \ .describe("wrap", "Embed everything in a big function, making the “exports” and “global” variables available. \
You need to pass an argument to this option to specify the name that your module will take when included in, say, a browser.") You need to pass an argument to this option to specify the name that your module will take when included in, say, a browser.")
@@ -54,6 +63,7 @@ You need to pass an argument to this option to specify the name that your module
.describe("lint", "Display some scope warnings") .describe("lint", "Display some scope warnings")
.describe("v", "Verbose") .describe("v", "Verbose")
.describe("V", "Print version number and exit.") .describe("V", "Print version number and exit.")
.describe("noerr", "Don't throw an error for unknown options in -c, -b or -m.")
.alias("p", "prefix") .alias("p", "prefix")
.alias("o", "output") .alias("o", "output")
@@ -76,6 +86,10 @@ You need to pass an argument to this option to specify the name that your module
.string("e") .string("e")
.string("comments") .string("comments")
.string("wrap") .string("wrap")
.string("p")
.boolean("expr")
.boolean("source-map-include-sources")
.boolean("screw-ie8") .boolean("screw-ie8")
.boolean("export-all") .boolean("export-all")
.boolean("self") .boolean("self")
@@ -85,6 +99,7 @@ You need to pass an argument to this option to specify the name that your module
.boolean("spidermonkey") .boolean("spidermonkey")
.boolean("lint") .boolean("lint")
.boolean("V") .boolean("V")
.boolean("noerr")
.wrap(80) .wrap(80)
@@ -93,6 +108,12 @@ You need to pass an argument to this option to specify the name that your module
normalize(ARGS); normalize(ARGS);
if (ARGS.noerr) {
UglifyJS.DefaultsError.croak = function(msg, defs) {
sys.error("WARN: " + msg);
};
}
if (ARGS.version || ARGS.V) { if (ARGS.version || ARGS.V) {
var json = require("../package.json"); var json = require("../package.json");
sys.puts(json.name + ' ' + json.version); sys.puts(json.name + ' ' + json.version);
@@ -122,19 +143,21 @@ if (ARGS.d) {
if (COMPRESS) COMPRESS.global_defs = getOptions("d"); if (COMPRESS) COMPRESS.global_defs = getOptions("d");
} }
if (ARGS.screw_ie8) {
if (COMPRESS) COMPRESS.screw_ie8 = true;
if (MANGLE) MANGLE.screw_ie8 = true;
}
if (ARGS.r) { if (ARGS.r) {
if (MANGLE) MANGLE.except = ARGS.r.replace(/^\s+|\s+$/g).split(/\s*,+\s*/); if (MANGLE) MANGLE.except = ARGS.r.replace(/^\s+|\s+$/g).split(/\s*,+\s*/);
} }
var OUTPUT_OPTIONS = { var OUTPUT_OPTIONS = {
beautify: BEAUTIFY ? true : false beautify: BEAUTIFY ? true : false,
preamble: ARGS.preamble || null,
}; };
if (ARGS.screw_ie8) {
if (COMPRESS) COMPRESS.screw_ie8 = true;
if (MANGLE) MANGLE.screw_ie8 = true;
OUTPUT_OPTIONS.screw_ie8 = true;
}
if (BEAUTIFY) if (BEAUTIFY)
UglifyJS.merge(OUTPUT_OPTIONS, BEAUTIFY); UglifyJS.merge(OUTPUT_OPTIONS, BEAUTIFY);
@@ -196,9 +219,11 @@ if (files.filter(function(el){ return el == "-" }).length > 1) {
var STATS = {}; var STATS = {};
var OUTPUT_FILE = ARGS.o; var OUTPUT_FILE = ARGS.o;
var TOPLEVEL = null; var TOPLEVEL = null;
var P_RELATIVE = ARGS.p && ARGS.p == "relative";
var SOURCES_CONTENT = {};
var SOURCE_MAP = ARGS.source_map ? UglifyJS.SourceMap({ var SOURCE_MAP = ARGS.source_map ? UglifyJS.SourceMap({
file: OUTPUT_FILE, file: P_RELATIVE ? path.relative(path.dirname(ARGS.source_map), OUTPUT_FILE) : OUTPUT_FILE,
root: ARGS.source_map_root, root: ARGS.source_map_root,
orig: ORIG_MAP, orig: ORIG_MAP,
}) : null; }) : null;
@@ -220,12 +245,20 @@ try {
async.eachLimit(files, 1, function (file, cb) { async.eachLimit(files, 1, function (file, cb) {
read_whole_file(file, function (err, code) { read_whole_file(file, function (err, code) {
if (err) { if (err) {
sys.error("ERROR: can't read file: " + filename); sys.error("ERROR: can't read file: " + file);
process.exit(1); process.exit(1);
} }
if (ARGS.p != null) { if (ARGS.p != null) {
file = file.replace(/^\/+/, "").split(/\/+/).slice(ARGS.p).join("/"); if (P_RELATIVE) {
file = path.relative(path.dirname(ARGS.source_map), file);
} else {
var p = parseInt(ARGS.p, 10);
if (!isNaN(p)) {
file = file.replace(/^\/+/, "").split(/\/+/).slice(ARGS.p).join("/");
}
}
} }
SOURCES_CONTENT[file] = code;
time_it("parse", function(){ time_it("parse", function(){
if (ARGS.spidermonkey) { if (ARGS.spidermonkey) {
var program = JSON.parse(code); var program = JSON.parse(code);
@@ -235,16 +268,26 @@ async.eachLimit(files, 1, function (file, cb) {
else if (ARGS.acorn) { else if (ARGS.acorn) {
TOPLEVEL = acorn.parse(code, { TOPLEVEL = acorn.parse(code, {
locations : true, locations : true,
trackComments : true,
sourceFile : file, sourceFile : file,
program : TOPLEVEL program : TOPLEVEL
}); });
} }
else { else {
TOPLEVEL = UglifyJS.parse(code, { try {
filename: file, TOPLEVEL = UglifyJS.parse(code, {
toplevel: TOPLEVEL filename : file,
}); toplevel : TOPLEVEL,
expression : ARGS.expr,
});
} catch(ex) {
if (ex instanceof UglifyJS.JS_Parse_Error) {
sys.error("Parse error at " + file + ":" + ex.line + "," + ex.col);
sys.error(ex.message);
sys.error(ex.stack);
process.exit(1);
}
throw ex;
}
}; };
}); });
cb(); cb();
@@ -260,11 +303,12 @@ async.eachLimit(files, 1, function (file, cb) {
if (ARGS.enclose) { if (ARGS.enclose) {
var arg_parameter_list = ARGS.enclose; var arg_parameter_list = ARGS.enclose;
if (arg_parameter_list === true) {
if (!(arg_parameter_list instanceof Array)) { arg_parameter_list = [];
}
else if (!(arg_parameter_list instanceof Array)) {
arg_parameter_list = [arg_parameter_list]; arg_parameter_list = [arg_parameter_list];
} }
TOPLEVEL = TOPLEVEL.wrap_enclose(arg_parameter_list); TOPLEVEL = TOPLEVEL.wrap_enclose(arg_parameter_list);
} }
@@ -297,6 +341,15 @@ async.eachLimit(files, 1, function (file, cb) {
if (MANGLE) time_it("mangle", function(){ if (MANGLE) time_it("mangle", function(){
TOPLEVEL.mangle_names(MANGLE); TOPLEVEL.mangle_names(MANGLE);
}); });
if (ARGS.source_map_include_sources) {
for (var file in SOURCES_CONTENT) {
if (SOURCES_CONTENT.hasOwnProperty(file)) {
SOURCE_MAP.get().setSourceContent(file, SOURCES_CONTENT[file]);
}
}
}
time_it("generate", function(){ time_it("generate", function(){
TOPLEVEL.print(output); TOPLEVEL.print(output);
}); });
@@ -305,14 +358,18 @@ async.eachLimit(files, 1, function (file, cb) {
if (SOURCE_MAP) { if (SOURCE_MAP) {
fs.writeFileSync(ARGS.source_map, SOURCE_MAP, "utf8"); fs.writeFileSync(ARGS.source_map, SOURCE_MAP, "utf8");
output += "\n/*\n//@ sourceMappingURL=" + (ARGS.source_map_url || ARGS.source_map) + "\n*/"; var source_map_url = ARGS.source_map_url || (
P_RELATIVE
? path.relative(path.dirname(OUTPUT_FILE), ARGS.source_map)
: ARGS.source_map
);
output += "\n//# sourceMappingURL=" + source_map_url;
} }
if (OUTPUT_FILE) { if (OUTPUT_FILE) {
fs.writeFileSync(OUTPUT_FILE, output, "utf8"); fs.writeFileSync(OUTPUT_FILE, output, "utf8");
} else { } else {
sys.print(output); sys.print(output);
sys.error("\n");
} }
if (ARGS.stats) { if (ARGS.stats) {
@@ -344,7 +401,7 @@ function getOptions(x, constants) {
if (x !== true) { if (x !== true) {
var ast; var ast;
try { try {
ast = UglifyJS.parse(x); ast = UglifyJS.parse(x, { expression: true });
} catch(ex) { } catch(ex) {
if (ex instanceof UglifyJS.JS_Parse_Error) { if (ex instanceof UglifyJS.JS_Parse_Error) {
sys.error("Error parsing arguments in: " + x); sys.error("Error parsing arguments in: " + x);
@@ -352,8 +409,6 @@ function getOptions(x, constants) {
} }
} }
ast.walk(new UglifyJS.TreeWalker(function(node){ ast.walk(new UglifyJS.TreeWalker(function(node){
if (node instanceof UglifyJS.AST_Toplevel) return; // descend
if (node instanceof UglifyJS.AST_SimpleStatement) return; // descend
if (node instanceof UglifyJS.AST_Seq) return; // descend if (node instanceof UglifyJS.AST_Seq) return; // descend
if (node instanceof UglifyJS.AST_Assign) { if (node instanceof UglifyJS.AST_Assign) {
var name = node.left.print_to_string({ beautify: false }).replace(/-/g, "_"); var name = node.left.print_to_string({ beautify: false }).replace(/-/g, "_");
@@ -363,6 +418,11 @@ function getOptions(x, constants) {
ret[name] = value; ret[name] = value;
return true; // no descend return true; // no descend
} }
if (node instanceof UglifyJS.AST_Symbol || node instanceof UglifyJS.AST_Binary) {
var name = node.print_to_string({ beautify: false }).replace(/-/g, "_");
ret[name] = true;
return true; // no descend
}
sys.error(node.TYPE) sys.error(node.TYPE)
sys.error("Error parsing arguments in: " + x); sys.error("Error parsing arguments in: " + x);
process.exit(1); process.exit(1);

View File

@@ -197,6 +197,10 @@ var AST_LabeledStatement = DEFNODE("LabeledStatement", "label", {
} }
}, AST_StatementWithBody); }, AST_StatementWithBody);
var AST_IterationStatement = DEFNODE("IterationStatement", null, {
$documentation: "Internal class. All loops inherit from it."
}, AST_StatementWithBody);
var AST_DWLoop = DEFNODE("DWLoop", "condition", { var AST_DWLoop = DEFNODE("DWLoop", "condition", {
$documentation: "Base class for do/while statements", $documentation: "Base class for do/while statements",
$propdoc: { $propdoc: {
@@ -208,7 +212,7 @@ var AST_DWLoop = DEFNODE("DWLoop", "condition", {
this.body._walk(visitor); this.body._walk(visitor);
}); });
} }
}, AST_StatementWithBody); }, AST_IterationStatement);
var AST_Do = DEFNODE("Do", null, { var AST_Do = DEFNODE("Do", null, {
$documentation: "A `do` statement", $documentation: "A `do` statement",
@@ -233,7 +237,7 @@ var AST_For = DEFNODE("For", "init condition step", {
this.body._walk(visitor); this.body._walk(visitor);
}); });
} }
}, AST_StatementWithBody); }, AST_IterationStatement);
var AST_ForIn = DEFNODE("ForIn", "init name object", { var AST_ForIn = DEFNODE("ForIn", "init name object", {
$documentation: "A `for ... in` statement", $documentation: "A `for ... in` statement",
@@ -249,7 +253,7 @@ var AST_ForIn = DEFNODE("ForIn", "init name object", {
this.body._walk(visitor); this.body._walk(visitor);
}); });
} }
}, AST_StatementWithBody); }, AST_IterationStatement);
var AST_With = DEFNODE("With", "expression", { var AST_With = DEFNODE("With", "expression", {
$documentation: "A `with` statement", $documentation: "A `with` statement",
@@ -367,7 +371,7 @@ var AST_Lambda = DEFNODE("Lambda", "name argnames uses_arguments", {
}, AST_Scope); }, AST_Scope);
var AST_Accessor = DEFNODE("Accessor", null, { var AST_Accessor = DEFNODE("Accessor", null, {
$documentation: "A setter/getter function" $documentation: "A setter/getter function. The `name` property is always null."
}, AST_Lambda); }, AST_Lambda);
var AST_Function = DEFNODE("Function", null, { var AST_Function = DEFNODE("Function", null, {
@@ -494,12 +498,6 @@ var AST_Try = DEFNODE("Try", "bcatch bfinally", {
} }
}, AST_Block); }, AST_Block);
// XXX: this is wrong according to ECMA-262 (12.4). the catch block
// should introduce another scope, as the argname should be visible
// only inside the catch block. However, doing it this way because of
// IE which simply introduces the name in the surrounding scope. If
// we ever want to fix this then AST_Catch should inherit from
// AST_Scope.
var AST_Catch = DEFNODE("Catch", "argname", { var AST_Catch = DEFNODE("Catch", "argname", {
$documentation: "A `catch` node; only makes sense as part of a `try` statement", $documentation: "A `catch` node; only makes sense as part of a `try` statement",
$propdoc: { $propdoc: {
@@ -752,7 +750,7 @@ var AST_Object = DEFNODE("Object", "properties", {
var AST_ObjectProperty = DEFNODE("ObjectProperty", "key value", { var AST_ObjectProperty = DEFNODE("ObjectProperty", "key value", {
$documentation: "Base class for literal object properties", $documentation: "Base class for literal object properties",
$propdoc: { $propdoc: {
key: "[string] the property name; it's always a plain string in our AST, no matter if it was a string, number or identifier in original code", key: "[string] the property name converted to a string for ObjectKeyVal. For setters and getters this is an arbitrary AST_Node.",
value: "[AST_Node] property value. For setters and getters this is an AST_Function." value: "[AST_Node] property value. For setters and getters this is an AST_Function."
}, },
_walk: function(visitor) { _walk: function(visitor) {
@@ -821,7 +819,11 @@ var AST_SymbolCatch = DEFNODE("SymbolCatch", null, {
var AST_Label = DEFNODE("Label", "references", { var AST_Label = DEFNODE("Label", "references", {
$documentation: "Symbol naming a label (declaration)", $documentation: "Symbol naming a label (declaration)",
$propdoc: { $propdoc: {
references: "[AST_LabelRef*] a list of nodes referring to this label" references: "[AST_LoopControl*] a list of nodes referring to this label"
},
initialize: function() {
this.references = [];
this.thedef = this;
} }
}, AST_Symbol); }, AST_Symbol);
@@ -945,6 +947,9 @@ TreeWalker.prototype = {
if (x instanceof type) return x; if (x instanceof type) return x;
} }
}, },
has_directive: function(type) {
return this.find_parent(AST_Scope).has_directive(type);
},
in_boolean_context: function() { in_boolean_context: function() {
var stack = this.stack; var stack = this.stack;
var i = stack.length, self = stack[--i]; var i = stack.length, self = stack[--i];
@@ -965,21 +970,15 @@ TreeWalker.prototype = {
}, },
loopcontrol_target: function(label) { loopcontrol_target: function(label) {
var stack = this.stack; var stack = this.stack;
if (label) { if (label) for (var i = stack.length; --i >= 0;) {
for (var i = stack.length; --i >= 0;) { var x = stack[i];
var x = stack[i]; if (x instanceof AST_LabeledStatement && x.label.name == label.name) {
if (x instanceof AST_LabeledStatement && x.label.name == label.name) { return x.body;
return x.body;
}
}
} else {
for (var i = stack.length; --i >= 0;) {
var x = stack[i];
if (x instanceof AST_Switch
|| x instanceof AST_For
|| x instanceof AST_ForIn
|| x instanceof AST_DWLoop) return x;
} }
} else for (var i = stack.length; --i >= 0;) {
var x = stack[i];
if (x instanceof AST_Switch || x instanceof AST_IterationStatement)
return x;
} }
} }
}; };

View File

@@ -61,12 +61,18 @@ function Compressor(options, false_by_default) {
loops : !false_by_default, loops : !false_by_default,
unused : !false_by_default, unused : !false_by_default,
hoist_funs : !false_by_default, hoist_funs : !false_by_default,
keep_fargs : false,
hoist_vars : false, hoist_vars : false,
if_return : !false_by_default, if_return : !false_by_default,
join_vars : !false_by_default, join_vars : !false_by_default,
cascade : !false_by_default, cascade : !false_by_default,
side_effects : !false_by_default, side_effects : !false_by_default,
pure_getters : false,
pure_funcs : null,
negate_iife : !false_by_default,
screw_ie8 : false, screw_ie8 : false,
drop_console : false,
angular : false,
warnings : true, warnings : true,
global_defs : {} global_defs : {}
@@ -82,22 +88,16 @@ merge(Compressor.prototype, {
}, },
before: function(node, descend, in_list) { before: function(node, descend, in_list) {
if (node._squeezed) return node; if (node._squeezed) return node;
var was_scope = false;
if (node instanceof AST_Scope) { if (node instanceof AST_Scope) {
node.drop_unused(this);
node = node.hoist_declarations(this); node = node.hoist_declarations(this);
was_scope = true;
} }
descend(node, this); descend(node, this);
node = node.optimize(this); node = node.optimize(this);
if (node instanceof AST_Scope) { if (was_scope && node instanceof AST_Scope) {
// dead code removal might leave further unused declarations.
// this'll usually save very few bytes, but the performance
// hit seems negligible so I'll just drop it here.
// no point to repeat warnings.
var save_warnings = this.options.warnings;
this.options.warnings = false;
node.drop_unused(this); node.drop_unused(this);
this.options.warnings = save_warnings; descend(node, this);
} }
node._squeezed = true; node._squeezed = true;
return node; return node;
@@ -200,6 +200,9 @@ merge(Compressor.prototype, {
var CHANGED; var CHANGED;
do { do {
CHANGED = false; CHANGED = false;
if (compressor.option("angular")) {
statements = process_for_angular(statements);
}
statements = eliminate_spurious_blocks(statements); statements = eliminate_spurious_blocks(statements);
if (compressor.option("dead_code")) { if (compressor.option("dead_code")) {
statements = eliminate_dead_code(statements, compressor); statements = eliminate_dead_code(statements, compressor);
@@ -214,8 +217,57 @@ merge(Compressor.prototype, {
statements = join_consecutive_vars(statements, compressor); statements = join_consecutive_vars(statements, compressor);
} }
} while (CHANGED); } while (CHANGED);
if (compressor.option("negate_iife")) {
negate_iifes(statements, compressor);
}
return statements; return statements;
function process_for_angular(statements) {
function make_injector(func, name) {
return make_node(AST_SimpleStatement, func, {
body: make_node(AST_Assign, func, {
operator: "=",
left: make_node(AST_Dot, name, {
expression: make_node(AST_SymbolRef, name, name),
property: "$inject"
}),
right: make_node(AST_Array, func, {
elements: func.argnames.map(function(sym){
return make_node(AST_String, sym, { value: sym.name });
})
})
})
});
}
return statements.reduce(function(a, stat){
a.push(stat);
var token = stat.start;
var comments = token.comments_before;
if (comments && comments.length > 0) {
var last = comments.pop();
if (/@ngInject/.test(last.value)) {
// case 1: defun
if (stat instanceof AST_Defun) {
a.push(make_injector(stat, stat.name));
}
else if (stat instanceof AST_Definitions) {
stat.definitions.forEach(function(def){
if (def.value && def.value instanceof AST_Lambda) {
a.push(make_injector(def.value, def.name));
}
});
}
else {
compressor.warn("Unknown statement marked with @ngInject [{file}:{line},{col}]", token);
}
}
}
return a;
}, []);
}
function eliminate_spurious_blocks(statements) { function eliminate_spurious_blocks(statements) {
var seen_dirs = []; var seen_dirs = [];
return statements.reduce(function(a, stat){ return statements.reduce(function(a, stat){
@@ -318,14 +370,14 @@ merge(Compressor.prototype, {
|| (ab instanceof AST_Continue && self === loop_body(lct)) || (ab instanceof AST_Continue && self === loop_body(lct))
|| (ab instanceof AST_Break && lct instanceof AST_BlockStatement && self === lct))) { || (ab instanceof AST_Break && lct instanceof AST_BlockStatement && self === lct))) {
if (ab.label) { if (ab.label) {
remove(ab.label.thedef.references, ab.label); remove(ab.label.thedef.references, ab);
} }
CHANGED = true; CHANGED = true;
var body = as_statement_array(stat.body).slice(0, -1); var body = as_statement_array(stat.body).slice(0, -1);
stat = stat.clone(); stat = stat.clone();
stat.condition = stat.condition.negate(compressor); stat.condition = stat.condition.negate(compressor);
stat.body = make_node(AST_BlockStatement, stat, { stat.body = make_node(AST_BlockStatement, stat, {
body: ret body: as_statement_array(stat.alternative).concat(ret)
}); });
stat.alternative = make_node(AST_BlockStatement, stat, { stat.alternative = make_node(AST_BlockStatement, stat, {
body: body body: body
@@ -340,7 +392,7 @@ merge(Compressor.prototype, {
|| (ab instanceof AST_Continue && self === loop_body(lct)) || (ab instanceof AST_Continue && self === loop_body(lct))
|| (ab instanceof AST_Break && lct instanceof AST_BlockStatement && self === lct))) { || (ab instanceof AST_Break && lct instanceof AST_BlockStatement && self === lct))) {
if (ab.label) { if (ab.label) {
remove(ab.label.thedef.references, ab.label); remove(ab.label.thedef.references, ab);
} }
CHANGED = true; CHANGED = true;
stat = stat.clone(); stat = stat.clone();
@@ -379,7 +431,7 @@ merge(Compressor.prototype, {
&& loop_body(lct) === self) || (stat instanceof AST_Continue && loop_body(lct) === self) || (stat instanceof AST_Continue
&& loop_body(lct) === self)) { && loop_body(lct) === self)) {
if (stat.label) { if (stat.label) {
remove(stat.label.thedef.references, stat.label); remove(stat.label.thedef.references, stat);
} }
} else { } else {
a.push(stat); a.push(stat);
@@ -497,6 +549,40 @@ merge(Compressor.prototype, {
}, []); }, []);
}; };
function negate_iifes(statements, compressor) {
statements.forEach(function(stat){
if (stat instanceof AST_SimpleStatement) {
stat.body = (function transform(thing) {
return thing.transform(new TreeTransformer(function(node){
if (node instanceof AST_Call && node.expression instanceof AST_Function) {
return make_node(AST_UnaryPrefix, node, {
operator: "!",
expression: node
});
}
else if (node instanceof AST_Call) {
node.expression = transform(node.expression);
}
else if (node instanceof AST_Seq) {
node.car = transform(node.car);
}
else if (node instanceof AST_Conditional) {
var expr = transform(node.condition);
if (expr !== node.condition) {
// it has been negated, reverse
node.condition = expr;
var tmp = node.consequent;
node.consequent = node.alternative;
node.alternative = tmp;
}
}
return node;
}));
})(stat.body);
}
});
};
}; };
function extract_declarations_from_unreachable_code(compressor, stat, target) { function extract_declarations_from_unreachable_code(compressor, stat, target) {
@@ -590,14 +676,14 @@ merge(Compressor.prototype, {
// elements. If the node has been successfully reduced to a // elements. If the node has been successfully reduced to a
// constant, then the second element tells us the value; // constant, then the second element tells us the value;
// otherwise the second element is missing. The first element // otherwise the second element is missing. The first element
// of the array is always an AST_Node descendant; when // of the array is always an AST_Node descendant; if
// evaluation was successful it's a node that represents the // evaluation was successful it's a node that represents the
// constant; otherwise it's the original node. // constant; otherwise it's the original or a replacement node.
AST_Node.DEFMETHOD("evaluate", function(compressor){ AST_Node.DEFMETHOD("evaluate", function(compressor){
if (!compressor.option("evaluate")) return [ this ]; if (!compressor.option("evaluate")) return [ this ];
try { try {
var val = this._eval(), ast = make_node_from_constant(compressor, val, this); var val = this._eval(compressor);
return [ best_of(ast, this), val ]; return [ best_of(make_node_from_constant(compressor, val, this), this), val ];
} catch(ex) { } catch(ex) {
if (ex !== def) throw ex; if (ex !== def) throw ex;
return [ this ]; return [ this ];
@@ -611,10 +697,12 @@ merge(Compressor.prototype, {
// inherits from AST_Statement; however, an AST_Function // inherits from AST_Statement; however, an AST_Function
// isn't really a statement. This could byte in other // isn't really a statement. This could byte in other
// places too. :-( Wish JS had multiple inheritance. // places too. :-( Wish JS had multiple inheritance.
return [ this ]; throw def;
}); });
function ev(node) { function ev(node, compressor) {
return node._eval(); if (!compressor) throw new Error("Compressor must be passed");
return node._eval(compressor);
}; };
def(AST_Node, function(){ def(AST_Node, function(){
throw def; // not constant throw def; // not constant
@@ -622,69 +710,69 @@ merge(Compressor.prototype, {
def(AST_Constant, function(){ def(AST_Constant, function(){
return this.getValue(); return this.getValue();
}); });
def(AST_UnaryPrefix, function(){ def(AST_UnaryPrefix, function(compressor){
var e = this.expression; var e = this.expression;
switch (this.operator) { switch (this.operator) {
case "!": return !ev(e); case "!": return !ev(e, compressor);
case "typeof": case "typeof":
// Function would be evaluated to an array and so typeof would // Function would be evaluated to an array and so typeof would
// incorrectly return 'object'. Hence making is a special case. // incorrectly return 'object'. Hence making is a special case.
if (e instanceof AST_Function) return typeof function(){}; if (e instanceof AST_Function) return typeof function(){};
e = ev(e); e = ev(e, compressor);
// typeof <RegExp> returns "object" or "function" on different platforms // typeof <RegExp> returns "object" or "function" on different platforms
// so cannot evaluate reliably // so cannot evaluate reliably
if (e instanceof RegExp) throw def; if (e instanceof RegExp) throw def;
return typeof e; return typeof e;
case "void": return void ev(e); case "void": return void ev(e, compressor);
case "~": return ~ev(e); case "~": return ~ev(e, compressor);
case "-": case "-":
e = ev(e); e = ev(e, compressor);
if (e === 0) throw def; if (e === 0) throw def;
return -e; return -e;
case "+": return +ev(e); case "+": return +ev(e, compressor);
} }
throw def; throw def;
}); });
def(AST_Binary, function(){ def(AST_Binary, function(c){
var left = this.left, right = this.right; var left = this.left, right = this.right;
switch (this.operator) { switch (this.operator) {
case "&&" : return ev(left) && ev(right); case "&&" : return ev(left, c) && ev(right, c);
case "||" : return ev(left) || ev(right); case "||" : return ev(left, c) || ev(right, c);
case "|" : return ev(left) | ev(right); case "|" : return ev(left, c) | ev(right, c);
case "&" : return ev(left) & ev(right); case "&" : return ev(left, c) & ev(right, c);
case "^" : return ev(left) ^ ev(right); case "^" : return ev(left, c) ^ ev(right, c);
case "+" : return ev(left) + ev(right); case "+" : return ev(left, c) + ev(right, c);
case "*" : return ev(left) * ev(right); case "*" : return ev(left, c) * ev(right, c);
case "/" : return ev(left) / ev(right); case "/" : return ev(left, c) / ev(right, c);
case "%" : return ev(left) % ev(right); case "%" : return ev(left, c) % ev(right, c);
case "-" : return ev(left) - ev(right); case "-" : return ev(left, c) - ev(right, c);
case "<<" : return ev(left) << ev(right); case "<<" : return ev(left, c) << ev(right, c);
case ">>" : return ev(left) >> ev(right); case ">>" : return ev(left, c) >> ev(right, c);
case ">>>" : return ev(left) >>> ev(right); case ">>>" : return ev(left, c) >>> ev(right, c);
case "==" : return ev(left) == ev(right); case "==" : return ev(left, c) == ev(right, c);
case "===" : return ev(left) === ev(right); case "===" : return ev(left, c) === ev(right, c);
case "!=" : return ev(left) != ev(right); case "!=" : return ev(left, c) != ev(right, c);
case "!==" : return ev(left) !== ev(right); case "!==" : return ev(left, c) !== ev(right, c);
case "<" : return ev(left) < ev(right); case "<" : return ev(left, c) < ev(right, c);
case "<=" : return ev(left) <= ev(right); case "<=" : return ev(left, c) <= ev(right, c);
case ">" : return ev(left) > ev(right); case ">" : return ev(left, c) > ev(right, c);
case ">=" : return ev(left) >= ev(right); case ">=" : return ev(left, c) >= ev(right, c);
case "in" : return ev(left) in ev(right); case "in" : return ev(left, c) in ev(right, c);
case "instanceof" : return ev(left) instanceof ev(right); case "instanceof" : return ev(left, c) instanceof ev(right, c);
} }
throw def; throw def;
}); });
def(AST_Conditional, function(){ def(AST_Conditional, function(compressor){
return ev(this.condition) return ev(this.condition, compressor)
? ev(this.consequent) ? ev(this.consequent, compressor)
: ev(this.alternative); : ev(this.alternative, compressor);
}); });
def(AST_SymbolRef, function(){ def(AST_SymbolRef, function(compressor){
var d = this.definition(); var d = this.definition();
if (d && d.constant && d.init) return ev(d.init); if (d && d.constant && d.init) return ev(d.init, compressor);
throw def; throw def;
}); });
})(function(node, func){ })(function(node, func){
@@ -760,70 +848,78 @@ merge(Compressor.prototype, {
// determine if expression has side effects // determine if expression has side effects
(function(def){ (function(def){
def(AST_Node, function(){ return true }); def(AST_Node, function(compressor){ return true });
def(AST_EmptyStatement, function(){ return false }); def(AST_EmptyStatement, function(compressor){ return false });
def(AST_Constant, function(){ return false }); def(AST_Constant, function(compressor){ return false });
def(AST_This, function(){ return false }); def(AST_This, function(compressor){ return false });
def(AST_Block, function(){ def(AST_Call, function(compressor){
var pure = compressor.option("pure_funcs");
if (!pure) return true;
return pure.indexOf(this.expression.print_to_string()) < 0;
});
def(AST_Block, function(compressor){
for (var i = this.body.length; --i >= 0;) { for (var i = this.body.length; --i >= 0;) {
if (this.body[i].has_side_effects()) if (this.body[i].has_side_effects(compressor))
return true; return true;
} }
return false; return false;
}); });
def(AST_SimpleStatement, function(){ def(AST_SimpleStatement, function(compressor){
return this.body.has_side_effects(); return this.body.has_side_effects(compressor);
}); });
def(AST_Defun, function(){ return true }); def(AST_Defun, function(compressor){ return true });
def(AST_Function, function(){ return false }); def(AST_Function, function(compressor){ return false });
def(AST_Binary, function(){ def(AST_Binary, function(compressor){
return this.left.has_side_effects() return this.left.has_side_effects(compressor)
|| this.right.has_side_effects(); || this.right.has_side_effects(compressor);
}); });
def(AST_Assign, function(){ return true }); def(AST_Assign, function(compressor){ return true });
def(AST_Conditional, function(){ def(AST_Conditional, function(compressor){
return this.condition.has_side_effects() return this.condition.has_side_effects(compressor)
|| this.consequent.has_side_effects() || this.consequent.has_side_effects(compressor)
|| this.alternative.has_side_effects(); || this.alternative.has_side_effects(compressor);
}); });
def(AST_Unary, function(){ def(AST_Unary, function(compressor){
return this.operator == "delete" return this.operator == "delete"
|| this.operator == "++" || this.operator == "++"
|| this.operator == "--" || this.operator == "--"
|| this.expression.has_side_effects(); || this.expression.has_side_effects(compressor);
}); });
def(AST_SymbolRef, function(){ return false }); def(AST_SymbolRef, function(compressor){ return false });
def(AST_Object, function(){ def(AST_Object, function(compressor){
for (var i = this.properties.length; --i >= 0;) for (var i = this.properties.length; --i >= 0;)
if (this.properties[i].has_side_effects()) if (this.properties[i].has_side_effects(compressor))
return true; return true;
return false; return false;
}); });
def(AST_ObjectProperty, function(){ def(AST_ObjectProperty, function(compressor){
return this.value.has_side_effects(); return this.value.has_side_effects(compressor);
}); });
def(AST_Array, function(){ def(AST_Array, function(compressor){
for (var i = this.elements.length; --i >= 0;) for (var i = this.elements.length; --i >= 0;)
if (this.elements[i].has_side_effects()) if (this.elements[i].has_side_effects(compressor))
return true; return true;
return false; return false;
}); });
// def(AST_Dot, function(){ def(AST_Dot, function(compressor){
// return this.expression.has_side_effects(); if (!compressor.option("pure_getters")) return true;
// }); return this.expression.has_side_effects(compressor);
// def(AST_Sub, function(){
// return this.expression.has_side_effects()
// || this.property.has_side_effects();
// });
def(AST_PropAccess, function(){
return true;
}); });
def(AST_Seq, function(){ def(AST_Sub, function(compressor){
return this.car.has_side_effects() if (!compressor.option("pure_getters")) return true;
|| this.cdr.has_side_effects(); return this.expression.has_side_effects(compressor)
|| this.property.has_side_effects(compressor);
});
def(AST_PropAccess, function(compressor){
return !compressor.option("pure_getters");
});
def(AST_Seq, function(compressor){
return this.car.has_side_effects(compressor)
|| this.cdr.has_side_effects(compressor);
}); });
})(function(node, func){ })(function(node, func){
node.DEFMETHOD("has_side_effects", func); node.DEFMETHOD("has_side_effects", func);
@@ -907,7 +1003,7 @@ merge(Compressor.prototype, {
node.definitions.forEach(function(def){ node.definitions.forEach(function(def){
if (def.value) { if (def.value) {
initializations.add(def.name.name, def.value); initializations.add(def.name.name, def.value);
if (def.value.has_side_effects()) { if (def.value.has_side_effects(compressor)) {
def.value.walk(tw); def.value.walk(tw);
} }
} }
@@ -948,19 +1044,21 @@ merge(Compressor.prototype, {
// pass 3: we should drop declarations not in_use // pass 3: we should drop declarations not in_use
var tt = new TreeTransformer( var tt = new TreeTransformer(
function before(node, descend, in_list) { function before(node, descend, in_list) {
if (node instanceof AST_Lambda) { if (node instanceof AST_Lambda && !(node instanceof AST_Accessor)) {
for (var a = node.argnames, i = a.length; --i >= 0;) { if (!compressor.option("keep_fargs")) {
var sym = a[i]; for (var a = node.argnames, i = a.length; --i >= 0;) {
if (sym.unreferenced()) { var sym = a[i];
a.pop(); if (sym.unreferenced()) {
compressor.warn("Dropping unused function argument {name} [{file}:{line},{col}]", { a.pop();
name : sym.name, compressor.warn("Dropping unused function argument {name} [{file}:{line},{col}]", {
file : sym.start.file, name : sym.name,
line : sym.start.line, file : sym.start.file,
col : sym.start.col line : sym.start.line,
}); col : sym.start.col
});
}
else break;
} }
else break;
} }
} }
if (node instanceof AST_Defun && node !== self) { if (node instanceof AST_Defun && node !== self) {
@@ -984,7 +1082,7 @@ merge(Compressor.prototype, {
line : def.name.start.line, line : def.name.start.line,
col : def.name.start.col col : def.name.start.col
}; };
if (def.value && def.value.has_side_effects()) { if (def.value && def.value.has_side_effects(compressor)) {
def._unused_side_effects = true; def._unused_side_effects = true;
compressor.warn("Side effects in initialization of unused variable {name} [{file}:{line},{col}]", w); compressor.warn("Side effects in initialization of unused variable {name} [{file}:{line},{col}]", w);
return true; return true;
@@ -1038,18 +1136,23 @@ merge(Compressor.prototype, {
} }
return node; return node;
} }
if (node instanceof AST_For && node.init instanceof AST_BlockStatement) { if (node instanceof AST_For) {
descend(node, this); descend(node, this);
// certain combination of unused name + side effect leads to:
// https://github.com/mishoo/UglifyJS2/issues/44 if (node.init instanceof AST_BlockStatement) {
// that's an invalid AST. // certain combination of unused name + side effect leads to:
// We fix it at this stage by moving the `var` outside the `for`. // https://github.com/mishoo/UglifyJS2/issues/44
var body = node.init.body.slice(0, -1); // that's an invalid AST.
node.init = node.init.body.slice(-1)[0].body; // We fix it at this stage by moving the `var` outside the `for`.
body.push(node);
return in_list ? MAP.splice(body) : make_node(AST_BlockStatement, node, { var body = node.init.body.slice(0, -1);
body: body node.init = node.init.body.slice(-1)[0].body;
}); body.push(node);
return in_list ? MAP.splice(body) : make_node(AST_BlockStatement, node, {
body: body
});
}
} }
if (node instanceof AST_Scope && node !== self) if (node instanceof AST_Scope && node !== self)
return node; return node;
@@ -1186,7 +1289,7 @@ merge(Compressor.prototype, {
OPT(AST_SimpleStatement, function(self, compressor){ OPT(AST_SimpleStatement, function(self, compressor){
if (compressor.option("side_effects")) { if (compressor.option("side_effects")) {
if (!self.body.has_side_effects()) { if (!self.body.has_side_effects(compressor)) {
compressor.warn("Dropping side-effect-free statement [{file}:{line},{col}]", self.start); compressor.warn("Dropping side-effect-free statement [{file}:{line},{col}]", self.start);
return make_node(AST_EmptyStatement, self); return make_node(AST_EmptyStatement, self);
} }
@@ -1570,7 +1673,7 @@ merge(Compressor.prototype, {
if (self.args.length != 1) { if (self.args.length != 1) {
return make_node(AST_Array, self, { return make_node(AST_Array, self, {
elements: self.args elements: self.args
}); }).transform(compressor);
} }
break; break;
case "Object": case "Object":
@@ -1584,11 +1687,80 @@ merge(Compressor.prototype, {
if (self.args.length == 0) return make_node(AST_String, self, { if (self.args.length == 0) return make_node(AST_String, self, {
value: "" value: ""
}); });
return make_node(AST_Binary, self, { if (self.args.length <= 1) return make_node(AST_Binary, self, {
left: self.args[0], left: self.args[0],
operator: "+", operator: "+",
right: make_node(AST_String, self, { value: "" }) right: make_node(AST_String, self, { value: "" })
}).transform(compressor);
break;
case "Number":
if (self.args.length == 0) return make_node(AST_Number, self, {
value: 0
}); });
if (self.args.length == 1) return make_node(AST_UnaryPrefix, self, {
expression: self.args[0],
operator: "+"
}).transform(compressor);
case "Boolean":
if (self.args.length == 0) return make_node(AST_False, self);
if (self.args.length == 1) return make_node(AST_UnaryPrefix, self, {
expression: make_node(AST_UnaryPrefix, null, {
expression: self.args[0],
operator: "!"
}),
operator: "!"
}).transform(compressor);
break;
case "Function":
if (all(self.args, function(x){ return x instanceof AST_String })) {
// quite a corner-case, but we can handle it:
// https://github.com/mishoo/UglifyJS2/issues/203
// if the code argument is a constant, then we can minify it.
try {
var code = "(function(" + self.args.slice(0, -1).map(function(arg){
return arg.value;
}).join(",") + "){" + self.args[self.args.length - 1].value + "})()";
var ast = parse(code);
ast.figure_out_scope({ screw_ie8: compressor.option("screw_ie8") });
var comp = new Compressor(compressor.options);
ast = ast.transform(comp);
ast.figure_out_scope({ screw_ie8: compressor.option("screw_ie8") });
ast.mangle_names();
var fun;
try {
ast.walk(new TreeWalker(function(node){
if (node instanceof AST_Lambda) {
fun = node;
throw ast;
}
}));
} catch(ex) {
if (ex !== ast) throw ex;
};
var args = fun.argnames.map(function(arg, i){
return make_node(AST_String, self.args[i], {
value: arg.print_to_string()
});
});
var code = OutputStream();
AST_BlockStatement.prototype._codegen.call(fun, fun, code);
code = code.toString().replace(/^\{|\}$/g, "");
args.push(make_node(AST_String, self.args[self.args.length - 1], {
value: code
}));
self.args = args;
return self;
} catch(ex) {
if (ex instanceof JS_Parse_Error) {
compressor.warn("Error parsing code passed to new Function [{file}:{line},{col}]", self.args[self.args.length - 1].start);
compressor.warn(ex.toString());
} else {
console.log(ex);
throw ex;
}
}
}
break;
} }
} }
else if (exp instanceof AST_Dot && exp.property == "toString" && self.args.length == 0) { else if (exp instanceof AST_Dot && exp.property == "toString" && self.args.length == 0) {
@@ -1598,15 +1770,70 @@ merge(Compressor.prototype, {
right: exp.expression right: exp.expression
}).transform(compressor); }).transform(compressor);
} }
else if (exp instanceof AST_Dot && exp.expression instanceof AST_Array && exp.property == "join") EXIT: {
var separator = self.args.length == 0 ? "," : self.args[0].evaluate(compressor)[1];
if (separator == null) break EXIT; // not a constant
var elements = exp.expression.elements.reduce(function(a, el){
el = el.evaluate(compressor);
if (a.length == 0 || el.length == 1) {
a.push(el);
} else {
var last = a[a.length - 1];
if (last.length == 2) {
// it's a constant
var val = "" + last[1] + separator + el[1];
a[a.length - 1] = [ make_node_from_constant(compressor, val, last[0]), val ];
} else {
a.push(el);
}
}
return a;
}, []);
if (elements.length == 0) return make_node(AST_String, self, { value: "" });
if (elements.length == 1) return elements[0][0];
if (separator == "") {
var first;
if (elements[0][0] instanceof AST_String
|| elements[1][0] instanceof AST_String) {
first = elements.shift()[0];
} else {
first = make_node(AST_String, self, { value: "" });
}
return elements.reduce(function(prev, el){
return make_node(AST_Binary, el[0], {
operator : "+",
left : prev,
right : el[0],
});
}, first).transform(compressor);
}
// need this awkward cloning to not affect original element
// best_of will decide which one to get through.
var node = self.clone();
node.expression = node.expression.clone();
node.expression.expression = node.expression.expression.clone();
node.expression.expression.elements = elements.map(function(el){
return el[0];
});
return best_of(self, node);
}
} }
if (compressor.option("side_effects")) { if (compressor.option("side_effects")) {
if (self.expression instanceof AST_Function if (self.expression instanceof AST_Function
&& self.args.length == 0 && self.args.length == 0
&& !AST_Block.prototype.has_side_effects.call(self.expression)) { && !AST_Block.prototype.has_side_effects.call(self.expression, compressor)) {
return make_node(AST_Undefined, self).transform(compressor); return make_node(AST_Undefined, self).transform(compressor);
} }
} }
return self; if (compressor.option("drop_console")) {
if (self.expression instanceof AST_PropAccess &&
self.expression.expression instanceof AST_SymbolRef &&
self.expression.expression.name == "console" &&
self.expression.expression.undeclared()) {
return make_node(AST_Undefined, self).transform(compressor);
}
}
return self.evaluate(compressor)[0];
}); });
OPT(AST_New, function(self, compressor){ OPT(AST_New, function(self, compressor){
@@ -1629,7 +1856,7 @@ merge(Compressor.prototype, {
OPT(AST_Seq, function(self, compressor){ OPT(AST_Seq, function(self, compressor){
if (!compressor.option("side_effects")) if (!compressor.option("side_effects"))
return self; return self;
if (!self.car.has_side_effects()) { if (!self.car.has_side_effects(compressor)) {
// we shouldn't compress (1,eval)(something) to // we shouldn't compress (1,eval)(something) to
// eval(something) because that changes the meaning of // eval(something) because that changes the meaning of
// eval (becomes lexical instead of global). // eval (becomes lexical instead of global).
@@ -1644,16 +1871,34 @@ merge(Compressor.prototype, {
} }
if (compressor.option("cascade")) { if (compressor.option("cascade")) {
if (self.car instanceof AST_Assign if (self.car instanceof AST_Assign
&& !self.car.left.has_side_effects() && !self.car.left.has_side_effects(compressor)) {
&& self.car.left.equivalent_to(self.cdr)) { if (self.car.left.equivalent_to(self.cdr)) {
return self.car; return self.car;
}
if (self.cdr instanceof AST_Call
&& self.cdr.expression.equivalent_to(self.car.left)) {
self.cdr.expression = self.car;
return self.cdr;
}
} }
if (!self.car.has_side_effects() if (!self.car.has_side_effects(compressor)
&& !self.cdr.has_side_effects() && !self.cdr.has_side_effects(compressor)
&& self.car.equivalent_to(self.cdr)) { && self.car.equivalent_to(self.cdr)) {
return self.car; return self.car;
} }
} }
if (self.cdr instanceof AST_UnaryPrefix
&& self.cdr.operator == "void"
&& !self.cdr.expression.has_side_effects(compressor)) {
self.cdr.operator = self.car;
return self.cdr;
}
if (self.cdr instanceof AST_Undefined) {
return make_node(AST_UnaryPrefix, self, {
operator : "void",
expression : self.car
});
}
return self; return self;
}); });
@@ -1699,6 +1944,14 @@ merge(Compressor.prototype, {
return self.evaluate(compressor)[0]; return self.evaluate(compressor)[0];
}); });
function has_side_effects_or_prop_access(node, compressor) {
var save_pure_getters = compressor.option("pure_getters");
compressor.options.pure_getters = false;
var ret = node.has_side_effects(compressor);
compressor.options.pure_getters = save_pure_getters;
return ret;
}
AST_Binary.DEFMETHOD("lift_sequences", function(compressor){ AST_Binary.DEFMETHOD("lift_sequences", function(compressor){
if (compressor.option("sequences")) { if (compressor.option("sequences")) {
if (this.left instanceof AST_Seq) { if (this.left instanceof AST_Seq) {
@@ -1710,8 +1963,8 @@ merge(Compressor.prototype, {
return seq; return seq;
} }
if (this.right instanceof AST_Seq if (this.right instanceof AST_Seq
&& !(this.operator == "||" || this.operator == "&&") && this instanceof AST_Assign
&& !this.left.has_side_effects()) { && !has_side_effects_or_prop_access(this.left, compressor)) {
var seq = this.right; var seq = this.right;
var x = seq.to_array(); var x = seq.to_array();
this.right = x.pop(); this.right = x.pop();
@@ -1726,18 +1979,52 @@ merge(Compressor.prototype, {
var commutativeOperators = makePredicate("== === != !== * & | ^"); var commutativeOperators = makePredicate("== === != !== * & | ^");
OPT(AST_Binary, function(self, compressor){ OPT(AST_Binary, function(self, compressor){
function reverse(op) { var reverse = compressor.has_directive("use asm") ? noop
if (!(self.left.has_side_effects() || self.right.has_side_effects())) { : function(op, force) {
if (op) self.operator = op; if (force || !(self.left.has_side_effects(compressor) || self.right.has_side_effects(compressor))) {
var tmp = self.left; if (op) self.operator = op;
self.left = self.right; var tmp = self.left;
self.right = tmp; self.left = self.right;
} self.right = tmp;
}; }
};
if (commutativeOperators(self.operator)) { if (commutativeOperators(self.operator)) {
if (self.right instanceof AST_Constant if (self.right instanceof AST_Constant
&& !(self.left instanceof AST_Constant)) { && !(self.left instanceof AST_Constant)) {
reverse(); // if right is a constant, whatever side effects the
// left side might have could not influence the
// result. hence, force switch.
if (!(self.left instanceof AST_Binary
&& PRECEDENCE[self.left.operator] >= PRECEDENCE[self.operator])) {
reverse(null, true);
}
}
if (/^[!=]==?$/.test(self.operator)) {
if (self.left instanceof AST_SymbolRef && self.right instanceof AST_Conditional) {
if (self.right.consequent instanceof AST_SymbolRef
&& self.right.consequent.definition() === self.left.definition()) {
if (/^==/.test(self.operator)) return self.right.condition;
if (/^!=/.test(self.operator)) return self.right.condition.negate(compressor);
}
if (self.right.alternative instanceof AST_SymbolRef
&& self.right.alternative.definition() === self.left.definition()) {
if (/^==/.test(self.operator)) return self.right.condition.negate(compressor);
if (/^!=/.test(self.operator)) return self.right.condition;
}
}
if (self.right instanceof AST_SymbolRef && self.left instanceof AST_Conditional) {
if (self.left.consequent instanceof AST_SymbolRef
&& self.left.consequent.definition() === self.right.definition()) {
if (/^==/.test(self.operator)) return self.left.condition;
if (/^!=/.test(self.operator)) return self.left.condition.negate(compressor);
}
if (self.left.alternative instanceof AST_SymbolRef
&& self.left.alternative.definition() === self.right.definition()) {
if (/^==/.test(self.operator)) return self.left.condition.negate(compressor);
if (/^!=/.test(self.operator)) return self.left.condition;
}
}
} }
} }
self = self.lift_sequences(compressor); self = self.lift_sequences(compressor);
@@ -1758,8 +2045,8 @@ merge(Compressor.prototype, {
&& compressor.option("unsafe")) { && compressor.option("unsafe")) {
if (!(self.right.expression instanceof AST_SymbolRef) if (!(self.right.expression instanceof AST_SymbolRef)
|| !self.right.expression.undeclared()) { || !self.right.expression.undeclared()) {
self.left = self.right.expression; self.right = self.right.expression;
self.right = make_node(AST_Undefined, self.left).optimize(compressor); self.left = make_node(AST_Undefined, self.left).optimize(compressor);
if (self.operator.length == 2) self.operator += "="; if (self.operator.length == 2) self.operator += "=";
} }
} }
@@ -1804,11 +2091,6 @@ merge(Compressor.prototype, {
} }
break; break;
} }
var exp = self.evaluate(compressor);
if (exp.length > 1) {
if (best_of(exp[0], self) !== self)
return exp[0];
}
if (compressor.option("comparisons")) { if (compressor.option("comparisons")) {
if (!(compressor.parent() instanceof AST_Binary) if (!(compressor.parent() instanceof AST_Binary)
|| compressor.parent() instanceof AST_Assign) { || compressor.parent() instanceof AST_Assign) {
@@ -1828,7 +2110,76 @@ merge(Compressor.prototype, {
&& self.left.operator == "+" && self.left.is_string(compressor)) { && self.left.operator == "+" && self.left.is_string(compressor)) {
return self.left; return self.left;
} }
return self; if (compressor.option("evaluate")) {
if (self.operator == "+") {
if (self.left instanceof AST_Constant
&& self.right instanceof AST_Binary
&& self.right.operator == "+"
&& self.right.left instanceof AST_Constant
&& self.right.is_string(compressor)) {
self = make_node(AST_Binary, self, {
operator: "+",
left: make_node(AST_String, null, {
value: "" + self.left.getValue() + self.right.left.getValue(),
start: self.left.start,
end: self.right.left.end
}),
right: self.right.right
});
}
if (self.right instanceof AST_Constant
&& self.left instanceof AST_Binary
&& self.left.operator == "+"
&& self.left.right instanceof AST_Constant
&& self.left.is_string(compressor)) {
self = make_node(AST_Binary, self, {
operator: "+",
left: self.left.left,
right: make_node(AST_String, null, {
value: "" + self.left.right.getValue() + self.right.getValue(),
start: self.left.right.start,
end: self.right.end
})
});
}
if (self.left instanceof AST_Binary
&& self.left.operator == "+"
&& self.left.is_string(compressor)
&& self.left.right instanceof AST_Constant
&& self.right instanceof AST_Binary
&& self.right.operator == "+"
&& self.right.left instanceof AST_Constant
&& self.right.is_string(compressor)) {
self = make_node(AST_Binary, self, {
operator: "+",
left: make_node(AST_Binary, self.left, {
operator: "+",
left: self.left.left,
right: make_node(AST_String, null, {
value: "" + self.left.right.getValue() + self.right.left.getValue(),
start: self.left.right.start,
end: self.right.left.end
})
}),
right: self.right.right
});
}
}
}
// x * (y * z) ==> x * y * z
if (self.right instanceof AST_Binary
&& self.right.operator == self.operator
&& (self.operator == "*" || self.operator == "&&" || self.operator == "||"))
{
self.left = make_node(AST_Binary, self.left, {
operator : self.operator,
left : self.left,
right : self.right.left
});
self.right = self.right.right;
return self.transform(compressor);
}
return self.evaluate(compressor)[0];
}); });
OPT(AST_SymbolRef, function(self, compressor){ OPT(AST_SymbolRef, function(self, compressor){
@@ -1919,7 +2270,7 @@ merge(Compressor.prototype, {
* ==> * ==>
* exp = foo ? something : something_else; * exp = foo ? something : something_else;
*/ */
self = make_node(AST_Assign, self, { return make_node(AST_Assign, self, {
operator: consequent.operator, operator: consequent.operator,
left: consequent.left, left: consequent.left,
right: make_node(AST_Conditional, self, { right: make_node(AST_Conditional, self, {
@@ -1929,6 +2280,38 @@ merge(Compressor.prototype, {
}) })
}); });
} }
if (consequent instanceof AST_Call
&& alternative.TYPE === consequent.TYPE
&& consequent.args.length == alternative.args.length
&& consequent.expression.equivalent_to(alternative.expression)) {
if (consequent.args.length == 0) {
return make_node(AST_Seq, self, {
car: self.condition,
cdr: consequent
});
}
if (consequent.args.length == 1) {
consequent.args[0] = make_node(AST_Conditional, self, {
condition: self.condition,
consequent: consequent.args[0],
alternative: alternative.args[0]
});
return consequent;
}
}
// x?y?z:a:a --> x&&y?z:a
if (consequent instanceof AST_Conditional
&& consequent.alternative.equivalent_to(alternative)) {
return make_node(AST_Conditional, self, {
condition: make_node(AST_Binary, self, {
left: self.condition,
operator: "&&",
right: consequent.condition
}),
consequent: consequent.consequent,
alternative: alternative
});
}
return self; return self;
}); });
@@ -1962,12 +2345,18 @@ merge(Compressor.prototype, {
var prop = self.property; var prop = self.property;
if (prop instanceof AST_String && compressor.option("properties")) { if (prop instanceof AST_String && compressor.option("properties")) {
prop = prop.getValue(); prop = prop.getValue();
if (is_identifier(prop) || compressor.option("screw_ie8")) { if (RESERVED_WORDS(prop) ? compressor.option("screw_ie8") : is_identifier_string(prop)) {
return make_node(AST_Dot, self, { return make_node(AST_Dot, self, {
expression : self.expression, expression : self.expression,
property : prop property : prop
}); });
} }
var v = parseFloat(prop);
if (!isNaN(v) && v.toString() == prop) {
self.property = make_node(AST_Number, self.property, {
value: v
});
}
} }
return self; return self;
}); });

View File

@@ -46,21 +46,23 @@
function OutputStream(options) { function OutputStream(options) {
options = defaults(options, { options = defaults(options, {
indent_start : 0, indent_start : 0,
indent_level : 4, indent_level : 4,
quote_keys : false, quote_keys : false,
space_colon : true, space_colon : true,
ascii_only : false, ascii_only : false,
inline_script : false, unescape_regexps : false,
width : 80, inline_script : false,
max_line_len : 32000, width : 80,
ie_proof : true, max_line_len : 32000,
beautify : false, beautify : false,
source_map : null, source_map : null,
bracketize : false, bracketize : false,
semicolons : true, semicolons : true,
comments : false, comments : false,
preserve_line : false preserve_line : false,
screw_ie8 : false,
preamble : null,
}, true); }, true);
var indentation = 0; var indentation = 0;
@@ -95,7 +97,7 @@ function OutputStream(options) {
case "\u2029": return "\\u2029"; case "\u2029": return "\\u2029";
case '"': ++dq; return '"'; case '"': ++dq; return '"';
case "'": ++sq; return "'"; case "'": ++sq; return "'";
case "\0": return "\\0"; case "\0": return "\\x00";
} }
return s; return s;
}); });
@@ -299,6 +301,10 @@ function OutputStream(options) {
return OUTPUT; return OUTPUT;
}; };
if (options.preamble) {
print(options.preamble.replace(/\r\n?|[\n\u2028\u2029]|\s*$/g, "\n"));
}
var stack = []; var stack = [];
return { return {
get : get, get : get,
@@ -350,18 +356,17 @@ function OutputStream(options) {
AST_Node.DEFMETHOD("print", function(stream, force_parens){ AST_Node.DEFMETHOD("print", function(stream, force_parens){
var self = this, generator = self._codegen; var self = this, generator = self._codegen;
stream.push_node(self); function doit() {
if (force_parens || self.needs_parens(stream)) {
stream.with_parens(function(){
self.add_comments(stream);
self.add_source_map(stream);
generator(self, stream);
});
} else {
self.add_comments(stream); self.add_comments(stream);
self.add_source_map(stream); self.add_source_map(stream);
generator(self, stream); generator(self, stream);
} }
stream.push_node(self);
if (force_parens || self.needs_parens(stream)) {
stream.with_parens(doit);
} else {
doit();
}
stream.pop_node(); stream.pop_node();
}); });
@@ -379,15 +384,23 @@ function OutputStream(options) {
var start = self.start; var start = self.start;
if (start && !start._comments_dumped) { if (start && !start._comments_dumped) {
start._comments_dumped = true; start._comments_dumped = true;
var comments = start.comments_before; var comments = start.comments_before || [];
// XXX: ugly fix for https://github.com/mishoo/UglifyJS2/issues/112 // XXX: ugly fix for https://github.com/mishoo/UglifyJS2/issues/112
// if this node is `return` or `throw`, we cannot allow comments before // and https://github.com/mishoo/UglifyJS2/issues/372
// the returned or thrown value. if (self instanceof AST_Exit && self.value) {
if (self instanceof AST_Exit && self.value.walk(new TreeWalker(function(node){
self.value && self.value.start.comments_before.length > 0) { if (node.start && node.start.comments_before) {
comments = (comments || []).concat(self.value.start.comments_before); comments = comments.concat(node.start.comments_before);
self.value.start.comments_before = []; node.start.comments_before = [];
}
if (node instanceof AST_Function ||
node instanceof AST_Array ||
node instanceof AST_Object)
{
return true; // don't go inside.
}
}));
} }
if (c.test) { if (c.test) {
@@ -400,7 +413,7 @@ function OutputStream(options) {
}); });
} }
comments.forEach(function(c){ comments.forEach(function(c){
if (c.type == "comment1") { if (/comment[134]/.test(c.type)) {
output.print("//" + c.value + "\n"); output.print("//" + c.value + "\n");
output.indent(); output.indent();
} }
@@ -451,7 +464,7 @@ function OutputStream(options) {
|| p instanceof AST_Unary // !(foo, bar, baz) || p instanceof AST_Unary // !(foo, bar, baz)
|| p instanceof AST_Binary // 1 + (2, 3) + 4 ==> 8 || p instanceof AST_Binary // 1 + (2, 3) + 4 ==> 8
|| p instanceof AST_VarDef // var a = (1, 2), b = a + a; ==> b == 4 || p instanceof AST_VarDef // var a = (1, 2), b = a + a; ==> b == 4
|| p instanceof AST_Dot // (1, {foo:2}).foo ==> 2 || p instanceof AST_PropAccess // (1, {foo:2}).foo or (1, {foo:2})["foo"] ==> 2
|| p instanceof AST_Array // [ 1, (2, 3), 4 ] ==> [ 1, 3, 4 ] || p instanceof AST_Array // [ 1, (2, 3), 4 ] ==> [ 1, 3, 4 ]
|| p instanceof AST_ObjectProperty // { foo: (1, 2) }.foo ==> 2 || p instanceof AST_ObjectProperty // { foo: (1, 2) }.foo ==> 2
|| p instanceof AST_Conditional /* (false, true) ? (a = 10, b = 20) : (c = 30) || p instanceof AST_Conditional /* (false, true) ? (a = 10, b = 20) : (c = 30)
@@ -476,11 +489,7 @@ function OutputStream(options) {
var so = this.operator, sp = PRECEDENCE[so]; var so = this.operator, sp = PRECEDENCE[so];
if (pp > sp if (pp > sp
|| (pp == sp || (pp == sp
&& this === p.right && this === p.right)) {
&& !(so == po &&
(so == "*" ||
so == "&&" ||
so == "||")))) {
return true; return true;
} }
} }
@@ -507,8 +516,17 @@ function OutputStream(options) {
}); });
PARENS(AST_Call, function(output){ PARENS(AST_Call, function(output){
var p = output.parent(); var p = output.parent(), p1;
return p instanceof AST_New && p.expression === this; if (p instanceof AST_New && p.expression === this)
return true;
// workaround for Safari bug.
// https://bugs.webkit.org/show_bug.cgi?id=123506
return this.expression instanceof AST_Function
&& p instanceof AST_PropAccess
&& p.expression === this
&& (p1 = output.parent(1)) instanceof AST_Assign
&& p1.left === p;
}); });
PARENS(AST_New, function(output){ PARENS(AST_New, function(output){
@@ -757,7 +775,7 @@ function OutputStream(options) {
if (!self.body) if (!self.body)
return output.force_semicolon(); return output.force_semicolon();
if (self.body instanceof AST_Do if (self.body instanceof AST_Do
&& output.option("ie_proof")) { && !output.option("screw_ie8")) {
// https://github.com/mishoo/UglifyJS/issues/#issue/57 IE // https://github.com/mishoo/UglifyJS/issues/#issue/57 IE
// croaks with "syntax error" on code like this: if (foo) // croaks with "syntax error" on code like this: if (foo)
// do ... while(cond); else ... we need block brackets // do ... while(cond); else ... we need block brackets
@@ -990,7 +1008,18 @@ function OutputStream(options) {
self.left.print(output); self.left.print(output);
output.space(); output.space();
output.print(self.operator); output.print(self.operator);
output.space(); if (self.operator == "<"
&& self.right instanceof AST_UnaryPrefix
&& self.right.operator == "!"
&& self.right.expression instanceof AST_UnaryPrefix
&& self.right.expression.operator == "--") {
// space is mandatory to avoid outputting <!--
// http://javascript.spec.whatwg.org/#comment-syntax
output.print(" ");
} else {
// the space is optional depending on "beautify"
output.space();
}
self.right.print(output); self.right.print(output);
}); });
DEFPRINT(AST_Conditional, function(self, output){ DEFPRINT(AST_Conditional, function(self, output){
@@ -1012,6 +1041,11 @@ function OutputStream(options) {
a.forEach(function(exp, i){ a.forEach(function(exp, i){
if (i) output.comma(); if (i) output.comma();
exp.print(output); exp.print(output);
// If the final element is a hole, we need to make sure it
// doesn't look like a trailing comma, by inserting an actual
// trailing comma.
if (i === len - 1 && exp instanceof AST_Hole)
output.comma();
}); });
if (len > 0) output.space(); if (len > 0) output.space();
}); });
@@ -1039,20 +1073,24 @@ function OutputStream(options) {
&& +key + "" == key) && +key + "" == key)
&& parseFloat(key) >= 0) { && parseFloat(key) >= 0) {
output.print(make_num(key)); output.print(make_num(key));
} else if (!is_identifier(key)) { } else if (RESERVED_WORDS(key) ? output.option("screw_ie8") : is_identifier_string(key)) {
output.print_string(key);
} else {
output.print_name(key); output.print_name(key);
} else {
output.print_string(key);
} }
output.colon(); output.colon();
self.value.print(output); self.value.print(output);
}); });
DEFPRINT(AST_ObjectSetter, function(self, output){ DEFPRINT(AST_ObjectSetter, function(self, output){
output.print("set"); output.print("set");
output.space();
self.key.print(output);
self.value._do_print(output, true); self.value._do_print(output, true);
}); });
DEFPRINT(AST_ObjectGetter, function(self, output){ DEFPRINT(AST_ObjectGetter, function(self, output){
output.print("get"); output.print("get");
output.space();
self.key.print(output);
self.value._do_print(output, true); self.value._do_print(output, true);
}); });
DEFPRINT(AST_Symbol, function(self, output){ DEFPRINT(AST_Symbol, function(self, output){
@@ -1081,10 +1119,47 @@ function OutputStream(options) {
DEFPRINT(AST_Number, function(self, output){ DEFPRINT(AST_Number, function(self, output){
output.print(make_num(self.getValue())); output.print(make_num(self.getValue()));
}); });
function regexp_safe_literal(code) {
return [
0x5c , // \
0x2f , // /
0x2e , // .
0x2b , // +
0x2a , // *
0x3f , // ?
0x28 , // (
0x29 , // )
0x5b , // [
0x5d , // ]
0x7b , // {
0x7d , // }
0x24 , // $
0x5e , // ^
0x3a , // :
0x7c , // |
0x21 , // !
0x0a , // \n
0x0d , // \r
0x00 , // \0
0xfeff , // Unicode BOM
0x2028 , // unicode "line separator"
0x2029 , // unicode "paragraph separator"
].indexOf(code) < 0;
};
DEFPRINT(AST_RegExp, function(self, output){ DEFPRINT(AST_RegExp, function(self, output){
var str = self.getValue().toString(); var str = self.getValue().toString();
if (output.option("ascii_only")) if (output.option("ascii_only")) {
str = output.to_ascii(str); str = output.to_ascii(str);
} else if (output.option("unescape_regexps")) {
str = str.split("\\\\").map(function(str){
return str.replace(/\\u[0-9a-fA-F]{4}|\\x[0-9a-fA-F]{2}/g, function(s){
var code = parseInt(s.substr(2), 16);
return regexp_safe_literal(code) ? String.fromCharCode(code) : s;
});
}).join("\\\\");
}
output.print(str); output.print(str);
var p = output.parent(); var p = output.parent();
if (p instanceof AST_Binary && /^in/.test(p.operator) && p.left === self) if (p instanceof AST_Binary && /^in/.test(p.operator) && p.left === self)
@@ -1119,7 +1194,7 @@ function OutputStream(options) {
if (p instanceof AST_Statement && p.body === node) if (p instanceof AST_Statement && p.body === node)
return true; return true;
if ((p instanceof AST_Seq && p.car === node ) || if ((p instanceof AST_Seq && p.car === node ) ||
(p instanceof AST_Call && p.expression === node ) || (p instanceof AST_Call && p.expression === node && !(p instanceof AST_New) ) ||
(p instanceof AST_Dot && p.expression === node ) || (p instanceof AST_Dot && p.expression === node ) ||
(p instanceof AST_Sub && p.expression === node ) || (p instanceof AST_Sub && p.expression === node ) ||
(p instanceof AST_Conditional && p.condition === node ) || (p instanceof AST_Conditional && p.condition === node ) ||

View File

@@ -46,7 +46,7 @@
var KEYWORDS = 'break case catch const continue debugger default delete do else finally for function if in instanceof new return switch throw try typeof var void while with'; var KEYWORDS = 'break case catch const continue debugger default delete do else finally for function if in instanceof new return switch throw try typeof var void while with';
var KEYWORDS_ATOM = 'false null true'; var KEYWORDS_ATOM = 'false null true';
var RESERVED_WORDS = 'abstract boolean byte char class double enum export extends final float goto implements import int interface long native package private protected public short static super synchronized this throws transient volatile' var RESERVED_WORDS = 'abstract boolean byte char class double enum export extends final float goto implements import int interface long native package private protected public short static super synchronized this throws transient volatile yield'
+ " " + KEYWORDS_ATOM + " " + KEYWORDS; + " " + KEYWORDS_ATOM + " " + KEYWORDS;
var KEYWORDS_BEFORE_EXPRESSION = 'return new delete throw else case'; var KEYWORDS_BEFORE_EXPRESSION = 'return new delete throw else case';
@@ -167,6 +167,17 @@ function is_identifier_char(ch) {
; ;
}; };
function is_identifier_string(str){
var i = str.length;
if (i == 0) return false;
if (!is_identifier_start(str.charCodeAt(0))) return false;
while (--i >= 0) {
if (!is_identifier_char(str.charAt(i)))
return false;
}
return true;
};
function parse_js_number(num) { function parse_js_number(num) {
if (RE_HEX_NUMBER.test(num)) { if (RE_HEX_NUMBER.test(num)) {
return parseInt(num.substr(2), 16); return parseInt(num.substr(2), 16);
@@ -199,7 +210,7 @@ function is_token(token, type, val) {
var EX_EOF = {}; var EX_EOF = {};
function tokenizer($TEXT, filename) { function tokenizer($TEXT, filename, html5_comments) {
var S = { var S = {
text : $TEXT.replace(/\r\n?|[\n\u2028\u2029]/g, "\n").replace(/\uFEFF/g, ''), text : $TEXT.replace(/\r\n?|[\n\u2028\u2029]/g, "\n").replace(/\uFEFF/g, ''),
@@ -231,6 +242,14 @@ function tokenizer($TEXT, filename) {
return ch; return ch;
}; };
function forward(i) {
while (i-- > 0) next();
};
function looking_at(str) {
return S.text.substr(S.pos, str.length) == str;
};
function find(what, signal_eof) { function find(what, signal_eof) {
var pos = S.text.indexOf(what, S.pos); var pos = S.text.indexOf(what, S.pos);
if (signal_eof && pos == -1) throw EX_EOF; if (signal_eof && pos == -1) throw EX_EOF;
@@ -243,10 +262,12 @@ function tokenizer($TEXT, filename) {
S.tokpos = S.pos; S.tokpos = S.pos;
}; };
var prev_was_dot = false;
function token(type, value, is_comment) { function token(type, value, is_comment) {
S.regex_allowed = ((type == "operator" && !UNARY_POSTFIX[value]) || S.regex_allowed = ((type == "operator" && !UNARY_POSTFIX(value)) ||
(type == "keyword" && KEYWORDS_BEFORE_EXPRESSION(value)) || (type == "keyword" && KEYWORDS_BEFORE_EXPRESSION(value)) ||
(type == "punc" && PUNC_BEFORE_EXPRESSION(value))); (type == "punc" && PUNC_BEFORE_EXPRESSION(value)));
prev_was_dot = (type == "punc" && value == ".");
var ret = { var ret = {
type : type, type : type,
value : value, value : value,
@@ -368,8 +389,8 @@ function tokenizer($TEXT, filename) {
return token("string", ret); return token("string", ret);
}); });
function read_line_comment() { function skip_line_comment(type) {
next(); var regex_allowed = S.regex_allowed;
var i = find("\n"), ret; var i = find("\n"), ret;
if (i == -1) { if (i == -1) {
ret = S.text.substr(S.pos); ret = S.text.substr(S.pos);
@@ -378,11 +399,13 @@ function tokenizer($TEXT, filename) {
ret = S.text.substring(S.pos, i); ret = S.text.substring(S.pos, i);
S.pos = i; S.pos = i;
} }
return token("comment1", ret, true); S.comments_before.push(token(type, ret, true));
S.regex_allowed = regex_allowed;
return next_token();
}; };
var read_multiline_comment = with_eof_error("Unterminated multiline comment", function(){ var skip_multiline_comment = with_eof_error("Unterminated multiline comment", function(){
next(); var regex_allowed = S.regex_allowed;
var i = find("*/", true); var i = find("*/", true);
var text = S.text.substring(S.pos, i); var text = S.text.substring(S.pos, i);
var a = text.split("\n"), n = a.length; var a = text.split("\n"), n = a.length;
@@ -392,8 +415,11 @@ function tokenizer($TEXT, filename) {
if (n > 1) S.col = a[n - 1].length; if (n > 1) S.col = a[n - 1].length;
else S.col += a[n - 1].length; else S.col += a[n - 1].length;
S.col += 2; S.col += 2;
S.newline_before = S.newline_before || text.indexOf("\n") >= 0; var nlb = S.newline_before = S.newline_before || text.indexOf("\n") >= 0;
return token("comment2", text, true); S.comments_before.push(token("comment2", text, true));
S.regex_allowed = regex_allowed;
S.newline_before = nlb;
return next_token();
}); });
function read_name() { function read_name() {
@@ -457,16 +483,13 @@ function tokenizer($TEXT, filename) {
function handle_slash() { function handle_slash() {
next(); next();
var regex_allowed = S.regex_allowed;
switch (peek()) { switch (peek()) {
case "/": case "/":
S.comments_before.push(read_line_comment()); next();
S.regex_allowed = regex_allowed; return skip_line_comment("comment1");
return next_token();
case "*": case "*":
S.comments_before.push(read_multiline_comment()); next();
S.regex_allowed = regex_allowed; return skip_multiline_comment();
return next_token();
} }
return S.regex_allowed ? read_regexp("") : read_operator("/"); return S.regex_allowed ? read_regexp("") : read_operator("/");
}; };
@@ -480,6 +503,7 @@ function tokenizer($TEXT, filename) {
function read_word() { function read_word() {
var word = read_name(); var word = read_name();
if (prev_was_dot) return token("name", word);
return KEYWORDS_ATOM(word) ? token("atom", word) return KEYWORDS_ATOM(word) ? token("atom", word)
: !KEYWORDS(word) ? token("name", word) : !KEYWORDS(word) ? token("name", word)
: OPERATORS(word) ? token("operator", word) : OPERATORS(word) ? token("operator", word)
@@ -502,6 +526,16 @@ function tokenizer($TEXT, filename) {
return read_regexp(force_regexp); return read_regexp(force_regexp);
skip_whitespace(); skip_whitespace();
start_token(); start_token();
if (html5_comments) {
if (looking_at("<!--")) {
forward(4);
return skip_line_comment("comment3");
}
if (looking_at("-->") && S.newline_before) {
forward(3);
return skip_line_comment("comment4");
}
}
var ch = peek(); var ch = peek();
if (!ch) return token("eof"); if (!ch) return token("eof");
var code = ch.charCodeAt(0); var code = ch.charCodeAt(0);
@@ -545,10 +579,10 @@ var UNARY_POSTFIX = makePredicate([ "--", "++" ]);
var ASSIGNMENT = makePredicate([ "=", "+=", "-=", "/=", "*=", "%=", ">>=", "<<=", ">>>=", "|=", "^=", "&=" ]); var ASSIGNMENT = makePredicate([ "=", "+=", "-=", "/=", "*=", "%=", ">>=", "<<=", ">>>=", "|=", "^=", "&=" ]);
var PRECEDENCE = (function(a, ret){ var PRECEDENCE = (function(a, ret){
for (var i = 0, n = 1; i < a.length; ++i, ++n) { for (var i = 0; i < a.length; ++i) {
var b = a[i]; var b = a[i];
for (var j = 0; j < b.length; ++j) { for (var j = 0; j < b.length; ++j) {
ret[b[j]] = n; ret[b[j]] = i + 1;
} }
} }
return ret; return ret;
@@ -577,13 +611,18 @@ var ATOMIC_START_TOKEN = array_to_hash([ "atom", "num", "string", "regexp", "nam
function parse($TEXT, options) { function parse($TEXT, options) {
options = defaults(options, { options = defaults(options, {
strict : false, strict : false,
filename : null, filename : null,
toplevel : null toplevel : null,
expression : false,
html5_comments : true,
}); });
var S = { var S = {
input : typeof $TEXT == "string" ? tokenizer($TEXT, options.filename) : $TEXT, input : (typeof $TEXT == "string"
? tokenizer($TEXT, options.filename,
options.html5_comments)
: $TEXT),
token : null, token : null,
prev : null, prev : null,
peeked : null, peeked : null,
@@ -676,12 +715,16 @@ function parse($TEXT, options) {
}; };
}; };
var statement = embed_tokens(function() { function handle_regexp() {
var tmp;
if (is("operator", "/") || is("operator", "/=")) { if (is("operator", "/") || is("operator", "/=")) {
S.peeked = null; S.peeked = null;
S.token = S.input(S.token.value.substr(1)); // force regexp S.token = S.input(S.token.value.substr(1)); // force regexp
} }
};
var statement = embed_tokens(function() {
var tmp;
handle_regexp();
switch (S.token.type) { switch (S.token.type) {
case "string": case "string":
var dir = S.in_directives, stat = simple_statement(); var dir = S.in_directives, stat = simple_statement();
@@ -746,7 +789,7 @@ function parse($TEXT, options) {
return for_(); return for_();
case "function": case "function":
return function_(true); return function_(AST_Defun);
case "if": case "if":
return if_(); return if_();
@@ -809,6 +852,18 @@ function parse($TEXT, options) {
S.labels.push(label); S.labels.push(label);
var stat = statement(); var stat = statement();
S.labels.pop(); S.labels.pop();
if (!(stat instanceof AST_IterationStatement)) {
// check for `continue` that refers to this label.
// those should be reported as syntax errors.
// https://github.com/mishoo/UglifyJS2/issues/287
label.references.forEach(function(ref){
if (ref instanceof AST_Continue) {
ref = ref.label.start;
croak("Continue label `" + label.name + "` refers to non-IterationStatement.",
ref.line, ref.col, ref.pos);
}
});
}
return new AST_LabeledStatement({ body: stat, label: label }); return new AST_LabeledStatement({ body: stat, label: label });
}; };
@@ -817,18 +872,22 @@ function parse($TEXT, options) {
}; };
function break_cont(type) { function break_cont(type) {
var label = null; var label = null, ldef;
if (!can_insert_semicolon()) { if (!can_insert_semicolon()) {
label = as_symbol(AST_LabelRef, true); label = as_symbol(AST_LabelRef, true);
} }
if (label != null) { if (label != null) {
if (!find_if(function(l){ return l.name == label.name }, S.labels)) ldef = find_if(function(l){ return l.name == label.name }, S.labels);
if (!ldef)
croak("Undefined label " + label.name); croak("Undefined label " + label.name);
label.thedef = ldef;
} }
else if (S.in_loop == 0) else if (S.in_loop == 0)
croak(type.TYPE + " not inside a loop or switch"); croak(type.TYPE + " not inside a loop or switch");
semicolon(); semicolon();
return new type({ label: label }); var stat = new type({ label: label });
if (ldef) ldef.references.push(stat);
return stat;
}; };
function for_() { function for_() {
@@ -874,19 +933,12 @@ function parse($TEXT, options) {
}); });
}; };
var function_ = function(in_statement, ctor) { var function_ = function(ctor) {
var is_accessor = ctor === AST_Accessor; var in_statement = ctor === AST_Defun;
var name = (is("name") ? as_symbol(in_statement var name = is("name") ? as_symbol(in_statement ? AST_SymbolDefun : AST_SymbolLambda) : null;
? AST_SymbolDefun
: is_accessor
? AST_SymbolAccessor
: AST_SymbolLambda)
: is_accessor && (is("string") || is("num")) ? as_atom_node()
: null);
if (in_statement && !name) if (in_statement && !name)
unexpected(); unexpected();
expect("("); expect("(");
if (!ctor) ctor = in_statement ? AST_Defun : AST_Function;
return new ctor({ return new ctor({
name: name, name: name,
argnames: (function(first, a){ argnames: (function(first, a){
@@ -1057,7 +1109,9 @@ function parse($TEXT, options) {
var tok = S.token, ret; var tok = S.token, ret;
switch (tok.type) { switch (tok.type) {
case "name": case "name":
return as_symbol(AST_SymbolRef); case "keyword":
ret = _make_symbol(AST_SymbolRef);
break;
case "num": case "num":
ret = new AST_Number({ start: tok, end: tok, value: tok.value }); ret = new AST_Number({ start: tok, end: tok, value: tok.value });
break; break;
@@ -1108,7 +1162,7 @@ function parse($TEXT, options) {
} }
if (is("keyword", "function")) { if (is("keyword", "function")) {
next(); next();
var func = function_(false); var func = function_(AST_Function);
func.start = start; func.start = start;
func.end = prev(); func.end = prev();
return subscripts(func, allow_calls); return subscripts(func, allow_calls);
@@ -1156,8 +1210,8 @@ function parse($TEXT, options) {
if (name == "get") { if (name == "get") {
a.push(new AST_ObjectGetter({ a.push(new AST_ObjectGetter({
start : start, start : start,
key : name, key : as_atom_node(),
value : function_(false, AST_Accessor), value : function_(AST_Accessor),
end : prev() end : prev()
})); }));
continue; continue;
@@ -1165,8 +1219,8 @@ function parse($TEXT, options) {
if (name == "set") { if (name == "set") {
a.push(new AST_ObjectSetter({ a.push(new AST_ObjectSetter({
start : start, start : start,
key : name, key : as_atom_node(),
value : function_(false, AST_Accessor), value : function_(AST_Accessor),
end : prev() end : prev()
})); }));
continue; continue;
@@ -1214,17 +1268,21 @@ function parse($TEXT, options) {
} }
}; };
function _make_symbol(type) {
var name = S.token.value;
return new (name == "this" ? AST_This : type)({
name : String(name),
start : S.token,
end : S.token
});
};
function as_symbol(type, noerror) { function as_symbol(type, noerror) {
if (!is("name")) { if (!is("name")) {
if (!noerror) croak("Name expected"); if (!noerror) croak("Name expected");
return null; return null;
} }
var name = S.token.value; var sym = _make_symbol(type);
var sym = new (name == "this" ? AST_This : type)({
name : String(S.token.value),
start : S.token,
end : S.token
});
next(); next();
return sym; return sym;
}; };
@@ -1267,6 +1325,7 @@ function parse($TEXT, options) {
var start = S.token; var start = S.token;
if (is("operator") && UNARY_PREFIX(start.value)) { if (is("operator") && UNARY_PREFIX(start.value)) {
next(); next();
handle_regexp();
var ex = make_unary(AST_UnaryPrefix, start.value, maybe_unary(allow_calls)); var ex = make_unary(AST_UnaryPrefix, start.value, maybe_unary(allow_calls));
ex.start = start; ex.start = start;
ex.end = prev(); ex.end = prev();
@@ -1322,7 +1381,7 @@ function parse($TEXT, options) {
condition : expr, condition : expr,
consequent : yes, consequent : yes,
alternative : expression(false, no_in), alternative : expression(false, no_in),
end : peek() end : prev()
}); });
} }
return expr; return expr;
@@ -1330,15 +1389,8 @@ function parse($TEXT, options) {
function is_assignable(expr) { function is_assignable(expr) {
if (!options.strict) return true; if (!options.strict) return true;
switch (expr[0]+"") { if (expr instanceof AST_This) return false;
case "dot": return (expr instanceof AST_PropAccess || expr instanceof AST_Symbol);
case "sub":
case "new":
case "call":
return true;
case "name":
return expr[1] != "this";
}
}; };
var maybe_assign = function(no_in) { var maybe_assign = function(no_in) {
@@ -1382,6 +1434,10 @@ function parse($TEXT, options) {
return ret; return ret;
}; };
if (options.expression) {
return expression(true);
}
return (function(){ return (function(){
var start = S.token; var start = S.token;
var body = []; var body = [];

View File

@@ -64,38 +64,41 @@ SymbolDef.prototype = {
mangle: function(options) { mangle: function(options) {
if (!this.mangled_name && !this.unmangleable(options)) { if (!this.mangled_name && !this.unmangleable(options)) {
var s = this.scope; var s = this.scope;
if (this.orig[0] instanceof AST_SymbolLambda && !options.screw_ie8) if (!options.screw_ie8 && this.orig[0] instanceof AST_SymbolLambda)
s = s.parent_scope; s = s.parent_scope;
this.mangled_name = s.next_mangled(options); this.mangled_name = s.next_mangled(options, this);
} }
} }
}; };
AST_Toplevel.DEFMETHOD("figure_out_scope", function(){ AST_Toplevel.DEFMETHOD("figure_out_scope", function(options){
// This does what ast_add_scope did in UglifyJS v1. options = defaults(options, {
// screw_ie8: false
// Part of it could be done at parse time, but it would complicate });
// the parser (and it's already kinda complex). It's also worth
// having it separated because we might need to call it multiple
// times on the same tree.
// pass 1: setup scope chaining and handle definitions // pass 1: setup scope chaining and handle definitions
var self = this; var self = this;
var scope = self.parent_scope = null; var scope = self.parent_scope = null;
var labels = new Dictionary(); var defun = null;
var nesting = 0; var nesting = 0;
var tw = new TreeWalker(function(node, descend){ var tw = new TreeWalker(function(node, descend){
if (options.screw_ie8 && node instanceof AST_Catch) {
var save_scope = scope;
scope = new AST_Scope(node);
scope.init_scope_vars(nesting);
scope.parent_scope = save_scope;
descend();
scope = save_scope;
return true;
}
if (node instanceof AST_Scope) { if (node instanceof AST_Scope) {
node.init_scope_vars(nesting); node.init_scope_vars(nesting);
var save_scope = node.parent_scope = scope; var save_scope = node.parent_scope = scope;
var save_labels = labels; var save_defun = defun;
++nesting; defun = scope = node;
scope = node; ++nesting; descend(); --nesting;
labels = new Dictionary();
descend();
labels = save_labels;
scope = save_scope; scope = save_scope;
--nesting; defun = save_defun;
return true; // don't descend again in TreeWalker return true; // don't descend again in TreeWalker
} }
if (node instanceof AST_Directive) { if (node instanceof AST_Directive) {
@@ -108,24 +111,11 @@ AST_Toplevel.DEFMETHOD("figure_out_scope", function(){
s.uses_with = true; s.uses_with = true;
return; return;
} }
if (node instanceof AST_LabeledStatement) {
var l = node.label;
if (labels.has(l.name))
throw new Error(string_template("Label {name} defined twice", l));
labels.set(l.name, l);
descend();
labels.del(l.name);
return true; // no descend again
}
if (node instanceof AST_Symbol) { if (node instanceof AST_Symbol) {
node.scope = scope; node.scope = scope;
} }
if (node instanceof AST_Label) {
node.thedef = node;
node.init_scope_vars();
}
if (node instanceof AST_SymbolLambda) { if (node instanceof AST_SymbolLambda) {
scope.def_function(node); defun.def_function(node);
} }
else if (node instanceof AST_SymbolDefun) { else if (node instanceof AST_SymbolDefun) {
// Careful here, the scope where this should be defined is // Careful here, the scope where this should be defined is
@@ -133,31 +123,17 @@ AST_Toplevel.DEFMETHOD("figure_out_scope", function(){
// scope when we encounter the AST_Defun node (which is // scope when we encounter the AST_Defun node (which is
// instanceof AST_Scope) but we get to the symbol a bit // instanceof AST_Scope) but we get to the symbol a bit
// later. // later.
(node.scope = scope.parent_scope).def_function(node); (node.scope = defun.parent_scope).def_function(node);
} }
else if (node instanceof AST_SymbolVar else if (node instanceof AST_SymbolVar
|| node instanceof AST_SymbolConst) { || node instanceof AST_SymbolConst) {
var def = scope.def_variable(node); var def = defun.def_variable(node);
def.constant = node instanceof AST_SymbolConst; def.constant = node instanceof AST_SymbolConst;
def.init = tw.parent().value; def.init = tw.parent().value;
} }
else if (node instanceof AST_SymbolCatch) { else if (node instanceof AST_SymbolCatch) {
// XXX: this is wrong according to ECMA-262 (12.4). the (options.screw_ie8 ? scope : defun)
// `catch` argument name should be visible only inside the .def_variable(node);
// catch block. For a quick fix AST_Catch should inherit
// from AST_Scope. Keeping it this way because of IE,
// which doesn't obey the standard. (it introduces the
// identifier in the enclosing scope)
scope.def_variable(node);
}
if (node instanceof AST_LabelRef) {
var sym = labels.get(node.name);
if (!sym) throw new Error(string_template("Undefined label {name} [{line},{col}]", {
name: node.name,
line: node.start.line,
col: node.start.col
}));
node.thedef = sym;
} }
}); });
self.walk(tw); self.walk(tw);
@@ -173,10 +149,6 @@ AST_Toplevel.DEFMETHOD("figure_out_scope", function(){
func = prev_func; func = prev_func;
return true; return true;
} }
if (node instanceof AST_LabelRef) {
node.reference();
return true;
}
if (node instanceof AST_SymbolRef) { if (node instanceof AST_SymbolRef) {
var name = node.name; var name = node.name;
var sym = node.scope.find_variable(name); var sym = node.scope.find_variable(name);
@@ -187,6 +159,7 @@ AST_Toplevel.DEFMETHOD("figure_out_scope", function(){
} else { } else {
g = new SymbolDef(self, globals.size(), node); g = new SymbolDef(self, globals.size(), node);
g.undeclared = true; g.undeclared = true;
g.global = true;
globals.set(name, g); globals.set(name, g);
} }
node.thedef = g; node.thedef = g;
@@ -194,7 +167,7 @@ AST_Toplevel.DEFMETHOD("figure_out_scope", function(){
for (var s = node.scope; s && !s.uses_eval; s = s.parent_scope) for (var s = node.scope; s && !s.uses_eval; s = s.parent_scope)
s.uses_eval = true; s.uses_eval = true;
} }
if (name == "arguments") { if (func && name == "arguments") {
func.uses_arguments = true; func.uses_arguments = true;
} }
} else { } else {
@@ -240,14 +213,6 @@ AST_SymbolRef.DEFMETHOD("reference", function() {
this.frame = this.scope.nesting - def.scope.nesting; this.frame = this.scope.nesting - def.scope.nesting;
}); });
AST_Label.DEFMETHOD("init_scope_vars", function(){
this.references = [];
});
AST_LabelRef.DEFMETHOD("reference", function(){
this.thedef.references.push(this);
});
AST_Scope.DEFMETHOD("find_variable", function(name){ AST_Scope.DEFMETHOD("find_variable", function(name){
if (name instanceof AST_Symbol) name = name.name; if (name instanceof AST_Symbol) name = name.name;
return this.variables.get(name) return this.variables.get(name)
@@ -281,6 +246,11 @@ AST_Scope.DEFMETHOD("next_mangled", function(options){
out: while (true) { out: while (true) {
var m = base54(++this.cname); var m = base54(++this.cname);
if (!is_identifier(m)) continue; // skip over "do" if (!is_identifier(m)) continue; // skip over "do"
// https://github.com/mishoo/UglifyJS2/issues/242 -- do not
// shadow a name excepted from mangling.
if (options.except.indexOf(m) >= 0) continue;
// we must ensure that the mangled name does not shadow a name // we must ensure that the mangled name does not shadow a name
// from some parent scope that is referenced in this or in // from some parent scope that is referenced in this or in
// inner scopes. // inner scopes.
@@ -293,6 +263,19 @@ AST_Scope.DEFMETHOD("next_mangled", function(options){
} }
}); });
AST_Function.DEFMETHOD("next_mangled", function(options, def){
// #179, #326
// in Safari strict mode, something like (function x(x){...}) is a syntax error;
// a function expression's argument cannot shadow the function expression's name
var tricky_def = def.orig[0] instanceof AST_SymbolFunarg && this.name && this.name.definition();
while (true) {
var name = AST_Lambda.prototype.next_mangled.call(this, options, def);
if (!(tricky_def && tricky_def.mangled_name == name))
return name;
}
});
AST_Scope.DEFMETHOD("references", function(sym){ AST_Scope.DEFMETHOD("references", function(sym){
if (sym instanceof AST_Symbol) sym = sym.definition(); if (sym instanceof AST_Symbol) sym = sym.definition();
return this.enclosed.indexOf(sym) < 0 ? null : sym; return this.enclosed.indexOf(sym) < 0 ? null : sym;
@@ -382,6 +365,10 @@ AST_Toplevel.DEFMETHOD("mangle_names", function(options){
node.mangled_name = name; node.mangled_name = name;
return true; return true;
} }
if (options.screw_ie8 && node instanceof AST_SymbolCatch) {
to_mangle.push(node.definition());
return;
}
}); });
this.walk(tw); this.walk(tw);
to_mangle.forEach(function(def){ def.mangle(options) }); to_mangle.forEach(function(def){ def.mangle(options) });

View File

@@ -49,6 +49,9 @@ function SourceMap(options) {
file : null, file : null,
root : null, root : null,
orig : null, orig : null,
orig_line_diff : 0,
dest_line_diff : 0,
}); });
var generator = new MOZ_SourceMap.SourceMapGenerator({ var generator = new MOZ_SourceMap.SourceMapGenerator({
file : options.file, file : options.file,
@@ -61,14 +64,17 @@ function SourceMap(options) {
line: orig_line, line: orig_line,
column: orig_col column: orig_col
}); });
if (info.source === null) {
return;
}
source = info.source; source = info.source;
orig_line = info.line; orig_line = info.line;
orig_col = info.column; orig_col = info.column;
name = info.name; name = info.name;
} }
generator.addMapping({ generator.addMapping({
generated : { line: gen_line, column: gen_col }, generated : { line: gen_line + options.dest_line_diff, column: gen_col },
original : { line: orig_line, column: orig_col }, original : { line: orig_line + options.orig_line_diff, column: orig_col },
source : source, source : source,
name : name name : name
}); });

View File

@@ -44,7 +44,6 @@
"use strict"; "use strict";
// Tree transformer helpers. // Tree transformer helpers.
// XXX: eventually I should refactor the compressor to use this infrastructure.
function TreeTransformer(before, after) { function TreeTransformer(before, after) {
TreeWalker.call(this); TreeWalker.call(this);
@@ -160,6 +159,7 @@ TreeTransformer.prototype = new TreeWalker;
}); });
_(AST_VarDef, function(self, tw){ _(AST_VarDef, function(self, tw){
self.name = self.name.transform(tw);
if (self.value) self.value = self.value.transform(tw); if (self.value) self.value = self.value.transform(tw);
}); });

View File

@@ -82,16 +82,23 @@ function repeat_string(str, i) {
}; };
function DefaultsError(msg, defs) { function DefaultsError(msg, defs) {
Error.call(this, msg);
this.msg = msg; this.msg = msg;
this.defs = defs; this.defs = defs;
}; };
DefaultsError.prototype = Object.create(Error.prototype);
DefaultsError.prototype.constructor = DefaultsError;
DefaultsError.croak = function(msg, defs) {
throw new DefaultsError(msg, defs);
};
function defaults(args, defs, croak) { function defaults(args, defs, croak) {
if (args === true) if (args === true)
args = {}; args = {};
var ret = args || {}; var ret = args || {};
if (croak) for (var i in ret) if (ret.hasOwnProperty(i) && !defs.hasOwnProperty(i)) if (croak) for (var i in ret) if (ret.hasOwnProperty(i) && !defs.hasOwnProperty(i))
throw new DefaultsError("`" + i + "` is not a supported option", defs); DefaultsError.croak("`" + i + "` is not a supported option", defs);
for (var i in defs) if (defs.hasOwnProperty(i)) { for (var i in defs) if (defs.hasOwnProperty(i)) {
ret[i] = (args && args.hasOwnProperty(i)) ? args[i] : defs[i]; ret[i] = (args && args.hasOwnProperty(i)) ? args[i] : defs[i];
} }
@@ -245,6 +252,13 @@ function makePredicate(words) {
return new Function("str", f); return new Function("str", f);
}; };
function all(array, predicate) {
for (var i = array.length; --i >= 0;)
if (!predicate(array[i]))
return false;
return true;
};
function Dictionary() { function Dictionary() {
this._values = Object.create(null); this._values = Object.create(null);
this._size = 0; this._size = 0;

View File

@@ -3,21 +3,25 @@
"description": "JavaScript parser, mangler/compressor and beautifier toolkit", "description": "JavaScript parser, mangler/compressor and beautifier toolkit",
"homepage": "http://lisperator.net/uglifyjs", "homepage": "http://lisperator.net/uglifyjs",
"main": "tools/node.js", "main": "tools/node.js",
"version": "2.3.0", "version": "2.4.13",
"engines": { "node" : ">=0.4.0" }, "engines": { "node" : ">=0.4.0" },
"maintainers": [{ "maintainers": [{
"name": "Mihai Bazon", "name": "Mihai Bazon",
"email": "mihai.bazon@gmail.com", "email": "mihai.bazon@gmail.com",
"web": "http://lisperator.net/" "web": "http://lisperator.net/"
}], }],
"repositories": [{ "repository": {
"type": "git", "type": "git",
"url": "https://github.com/mishoo/UglifyJS2.git" "url": "https://github.com/mishoo/UglifyJS2.git"
}], },
"dependencies": { "dependencies": {
"async" : "~0.2.6", "async" : "~0.2.6",
"source-map" : "~0.1.7", "source-map" : "~0.1.33",
"optimist" : "~0.3.5" "optimist" : "~0.3.5",
"uglify-to-browserify": "~1.0.0"
},
"browserify": {
"transform": [ "uglify-to-browserify" ]
}, },
"bin": { "bin": {
"uglifyjs" : "bin/uglifyjs" "uglifyjs" : "bin/uglifyjs"

View File

@@ -1,12 +1,74 @@
holes_and_undefined: { holes_and_undefined: {
input: { input: {
w = [1,,];
x = [1, 2, undefined]; x = [1, 2, undefined];
y = [1, , 2, ]; y = [1, , 2, ];
z = [1, undefined, 3]; z = [1, undefined, 3];
} }
expect: { expect: {
w=[1,,];
x=[1,2,void 0]; x=[1,2,void 0];
y=[1,,2]; y=[1,,2];
z=[1,void 0,3]; z=[1,void 0,3];
} }
} }
constant_join: {
options = {
unsafe : true,
evaluate : true
};
input: {
var a = [ "foo", "bar", "baz" ].join("");
var a1 = [ "foo", "bar", "baz" ].join();
var b = [ "foo", 1, 2, 3, "bar" ].join("");
var c = [ boo(), "foo", 1, 2, 3, "bar", bar() ].join("");
var c1 = [ boo(), bar(), "foo", 1, 2, 3, "bar", bar() ].join("");
var c2 = [ 1, 2, "foo", "bar", baz() ].join("");
var d = [ "foo", 1 + 2 + "bar", "baz" ].join("-");
var e = [].join(foo + bar);
var f = [].join("");
var g = [].join("foo");
}
expect: {
var a = "foobarbaz";
var a1 = "foo,bar,baz";
var b = "foo123bar";
var c = boo() + "foo123bar" + bar();
var c1 = "" + boo() + bar() + "foo123bar" + bar();
var c2 = "12foobar" + baz();
var d = "foo-3bar-baz";
var e = [].join(foo + bar);
var f = "";
var g = "";
}
}
constant_join_2: {
options = {
unsafe : true,
evaluate : true
};
input: {
var a = [ "foo", "bar", boo(), "baz", "x", "y" ].join("");
var b = [ "foo", "bar", boo(), "baz", "x", "y" ].join("-");
var c = [ "foo", "bar", boo(), "baz", "x", "y" ].join("really-long-separator");
var d = [ "foo", "bar", boo(),
[ "foo", 1, 2, 3, "bar" ].join("+"),
"baz", "x", "y" ].join("-");
var e = [ "foo", "bar", boo(),
[ "foo", 1, 2, 3, "bar" ].join("+"),
"baz", "x", "y" ].join("really-long-separator");
var f = [ "str", "str" + variable, "foo", "bar", "moo" + foo ].join("");
}
expect: {
var a = "foobar" + boo() + "bazxy";
var b = [ "foo-bar", boo(), "baz-x-y" ].join("-");
var c = [ "foo", "bar", boo(), "baz", "x", "y" ].join("really-long-separator");
var d = [ "foo-bar", boo(), "foo+1+2+3+bar-baz-x-y" ].join("-");
var e = [ "foo", "bar", boo(),
"foo+1+2+3+bar",
"baz", "x", "y" ].join("really-long-separator");
var f = "strstr" + variable + "foobarmoo" + foo;
}
}

View File

@@ -0,0 +1,22 @@
concat_1: {
options = {
evaluate: true
};
input: {
var a = "foo" + "bar" + x() + "moo" + "foo" + y() + "x" + "y" + "z" + q();
var b = "foo" + 1 + x() + 2 + "boo";
var c = 1 + x() + 2 + "boo";
// this CAN'T safely be shortened to 1 + x() + "5boo"
var d = 1 + x() + 2 + 3 + "boo";
var e = 1 + x() + 2 + "X" + 3 + "boo";
}
expect: {
var a = "foobar" + x() + "moofoo" + y() + "xyz" + q();
var b = "foo1" + x() + "2boo";
var c = 1 + x() + 2 + "boo";
var d = 1 + x() + 2 + 3 + "boo";
var e = 1 + x() + 2 + "X3boo";
}
}

View File

@@ -141,3 +141,94 @@ ifs_6: {
x = foo || bar || baz || boo ? 20 : 10; x = foo || bar || baz || boo ? 20 : 10;
} }
} }
cond_1: {
options = {
conditionals: true
};
input: {
if (some_condition()) {
do_something(x);
} else {
do_something(y);
}
}
expect: {
do_something(some_condition() ? x : y);
}
}
cond_2: {
options = {
conditionals: true
};
input: {
if (some_condition()) {
x = new FooBar(1);
} else {
x = new FooBar(2);
}
}
expect: {
x = new FooBar(some_condition() ? 1 : 2);
}
}
cond_3: {
options = {
conditionals: true
};
input: {
if (some_condition()) {
new FooBar(1);
} else {
FooBar(2);
}
}
expect: {
some_condition() ? new FooBar(1) : FooBar(2);
}
}
cond_4: {
options = {
conditionals: true
};
input: {
if (some_condition()) {
do_something();
} else {
do_something();
}
}
expect: {
some_condition(), do_something();
}
}
cond_5: {
options = {
conditionals: true
};
input: {
if (some_condition()) {
if (some_other_condition()) {
do_something();
} else {
alternate();
}
} else {
alternate();
}
if (some_condition()) {
if (some_other_condition()) {
do_something();
}
}
}
expect: {
some_condition() && some_other_condition() ? do_something() : alternate();
some_condition() && some_other_condition() && do_something();
}
}

View File

@@ -95,3 +95,71 @@ unused_circular_references_3: {
} }
} }
} }
unused_keep_setter_arg: {
options = { unused: true };
input: {
var x = {
_foo: null,
set foo(val) {
},
get foo() {
return this._foo;
}
}
}
expect: {
var x = {
_foo: null,
set foo(val) {
},
get foo() {
return this._foo;
}
}
}
}
unused_var_in_catch: {
options = { unused: true };
input: {
function foo() {
try {
foo();
} catch(ex) {
var x = 10;
}
}
}
expect: {
function foo() {
try {
foo();
} catch(ex) {}
}
}
}
used_var_in_catch: {
options = { unused: true };
input: {
function foo() {
try {
foo();
} catch(ex) {
var x = 10;
}
return x;
}
}
expect: {
function foo() {
try {
foo();
} catch(ex) {
var x = 10;
}
return x;
}
}
}

View File

@@ -1,7 +1,6 @@
typeof_eq_undefined: { typeof_eq_undefined: {
options = { options = {
comparisons: true, comparisons: true
unsafe: false
}; };
input: { a = typeof b.c != "undefined" } input: { a = typeof b.c != "undefined" }
expect: { a = "undefined" != typeof b.c } expect: { a = "undefined" != typeof b.c }
@@ -13,5 +12,14 @@ typeof_eq_undefined_unsafe: {
unsafe: true unsafe: true
}; };
input: { a = typeof b.c != "undefined" } input: { a = typeof b.c != "undefined" }
expect: { a = b.c !== void 0 } expect: { a = void 0 !== b.c }
}
typeof_eq_undefined_unsafe2: {
options = {
comparisons: true,
unsafe: true
};
input: { a = "undefined" != typeof b.c }
expect: { a = void 0 !== b.c }
} }

View File

@@ -0,0 +1,24 @@
concatenate_rhs_strings: {
options = {
evaluate: true,
unsafe: true,
}
input: {
foo(bar() + 123 + "Hello" + "World");
foo(bar() + (123 + "Hello") + "World");
foo((bar() + 123) + "Hello" + "World");
foo(bar() + 123 + "Hello" + "World" + ("Foo" + "Bar"));
foo("Foo" + "Bar" + bar() + 123 + "Hello" + "World" + ("Foo" + "Bar"));
foo("Hello" + bar() + 123 + "World");
foo(bar() + 'Foo' + (10 + parseInt('10')));
}
expect: {
foo(bar() + 123 + "HelloWorld");
foo(bar() + "123HelloWorld");
foo((bar() + 123) + "HelloWorld");
foo(bar() + 123 + "HelloWorldFooBar");
foo("FooBar" + bar() + "123HelloWorldFooBar");
foo("Hello" + bar() + "123World");
foo(bar() + 'Foo' + (10 + parseInt('10')));
}
}

View File

@@ -0,0 +1,48 @@
/**
* There was an incorrect sort behaviour documented in issue #143:
* (x = f(…)) <= x → x >= (x = f(…))
*
* For example, let the equation be:
* (a = parseInt('100')) <= a
*
* If a was an integer and has the value of 99,
* (a = parseInt('100')) <= a → 100 <= 100 → true
*
* When transformed incorrectly:
* a >= (a = parseInt('100')) → 99 >= 100 → false
*/
tranformation_sort_order_equal: {
options = {
comparisons: true,
};
input: { (a = parseInt('100')) == a }
expect: { (a = parseInt('100')) == a }
}
tranformation_sort_order_unequal: {
options = {
comparisons: true,
};
input: { (a = parseInt('100')) != a }
expect: { (a = parseInt('100')) != a }
}
tranformation_sort_order_lesser_or_equal: {
options = {
comparisons: true,
};
input: { (a = parseInt('100')) <= a }
expect: { (a = parseInt('100')) <= a }
}
tranformation_sort_order_greater_or_equal: {
options = {
comparisons: true,
};
input: { (a = parseInt('100')) >= a }
expect: { (a = parseInt('100')) >= a }
}

View File

@@ -0,0 +1,11 @@
issue_267: {
options = { comparisons: true };
input: {
x = a % b / b * c * 2;
x = a % b * 2
}
expect: {
x = a % b / b * c * 2;
x = a % b * 2;
}
}

View File

@@ -0,0 +1,66 @@
issue_269_1: {
options = {unsafe: true};
input: {
f(
String(x),
Number(x),
Boolean(x),
String(),
Number(),
Boolean()
);
}
expect: {
f(
x + '', +x, !!x,
'', 0, false
);
}
}
issue_269_dangers: {
options = {unsafe: true};
input: {
f(
String(x, x),
Number(x, x),
Boolean(x, x)
);
}
expect: {
f(String(x, x), Number(x, x), Boolean(x, x));
}
}
issue_269_in_scope: {
options = {unsafe: true};
input: {
var String, Number, Boolean;
f(
String(x),
Number(x, x),
Boolean(x)
);
}
expect: {
var String, Number, Boolean;
f(String(x), Number(x, x), Boolean(x));
}
}
strings_concat: {
options = {unsafe: true};
input: {
f(
String(x + 'str'),
String('str' + x)
);
}
expect: {
f(
x + 'str',
'str' + x
);
}
}

View File

@@ -0,0 +1,76 @@
negate_iife_1: {
options = {
negate_iife: true
};
input: {
(function(){ stuff() })();
}
expect: {
!function(){ stuff() }();
}
}
negate_iife_2: {
options = {
negate_iife: true
};
input: {
(function(){ return {} })().x = 10; // should not transform this one
}
expect: {
(function(){ return {} })().x = 10;
}
}
negate_iife_3: {
options = {
negate_iife: true,
};
input: {
(function(){ return true })() ? console.log(true) : console.log(false);
}
expect: {
!function(){ return true }() ? console.log(false) : console.log(true);
}
}
negate_iife_3: {
options = {
negate_iife: true,
sequences: true
};
input: {
(function(){ return true })() ? console.log(true) : console.log(false);
(function(){
console.log("something");
})();
}
expect: {
!function(){ return true }() ? console.log(false) : console.log(true), function(){
console.log("something");
}();
}
}
negate_iife_4: {
options = {
negate_iife: true,
sequences: true,
conditionals: true,
};
input: {
if ((function(){ return true })()) {
foo(true);
} else {
bar(false);
}
(function(){
console.log("something");
})();
}
expect: {
!function(){ return true }() ? bar(false) : foo(true), function(){
console.log("something");
}();
}
}

View File

@@ -17,10 +17,18 @@ dot_properties: {
input: { input: {
a["foo"] = "bar"; a["foo"] = "bar";
a["if"] = "if"; a["if"] = "if";
a["*"] = "asterisk";
a["\u0EB3"] = "unicode";
a[""] = "whitespace";
a["1_1"] = "foo";
} }
expect: { expect: {
a.foo = "bar"; a.foo = "bar";
a["if"] = "if"; a["if"] = "if";
a["*"] = "asterisk";
a.\u0EB3 = "unicode";
a[""] = "whitespace";
a["1_1"] = "foo";
} }
} }
@@ -32,9 +40,15 @@ dot_properties_es5: {
input: { input: {
a["foo"] = "bar"; a["foo"] = "bar";
a["if"] = "if"; a["if"] = "if";
a["*"] = "asterisk";
a["\u0EB3"] = "unicode";
a[""] = "whitespace";
} }
expect: { expect: {
a.foo = "bar"; a.foo = "bar";
a.if = "if"; a.if = "if";
a["*"] = "asterisk";
a.\u0EB3 = "unicode";
a[""] = "whitespace";
} }
} }

View File

@@ -101,10 +101,12 @@ lift_sequences_1: {
lift_sequences_2: { lift_sequences_2: {
options = { sequences: true, evaluate: true }; options = { sequences: true, evaluate: true };
input: { input: {
q = 1 + (foo(), bar(), 5) + 7 * (5 / (3 - (a(), (QW=ER), c(), 2))) - (x(), y(), 5); foo.x = (foo = {}, 10);
bar = (bar = {}, 10);
} }
expect: { expect: {
foo(), bar(), a(), QW = ER, c(), x(), y(), q = 36 foo.x = (foo = {}, 10),
bar = {}, bar = 10;
} }
} }

View File

@@ -7,8 +7,15 @@ var assert = require("assert");
var sys = require("util"); var sys = require("util");
var tests_dir = path.dirname(module.filename); var tests_dir = path.dirname(module.filename);
var failures = 0;
var failed_files = {};
run_compress_tests(); run_compress_tests();
if (failures) {
sys.error("\n!!! Failed " + failures + " test cases.");
sys.error("!!! " + Object.keys(failed_files).join(", "));
process.exit(1);
}
/* -----[ utils ]----- */ /* -----[ utils ]----- */
@@ -83,6 +90,8 @@ function run_compress_tests() {
output: output, output: output,
expected: expect expected: expect
}); });
failures++;
failed_files[file] = 1;
} }
} }
var tests = parse_test(path.resolve(dir, file)); var tests = parse_test(path.resolve(dir, file));

View File

@@ -51,6 +51,7 @@ for (var i in UglifyJS) {
exports.minify = function(files, options) { exports.minify = function(files, options) {
options = UglifyJS.defaults(options, { options = UglifyJS.defaults(options, {
spidermonkey : false,
outSourceMap : null, outSourceMap : null,
sourceRoot : null, sourceRoot : null,
inSourceMap : null, inSourceMap : null,
@@ -60,20 +61,28 @@ exports.minify = function(files, options) {
output : null, output : null,
compress : {} compress : {}
}); });
if (typeof files == "string") UglifyJS.base54.reset();
files = [ files ];
// 1. parse // 1. parse
var toplevel = null; var toplevel = null,
files.forEach(function(file){ sourcesContent = {};
var code = options.fromString
? file if (options.spidermonkey) {
: fs.readFileSync(file, "utf8"); toplevel = UglifyJS.AST_Node.from_mozilla_ast(files);
toplevel = UglifyJS.parse(code, { } else {
filename: options.fromString ? "?" : file, if (typeof files == "string")
toplevel: toplevel files = [ files ];
files.forEach(function(file){
var code = options.fromString
? file
: fs.readFileSync(file, "utf8");
sourcesContent[file] = code;
toplevel = UglifyJS.parse(code, {
filename: options.fromString ? "?" : file,
toplevel: toplevel
});
}); });
}); }
// 2. compress // 2. compress
if (options.compress) { if (options.compress) {
@@ -103,6 +112,14 @@ exports.minify = function(files, options) {
orig: inMap, orig: inMap,
root: options.sourceRoot root: options.sourceRoot
}); });
if (options.sourceMapIncludeSources) {
for (var file in sourcesContent) {
if (sourcesContent.hasOwnProperty(file)) {
options.source_map.get().setSourceContent(file, sourcesContent[file]);
}
}
}
} }
if (options.output) { if (options.output) {
UglifyJS.merge(output, options.output); UglifyJS.merge(output, options.output);