forbid AST_Await in computed function arguments (#4352)

fixes #4351
This commit is contained in:
Alex Lam S.L
2020-12-08 04:59:08 +00:00
committed by GitHub
parent 4733159782
commit fea9da9866
2 changed files with 53 additions and 6 deletions

View File

@@ -12,7 +12,12 @@ describe("async", function() {
"function() { function await() {} }",
"function() { try {} catch (await) {} }",
].forEach(function(code) {
UglifyJS.parse("(" + code + ")();");
var ast = UglifyJS.parse("(" + code + ")();");
assert.strictEqual(ast.TYPE, "Toplevel");
assert.strictEqual(ast.body.length, 1);
assert.strictEqual(ast.body[0].TYPE, "SimpleStatement");
assert.strictEqual(ast.body[0].body.TYPE, "Call");
assert.strictEqual(ast.body[0].body.expression.TYPE, "Function");
assert.throws(function() {
UglifyJS.parse("(async " + code + ")();");
}, function(e) {
@@ -20,4 +25,41 @@ describe("async", function() {
}, code);
});
});
it("Should reject `await` expression outside of async functions", function() {
[
"await 42;",
"function f() { await 42; }",
"async function f() { function g() { await 42; } }",
].forEach(function(code) {
assert.throws(function() {
UglifyJS.parse(code);
}, function(e) {
return e instanceof UglifyJS.JS_Parse_Error;
}, code);
});
});
it("Should reject `await` expression directly on computed key of function argument", function() {
[
"function f({ [await 42]: a }) {}",
"async function f({ [await 42]: a }) {}",
].forEach(function(code) {
assert.throws(function() {
UglifyJS.parse(code);
}, function(e) {
return e instanceof UglifyJS.JS_Parse_Error;
}, code);
});
});
it("Should accept `await` expression nested within computed key of function argument", function() {
[
"function f({ [async function() { await 42; }()]: a }) {}",
"async function f({ [async function() { await 42; }()]: a }) {}",
].forEach(function(code) {
var ast = UglifyJS.parse(code);
assert.strictEqual(ast.TYPE, "Toplevel");
assert.strictEqual(ast.body.length, 1);
assert.strictEqual(ast.body[0].argnames.length, 1);
assert.strictEqual(ast.body[0].argnames[0].TYPE, "DestructuredObject");
});
});
});