suppress invalid AST transform in --reduce-test (#4498)

This commit is contained in:
Alex Lam S.L
2021-01-03 02:34:46 +00:00
committed by GitHub
parent 110c1ac097
commit e8c04f8cb6
4 changed files with 33 additions and 1 deletions

View File

@@ -0,0 +1,3 @@
var o = {};
[ o[1 + .1 + .1] ] = [ 42 ];
console.log(o[1.2]);

View File

@@ -0,0 +1,17 @@
// (beautified)
var o = {};
[ o[1 + .1 + .1] ] = [];
console.log(o);
// output: { '1.2000000000000002': undefined }
//
// minify: { '1.2': undefined }
//
// options: {
// "compress": {
// "unsafe_math": true
// },
// "mangle": false,
// "validate": true
// }

View File

@@ -307,6 +307,18 @@ describe("test/reduce.js", function() {
if (result.error) throw result.error;
assert.strictEqual(result.code, read("test/input/reduce/diff_error.reduced.js"));
});
it("Should maintain valid LHS in destructuring assignments", function() {
if (semver.satisfies(process.version, "<6")) return;
var result = reduce_test(read("test/input/reduce/destructured_assign.js"), {
compress: {
unsafe_math: true,
},
mangle: false,
validate: true,
});
if (result.error) throw result.error;
assert.strictEqual(result.code, read("test/input/reduce/destructured_assign.reduced.js"));
});
it("Should handle destructured catch expressions", function() {
if (semver.satisfies(process.version, "<6")) return;
var result = reduce_test(read("test/input/reduce/destructured_catch.js"), {

View File

@@ -341,7 +341,7 @@ module.exports = function reduce_test(testcase, minify_options, reduce_options)
else if (node instanceof U.AST_PropAccess) {
var expr = [
node.expression,
node.property instanceof U.AST_Node && node.property,
node.property instanceof U.AST_Node && !(parent instanceof U.AST_Destructured) && node.property,
][ node.start._permute++ % 2 ];
if (expr) {
CHANGED = true;