JoBoEVD/UglifyJS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix corner case in conditionals (#5667)

Browse Source 
fixes #5666
This commit is contained in:
Alex Lam S.L
2022-09-17 03:42:32 +01:00
committed by GitHub
parent 001f6f9719
commit e4bff315eb
2 changed files with 61 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/compress.js
View File

@@ -12865,8 +12865,7 @@ Compressor.prototype.compress = function(node) {
var alt_tail = alternative.tail_node();
// x ? y : y ---> x, y
// x ? (a, c) : (b, c) ---> x ? a : b, c
if (seq_tail.equals(alt_tail)) {
return make_sequence(self, consequent.equals(alternative) ? [
if (seq_tail.equals(alt_tail)) return make_sequence(self, consequent.equals(alternative) ? [
condition,
consequent,
] : [
@@ -12875,9 +12874,8 @@ Compressor.prototype.compress = function(node) {
consequent: pop_seq(consequent),
alternative: pop_seq(alternative),
}),
seq_tail,
alt_tail,
]).optimize(compressor);
}
// x ? y.p : z.p ---> (x ? y : z).p
// x ? y(a) : z(a) ---> (x ? y : z)(a)
// x ? y.f(a) : z.f(a) ---> (x ? y : z).f(a)

50
test/compress/conditionals.js
View File

@@ -2878,3 +2878,53 @@ issue_5546_3: {
}
expect_stdout: "PASS"
}
issue_5666_1: {
options = {
conditionals: true,
reduce_vars: true,
unused: true,
}
input: {
var a;
(function() {
var b = a;
a ? a = b : (b++, a = b);
})();
console.log(a);
}
expect: {
var a;
(function() {
var b = a;
a = (a ? 0 : b++, b);
})();
console.log(a);
}
expect_stdout: "NaN"
}
issue_5666_2: {
options = {
conditionals: true,
reduce_vars: true,
unused: true,
}
input: {
var a = "foo";
(function() {
var b = a;
a ? (b++, a = b) : a = b;
})();
console.log(a);
}
expect: {
var a = "foo";
(function() {
var b = a;
a = (a ? b++ : 0, b);
})();
console.log(a);
}
expect_stdout: "NaN"
}