JoBoEVD/UglifyJS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix corner case in evaluate (#3921)

Browse Source 
fixes #3920
This commit is contained in:
Alex Lam S.L
2020-05-22 04:38:09 +01:00
committed by GitHub
parent 75c5b6029b
commit d1cc5270a3
2 changed files with 42 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
lib/compress.js
View File

@@ -3256,11 +3256,21 @@ merge(Compressor.prototype, {
&& unaryPrefix[this.operator];
}
});
function modified(sym) {
if (!(sym instanceof AST_SymbolRef)) return;
sym.definition().references.forEach(function(node) {
delete node._eval;
});
var scan_modified = new TreeWalker(function(node) {
if (node instanceof AST_Assign) modified(node.left);
if (node instanceof AST_Unary && unary_arithmetic[node.operator]) modified(node.expression);
});
function modified(node) {
if (node instanceof AST_Dot) {
modified(node.expression);
} else if (node instanceof AST_Sub) {
modified(node.expression);
node.property.walk(scan_modified);
} else if (node instanceof AST_SymbolRef) {
node.definition().references.forEach(function(ref) {
delete ref._eval;
});
}
}
def(AST_Statement, function() {
throw new Error(string_template("Cannot evaluate a statement [{file}:{line},{col}]", this.start));
@@ -3280,12 +3290,11 @@ merge(Compressor.prototype, {
});
def(AST_Sequence, function(compressor, ignore_side_effects, cached, depth) {
if (!ignore_side_effects) return this;
var tail = this.tail_node();
this.walk(new TreeWalker(function(node) {
if (node === tail) return true;
if (node instanceof AST_Assign) modified(node.left);
if (node instanceof AST_Unary && unary_arithmetic[node.operator]) modified(node.expression);
}));
var exprs = this.expressions;
for (var i = 0, last = exprs.length - 1; i < last; i++) {
exprs[i].walk(scan_modified);
}
var tail = exprs[last];
var value = tail._eval(compressor, ignore_side_effects, cached, depth);
return value === tail ? this : value;
});