JoBoEVD/UglifyJS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix corner case in comparisons (#3877)

Browse Source
This commit is contained in:
Alex Lam S.L
2020-05-10 23:33:52 +01:00
committed by GitHub
parent c76ee4b868
commit c1dd49e075
2 changed files with 38 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lib/compress.js
View File

@@ -6819,7 +6819,7 @@ merge(Compressor.prototype, {
if ((self.left.is_string(compressor) && self.right.is_string(compressor)) ||
(self.left.is_number(compressor) && self.right.is_number(compressor)) ||
(self.left.is_boolean(compressor) && self.right.is_boolean(compressor)) ||
self.left.equivalent_to(self.right)) {
can_self_compare(self.left) && self.left.equivalent_to(self.right)) {
self.operator = self.operator.slice(0, 2);
}
// XXX: intentionally falling down to the next case
@@ -7342,6 +7342,13 @@ merge(Compressor.prototype, {
}
return try_evaluate(compressor, self);
function can_self_compare(node) {
if (node instanceof AST_Dot) return can_self_compare(node.expression);
if (node instanceof AST_Sub) return can_self_compare(node.expression) && can_self_compare(node.property);
if (node instanceof AST_Symbol) return true;
return !node.has_side_effects(compressor);
}
function align(ref, op) {
switch (ref) {
case "-":