fix corner case in collapse_vars (#3699)

fixes #3698
This commit is contained in:
Alex Lam S.L
2020-01-30 00:08:53 +08:00
committed by GitHub
parent 2ba5f391e0
commit a3754068dd
2 changed files with 83 additions and 7 deletions

View File

@@ -1094,6 +1094,7 @@ merge(Compressor.prototype, {
collapse(statements, compressor);
}
} while (CHANGED && max_iter-- > 0);
return statements;
function find_loop_scope_try() {
var node = compressor.self(), level = 0;
@@ -1150,11 +1151,10 @@ merge(Compressor.prototype, {
if (node.single_use && parent instanceof AST_VarDef && parent.value === node) return node;
// Replace variable with assignment when found
var hit_rhs;
if (can_replace
&& !(node instanceof AST_SymbolDeclaration)
if (!(node instanceof AST_SymbolDeclaration)
&& (scan_lhs && lhs.equivalent_to(node)
|| scan_rhs && (hit_rhs = scan_rhs(node, this)))) {
if (stop_if_hit && (hit_rhs || !lhs_local || !replace_all)) {
if (!can_replace || stop_if_hit && (hit_rhs || !lhs_local || !replace_all)) {
if (!hit_rhs || !value_def) abort = true;
return node;
}
@@ -3854,12 +3854,12 @@ merge(Compressor.prototype, {
});
OPT(AST_Block, function(self, compressor) {
tighten_body(self.body, compressor);
self.body = tighten_body(self.body, compressor);
return self;
});
OPT(AST_BlockStatement, function(self, compressor) {
tighten_body(self.body, compressor);
self.body = tighten_body(self.body, compressor);
switch (self.body.length) {
case 1: return self.body[0];
case 0: return make_node(AST_EmptyStatement, self);
@@ -3868,7 +3868,7 @@ merge(Compressor.prototype, {
});
OPT(AST_Lambda, function(self, compressor) {
tighten_body(self.body, compressor);
self.body = tighten_body(self.body, compressor);
if (compressor.option("side_effects")
&& self.body.length == 1
&& self.body[0] === compressor.has_directive("use strict")) {
@@ -5372,7 +5372,7 @@ merge(Compressor.prototype, {
});
OPT(AST_Try, function(self, compressor) {
tighten_body(self.body, compressor);
self.body = tighten_body(self.body, compressor);
if (self.bcatch && self.bfinally && all(self.bfinally.body, is_empty)) self.bfinally = null;
if (compressor.option("dead_code") && all(self.body, is_empty)) {
var body = [];