Compress conditional assignments where all possible outcomes are equivalant and condition has no side effects

This commit is contained in:
Tal Ater
2014-09-02 23:30:25 +03:00
parent 4c64554808
commit 885835a655
2 changed files with 51 additions and 0 deletions

View File

@@ -2321,6 +2321,13 @@ merge(Compressor.prototype, {
alternative: alternative alternative: alternative
}); });
} }
// x=y?1:1 --> x=1
if (!self.condition.has_side_effects(compressor)
&& consequent instanceof AST_Constant
&& alternative instanceof AST_Constant
&& consequent.equivalent_to(alternative)) {
return make_node_from_constant(compressor, consequent.value, self);
}
return self; return self;
}); });

View File

@@ -232,3 +232,47 @@ cond_5: {
some_condition() && some_other_condition() && do_something(); some_condition() && some_other_condition() && do_something();
} }
} }
cond_7: {
options = {
conditionals: true,
evaluate : true
};
input: {
// compress these
if (y) {
x = 1+1;
} else {
x = 2;
}
x = y ? 'foo' : 'fo'+'o';
x = y ? 'foo' : y ? 'foo' : 'fo'+'o';
// don't compress these
x = y ? a : b;
x = y ? 'foo' : 'fo';
// make sure not to mess with conditions that have side effects
// TODO: Make sure to mess with conditions that have side effects... proprely
if (some_condition()) {
x = 1+1;
} else {
x = 2;
}
x = some_condition() ? 'foo' : 'fo'+'o';
}
expect: {
x = 2;
x = 'foo';
x = 'foo';
x = y ? a : b;
x = y ? 'foo' : 'fo';
x = some_condition() ? 2 : 2;
x = some_condition() ? 'foo' : 'foo';
}
}