fix corner case in dead_code (#5642)

fixes #5641
This commit is contained in:
Alex Lam S.L
2022-09-03 23:18:25 +01:00
committed by GitHub
parent e012f046bc
commit 78f354beb8
2 changed files with 42 additions and 7 deletions

View File

@@ -12706,13 +12706,23 @@ Compressor.prototype.compress = function(node) {
return try_evaluate(compressor, self); return try_evaluate(compressor, self);
function is_tail(node, parent) { function is_tail(node, parent) {
if (parent instanceof AST_Binary) { if (parent instanceof AST_Binary) switch (node) {
return parent.right === node || parent.right.is_constant_expression(scope); case parent.left:
return parent.right.is_constant_expression(scope);
case parent.right:
return true;
default:
return false;
} }
if (parent instanceof AST_Conditional) { if (parent instanceof AST_Conditional) switch (node) {
return parent.condition !== node case parent.condition:
|| parent.consequent.is_constant_expression(scope) return parent.consequent.is_constant_expression(scope)
&& parent.alternative.is_constant_expression(scope); && parent.alternative.is_constant_expression(scope);
case parent.consequent:
case parent.alternative:
return true;
default:
return false;
} }
if (parent instanceof AST_Sequence) { if (parent instanceof AST_Sequence) {
var exprs = parent.expressions; var exprs = parent.expressions;
@@ -12723,7 +12733,7 @@ Compressor.prototype.compress = function(node) {
} }
return true; return true;
} }
if (parent instanceof AST_UnaryPrefix) return true; return parent instanceof AST_UnaryPrefix;
} }
function is_tail_block(stat, parent) { function is_tail_block(stat, parent) {

View File

@@ -1705,3 +1705,28 @@ issue_5506: {
"bar", "bar",
] ]
} }
issue_5641: {
options = {
collapse_vars: true,
conditionals: true,
dead_code: true,
}
input: {
function f(a) {
if (a || b) {
var b = "PASS", c = b && console.log(b);
} else
var d = a || b;
}
f(42);
}
expect: {
function f(a) {
var b, c, d;
(a || b) && (b = "PASS") && console.log(b);
}
f(42);
}
expect_stdout: "PASS"
}