When unsafe is set, evaluate [...].join() if possible

Close #298
This commit is contained in:
Mihai Bazon
2013-09-19 18:20:45 +03:00
parent 8d14efe818
commit 78e98d2611
2 changed files with 33 additions and 1 deletions

View File

@@ -746,6 +746,19 @@ merge(Compressor.prototype, {
if (d && d.constant && d.init) return ev(d.init, compressor);
throw def;
});
def(AST_Call, function(compressor){
if (compressor.option("unsafe")) {
if (this.expression instanceof AST_Dot
&& this.expression.expression instanceof AST_Array
&& this.expression.property == "join") {
var x = this.expression.expression.elements.map(function(el){
return ev(el, compressor);
});
return x.join(ev(this.args[0]));
}
}
throw def;
});
})(function(node, func){
node.DEFMETHOD("_eval", func);
});
@@ -1704,7 +1717,7 @@ merge(Compressor.prototype, {
return make_node(AST_Undefined, self).transform(compressor);
}
}
return self;
return self.evaluate(compressor)[0];
});
OPT(AST_New, function(self, compressor){

View File

@@ -12,3 +12,22 @@ holes_and_undefined: {
z=[1,void 0,3];
}
}
constant_join: {
options = {
unsafe : true,
evaluate : true
};
input: {
var a = [ "foo", "bar", "baz" ].join("");
var b = [ "foo", 1, 2, 3, "bar" ].join("");
var c = [ boo(), "foo", 1, 2, 3, "bar", bar() ].join("");
var d = [ "foo", 1 + 2 + "bar", "baz" ].join("-");
}
expect: {
var a = "foobarbaz";
var b = "foo123bar";
var c = [ boo(), "foo", 1, 2, 3, "bar", bar() ].join(""); // we could still shorten this one, but oh well.
var d = "foo-3bar-baz";
}
}