JoBoEVD/UglifyJS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix corner cases with rest parameters (#4526)

Browse Source 
fixes #4525
This commit is contained in:
Alex Lam S.L
2021-01-09 00:38:51 +00:00
committed by GitHub
parent 553034fe52
commit 770f3ba5fe
2 changed files with 44 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/compress.js
View File

@@ -5669,8 +5669,9 @@ merge(Compressor.prototype, {
}
if (node.rest) {
node.rest = node.rest.transform(trimmer);
if (node.rest instanceof AST_DestructuredArray && node.rest.elements.length == 0
|| node.rest instanceof AST_DestructuredObject && node.rest.properties.length == 0) {
if (!(node.uses_arguments && !tt.has_directive("use strict"))
&& (node.rest instanceof AST_DestructuredArray && node.rest.elements.length == 0
|| node.rest instanceof AST_DestructuredObject && node.rest.properties.length == 0)) {
node.rest = null;
}
}
@@ -10467,6 +10468,7 @@ merge(Compressor.prototype, {
argname = null;
} else if (compressor.has_directive("use strict")
|| fn.name
|| fn.rest
|| !(fn_parent instanceof AST_Call && index < fn_parent.args.length)
|| !all(fn.argnames, function(argname) {
return argname instanceof AST_SymbolFunarg;

40
test/compress/rests.js
View File

@@ -485,3 +485,43 @@ keep_arguments: {
expect_stdout: "PASS"
node_version: ">=6"
}
issue_4525_1: {
options = {
arguments: true,
}
input: {
console.log(function(a, ...[]) {
a = "FAIL";
return arguments[0];
}("PASS"));
}
expect: {
console.log(function(a, ...[]) {
a = "FAIL";
return arguments[0];
}("PASS"));
}
expect_stdout: "PASS"
node_version: ">=6"
}
issue_4525_2: {
options = {
unused: true,
}
input: {
console.log(function(a, ...[]) {
a = "FAIL";
return arguments[0];
}("PASS"));
}
expect: {
console.log(function(a, ...[]) {
a = "FAIL";
return arguments[0];
}("PASS"));
}
expect_stdout: "PASS"
node_version: ">=6"
}