fix corner case in unused (#4469)

fixes #4468
This commit is contained in:
Alex Lam S.L
2020-12-27 12:06:50 +00:00
committed by GitHub
parent a8785fb694
commit 6a8aed2049
2 changed files with 39 additions and 7 deletions

View File

@@ -5460,7 +5460,7 @@ merge(Compressor.prototype, {
var calls_to_drop_args = [];
var fns_with_marked_args = [];
var trimmer = new TreeTransformer(function(node) {
if (node instanceof AST_DefaultValue) return trim_default(tt, trimmer, node);
if (node instanceof AST_DefaultValue) return trim_default(trimmer, node);
if (node instanceof AST_DestructuredArray) {
var trim = true;
for (var i = node.elements.length; --i >= 0;) {
@@ -5482,10 +5482,13 @@ merge(Compressor.prototype, {
node.key = node.key.transform(tt);
retain = node.key.has_side_effects(compressor);
}
if (retain && is_decl(node.value)) return node;
var value = node.value.transform(trimmer);
if (!value) return List.skip;
node.value = value;
if (retain && is_decl(node.value)) {
node.value = node.value.transform(tt);
} else {
var value = node.value.transform(trimmer);
if (!value) return List.skip;
node.value = value;
}
return node;
}
if (node instanceof AST_SymbolDeclaration) return node.definition().id in in_use_ids ? node : null;
@@ -6042,7 +6045,7 @@ merge(Compressor.prototype, {
return (node instanceof AST_DefaultValue ? node.name : node) instanceof AST_SymbolDeclaration;
}
function trim_default(tt, trimmer, node) {
function trim_default(trimmer, node) {
node.value = node.value.transform(tt);
var name = node.name.transform(trimmer);
if (!name) {
@@ -6076,7 +6079,7 @@ merge(Compressor.prototype, {
if (compressor.option("default_values") && value && value.is_defined(compressor)) {
node = node.name;
} else {
return trim_default(tt, trimmer, node);
return trim_default(trimmer, node);
}
}
if (node instanceof AST_DestructuredArray) {
@@ -6125,6 +6128,7 @@ merge(Compressor.prototype, {
retain = false;
}
if (retain && is_decl(prop.value)) {
prop.value = prop.value.transform(tt);
properties.push(prop);
} else {
var newValue = prop.value.transform(trimmer);