Legacy octal integer strict mode fixes
This commit is contained in:
@@ -349,6 +349,9 @@ function tokenizer($TEXT, filename, html5_comments, shebang) {
|
|||||||
return is_alphanumeric_char(code);
|
return is_alphanumeric_char(code);
|
||||||
});
|
});
|
||||||
if (prefix) num = prefix + num;
|
if (prefix) num = prefix + num;
|
||||||
|
if (RE_OCT_NUMBER.test(num) && next_token.has_directive("use strict")) {
|
||||||
|
parse_error("SyntaxError: Legacy octal literals are not allowed in strict mode");
|
||||||
|
}
|
||||||
var valid = parse_js_number(num);
|
var valid = parse_js_number(num);
|
||||||
if (!isNaN(valid)) {
|
if (!isNaN(valid)) {
|
||||||
return token("num", valid);
|
return token("num", valid);
|
||||||
@@ -392,7 +395,7 @@ function tokenizer($TEXT, filename, html5_comments, shebang) {
|
|||||||
// Parse
|
// Parse
|
||||||
if (ch === "0") return "\0";
|
if (ch === "0") return "\0";
|
||||||
if (ch.length > 0 && next_token.has_directive("use strict"))
|
if (ch.length > 0 && next_token.has_directive("use strict"))
|
||||||
parse_error("SyntaxError: Octal literals are not allowed in strict mode");
|
parse_error("SyntaxError: Legacy octal escape sequences are not allowed in strict mode");
|
||||||
return String.fromCharCode(parseInt(ch, 8));
|
return String.fromCharCode(parseInt(ch, 8));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
24
test/mocha/number-literal.js
Normal file
24
test/mocha/number-literal.js
Normal file
@@ -0,0 +1,24 @@
|
|||||||
|
var assert = require("assert");
|
||||||
|
var uglify = require("../../");
|
||||||
|
|
||||||
|
describe("Number literals", function () {
|
||||||
|
it("Should not allow legacy octal literals in strict mode", function() {
|
||||||
|
var inputs = [
|
||||||
|
'"use strict";00;',
|
||||||
|
'"use strict"; var foo = 00;'
|
||||||
|
];
|
||||||
|
|
||||||
|
var test = function(input) {
|
||||||
|
return function() {
|
||||||
|
uglify.parse(input);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
var error = function(e) {
|
||||||
|
return e instanceof uglify.JS_Parse_Error &&
|
||||||
|
e.message === "SyntaxError: Legacy octal literals are not allowed in strict mode";
|
||||||
|
}
|
||||||
|
for (var i = 0; i < inputs.length; i++) {
|
||||||
|
assert.throws(test(inputs[i]), error, inputs[i]);
|
||||||
|
}
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -49,7 +49,7 @@ describe("String literals", function() {
|
|||||||
|
|
||||||
var error = function(e) {
|
var error = function(e) {
|
||||||
return e instanceof UglifyJS.JS_Parse_Error &&
|
return e instanceof UglifyJS.JS_Parse_Error &&
|
||||||
e.message === "SyntaxError: Octal literals are not allowed in strict mode";
|
e.message === "SyntaxError: Legacy octal escape sequences are not allowed in strict mode";
|
||||||
}
|
}
|
||||||
|
|
||||||
for (var input in inputs) {
|
for (var input in inputs) {
|
||||||
|
|||||||
Reference in New Issue
Block a user