JoBoEVD/UglifyJS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix parens for AST_Undefined

Browse Source 
Do the same as for AST_Unary, since we output undefined as `void 0`.

Reported at https://github.com/mishoo/UglifyJS2/issues/338#issuecomment-48858341
This commit is contained in:
Mihai Bazon
2014-07-18 11:31:41 +03:00
parent 83e0939088
commit 62bda71c85
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
lib/output.js
View File

@@ -434,7 +434,13 @@ function OutputStream(options) {
/* -----[ PARENTHESES ]----- */
function PARENS(nodetype, func) {
nodetype.DEFMETHOD("needs_parens", func);
if (Array.isArray(nodetype)) {
nodetype.forEach(function(nodetype){
PARENS(nodetype, func);
});
} else {
nodetype.DEFMETHOD("needs_parens", func);
}
};
PARENS(AST_Node, function(){
@@ -453,7 +459,7 @@ function OutputStream(options) {
return first_in_statement(output);
});
PARENS(AST_Unary, function(output){
PARENS([ AST_Unary, AST_Undefined ], function(output){
var p = output.parent();
return p instanceof AST_PropAccess && p.expression === this;
});
@@ -549,7 +555,7 @@ function OutputStream(options) {
return true;
});
function assign_and_conditional_paren_rules(output) {
PARENS([ AST_Assign, AST_Conditional ], function (output){
var p = output.parent();
// !(a = false) → true
if (p instanceof AST_Unary)
@@ -566,10 +572,7 @@ function OutputStream(options) {
// (a = foo)["prop"] —or— (a = foo).prop
if (p instanceof AST_PropAccess && p.expression === this)
return true;
};
PARENS(AST_Assign, assign_and_conditional_paren_rules);
PARENS(AST_Conditional, assign_and_conditional_paren_rules);
});
/* -----[ PRINTERS ]----- */