JoBoEVD/UglifyJS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix corner cases in reduce_vars (#4674)

Browse Source
This commit is contained in:
Alex Lam S.L
2021-02-22 00:21:21 +00:00
committed by GitHub
parent b726e364c1
commit 55b59407e4
2 changed files with 81 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/compress.js
View File

@@ -374,12 +374,20 @@ merge(Compressor.prototype, {
var lhs = is_lhs(node, parent); var lhs = is_lhs(node, parent);
if (lhs) return lhs; if (lhs) return lhs;
if (parent instanceof AST_Array) return is_modified(compressor, tw, parent, parent, level + 1); if (parent instanceof AST_Array) return is_modified(compressor, tw, parent, parent, level + 1);
if (parent instanceof AST_Binary) {
if (!lazy_op[parent.operator]) return;
return is_modified(compressor, tw, parent, parent, level + 1);
}
if (parent instanceof AST_Call) { if (parent instanceof AST_Call) {
return !immutable return !immutable
&& parent.expression === node && parent.expression === node
&& !parent.is_expr_pure(compressor) && !parent.is_expr_pure(compressor)
&& (!(value instanceof AST_LambdaExpression) || !(parent instanceof AST_New) && value.contains_this()); && (!(value instanceof AST_LambdaExpression) || !(parent instanceof AST_New) && value.contains_this());
} }
if (parent instanceof AST_Conditional) {
if (parent.condition === node) return;
return is_modified(compressor, tw, parent, parent, level + 1);
}
if (parent instanceof AST_ForEnumeration) return parent.init === node; if (parent instanceof AST_ForEnumeration) return parent.init === node;
if (parent instanceof AST_ObjectKeyVal) { if (parent instanceof AST_ObjectKeyVal) {
if (parent.value !== node) return; if (parent.value !== node) return;
@@ -391,6 +399,10 @@ merge(Compressor.prototype, {
var prop = read_property(value, parent); var prop = read_property(value, parent);
return (!immutable || recursive) && is_modified(compressor, tw, parent, prop, level + 1); return (!immutable || recursive) && is_modified(compressor, tw, parent, prop, level + 1);
} }
if (parent instanceof AST_Sequence) {
if (parent.tail_node() !== node) return;
return is_modified(compressor, tw, parent, value, level + 1, immutable, recursive);
}
} }
function is_arguments(def) { function is_arguments(def) {

69
test/compress/arrays.js
View File

@@ -355,3 +355,72 @@ constructor_good: {
expect_stdout: true expect_stdout: true
expect_warnings: [] expect_warnings: []
} }
unsafe_evaluate_modified_binary: {
options = {
evaluate: true,
reduce_vars: true,
unsafe: true,
}
input: {
(function(a) {
(console && a).push(1);
if (a.length)
console.log("PASS");
})([]);
}
expect: {
(function(a) {
(console && a).push(1);
if (a.length)
console.log("PASS");
})([]);
}
expect_stdout: "PASS"
}
unsafe_evaluate_modified_conditional: {
options = {
evaluate: true,
reduce_vars: true,
unsafe: true,
}
input: {
(function(a) {
(console ? a : []).push(1);
if (a.length)
console.log("PASS");
})([]);
}
expect: {
(function(a) {
(console ? a : []).push(1);
if (a.length)
console.log("PASS");
})([]);
}
expect_stdout: "PASS"
}
unsafe_evaluate_modified_sequence: {
options = {
evaluate: true,
reduce_vars: true,
unsafe: true,
}
input: {
(function(a) {
(0, a).push(1);
if (a.length)
console.log("PASS");
})([]);
}
expect: {
(function(a) {
(0, a).push(1);
if (a.length)
console.log("PASS");
})([]);
}
expect_stdout: "PASS"
}