fix corner case in collapse_vars (#3642)

fixes #3641
This commit is contained in:
Alex Lam S.L
2019-12-22 01:08:56 +00:00
committed by GitHub
parent 3ff0feddee
commit 519a00bd8a
2 changed files with 27 additions and 1 deletions

View File

@@ -1569,6 +1569,7 @@ merge(Compressor.prototype, {
var parent = scanner.parent(level); var parent = scanner.parent(level);
if (parent instanceof AST_Array) return find_stop_value(parent, level + 1); if (parent instanceof AST_Array) return find_stop_value(parent, level + 1);
if (parent instanceof AST_Assign) { if (parent instanceof AST_Assign) {
if (may_throw(parent)) return node;
if (parent.left instanceof AST_SymbolRef) { if (parent.left instanceof AST_SymbolRef) {
var name = parent.left.name; var name = parent.left.name;
if (lhs.name == name) return node; if (lhs.name == name) return node;
@@ -1647,7 +1648,9 @@ merge(Compressor.prototype, {
if (is_last_node(node, parent)) return node; if (is_last_node(node, parent)) return node;
if (in_conditional(node, parent)) return node; if (in_conditional(node, parent)) return node;
if (parent instanceof AST_Array) return find_stop_unused(parent, level + 1); if (parent instanceof AST_Array) return find_stop_unused(parent, level + 1);
if (parent instanceof AST_Assign) return find_stop_unused(parent, level + 1); if (parent instanceof AST_Assign) {
return may_throw(parent) ? node : find_stop_unused(parent, level + 1);
}
if (parent instanceof AST_Binary) return find_stop_unused(parent, level + 1); if (parent instanceof AST_Binary) return find_stop_unused(parent, level + 1);
if (parent instanceof AST_Call) return find_stop_unused(parent, level + 1); if (parent instanceof AST_Call) return find_stop_unused(parent, level + 1);
if (parent instanceof AST_Case) return find_stop_unused(parent, level + 1); if (parent instanceof AST_Case) return find_stop_unused(parent, level + 1);

View File

@@ -7399,3 +7399,26 @@ issue_3628_2: {
} }
expect_stdout: "foo bar" expect_stdout: "foo bar"
} }
issue_3641: {
options = {
collapse_vars: true,
}
input: {
var a, b;
try {
a = "foo";
b = (a += (A.p = 0, "bar")) % 0;
} catch (e) {}
console.log(a, b);
}
expect: {
var a, b;
try {
a = "foo";
b = (a += (A.p = 0, "bar")) % 0;
} catch (e) {}
console.log(a, b);
}
expect_stdout: "foo undefined"
}