JoBoEVD/UglifyJS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix faulty compression

Browse Source 
`String(x + 5)` is not always the same as `x + "5"`.  Overlooked that. :-(

Close #350
This commit is contained in:
Mihai Bazon
2013-11-20 21:13:16 +02:00
parent 7d11b96f48
commit 50b8d7272c
2 changed files with 3 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/compress.js
View File

@@ -2031,16 +2031,6 @@ merge(Compressor.prototype, {
&& self.right.getValue() === "" && self.left instanceof AST_Binary && self.right.getValue() === "" && self.left instanceof AST_Binary
&& self.left.operator == "+" && self.left.is_string(compressor)) { && self.left.operator == "+" && self.left.is_string(compressor)) {
return self.left; return self.left;
} else if (self.operator == "+" && self.right instanceof AST_String
&& self.right.getValue() === "" && self.left instanceof AST_Binary
&& self.left.operator == "+" && self.left.right instanceof AST_Number) {
return make_node(AST_Binary, self, {
left: self.left.left,
operator: "+",
right: make_node(AST_String, self.right, {
value: String(self.left.right.value)
})
});
} }
if (compressor.option("evaluate")) { if (compressor.option("evaluate")) {
if (self.operator == "+") { if (self.operator == "+") {

6
test/compress/issue-269.js
View File

@@ -54,15 +54,13 @@ strings_concat: {
input: { input: {
f( f(
String(x + 'str'), String(x + 'str'),
String('str' + x), String('str' + x)
String(x + 5)
); );
} }
expect: { expect: {
f( f(
x + 'str', x + 'str',
'str' + x, 'str' + x
x + '5'
); );
} }
} }