From 46570a4eb6a7251035fd70ec8ebb4402c7a945a9 Mon Sep 17 00:00:00 2001 From: "Alex Lam S.L" Date: Sat, 12 Mar 2022 06:14:30 +0000 Subject: [PATCH] fix corner case in `side_effects` (#5383) fixes #5382 --- lib/compress.js | 1 - test/compress/spreads.js | 28 ++++++++++++++++++++++++++++ 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/lib/compress.js b/lib/compress.js index 6f4d46fc..13a7973b 100644 --- a/lib/compress.js +++ b/lib/compress.js @@ -5426,7 +5426,6 @@ Compressor.prototype.compress = function(node) { return !(prop instanceof AST_ObjectGetter || prop instanceof AST_Spread); }); }); - def(AST_ObjectIdentity, return_true); def(AST_Sequence, function() { return this.tail_node().safe_to_spread(); }); diff --git a/test/compress/spreads.js b/test/compress/spreads.js index 49ebc2a8..82658dfe 100644 --- a/test/compress/spreads.js +++ b/test/compress/spreads.js @@ -1166,3 +1166,31 @@ issue_5006: { expect_stdout: "PASS" node_version: ">=6" } + +issue_5382: { + options = { + side_effects: true, + } + input: { + ({ + f() { + ({ ...this }); + }, + get p() { + console.log("PASS"); + }, + }).f(); + } + expect: { + ({ + f() { + ({ ...this }); + }, + get p() { + console.log("PASS"); + }, + }).f(); + } + expect_stdout: "PASS" + node_version: ">=8.3.0" +}