JoBoEVD/UglifyJS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix corner cases in ie8 & side_effects (#4731)

Browse Source 
fixes #4729
fixes #4730
This commit is contained in:
Alex Lam S.L
2021-03-03 19:30:07 +00:00
committed by GitHub
parent 2a49760032
commit 20be5209c0
3 changed files with 67 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
lib/compress.js
View File

@@ -7226,30 +7226,36 @@ merge(Compressor.prototype, {
}
var rhs = right.drop_side_effect_free(compressor, first_in_statement);
if (!rhs) return left.drop_side_effect_free(compressor, first_in_statement);
if (lazy_op[op] && !(rhs instanceof AST_Function)) {
if (lazy_op[op] && rhs.has_side_effects(compressor)) {
var node = this;
if (op == "&&"
&& rhs instanceof AST_PropAccess
&& left.equivalent_to(rhs.expression)
&& !left.has_side_effects(compressor)) {
var prop = rhs instanceof AST_Sub && rhs.property.drop_side_effect_free(compressor);
var prop = rhs instanceof AST_Sub
&& rhs.property.drop_side_effect_free(compressor, first_in_statement);
if (!prop) return left.drop_side_effect_free(compressor, first_in_statement);
node = node.clone();
node.right = prop;
} else if (rhs !== right) {
return node.drop_side_effect_free(compressor, first_in_statement);
}
if (rhs !== right) {
node = node.clone();
node.right = rhs.drop_side_effect_free(compressor);
}
if (op == "??") return node;
return (first_in_statement ? best_of_statement : best_of_expression)(node, make_node(AST_Binary, this, {
var negated = make_node(AST_Binary, this, {
operator: op == "&&" ? "||" : "&&",
left: left.negate(compressor, first_in_statement),
right: node.right,
}));
});
return first_in_statement ? best_of_statement(node, negated) : best_of_expression(node, negated);
} else {
var lhs = left.drop_side_effect_free(compressor, first_in_statement);
if (!lhs) return rhs;
return make_sequence(this, [ lhs, rhs.drop_side_effect_free(compressor) ]);
rhs = rhs.drop_side_effect_free(compressor);
if (!rhs) return lhs;
return make_sequence(this, [ lhs, rhs ]);
}
});
def(AST_Call, function(compressor, first_in_statement) {