improve usability (#5758)

This commit is contained in:
Alex Lam S.L
2022-12-04 03:10:32 +02:00
committed by GitHub
parent 0cbd5ea64a
commit 17c3ae6cba
18 changed files with 38 additions and 76 deletions

View File

@@ -1068,7 +1068,7 @@ describe("bin/uglifyjs", function() {
]).join("\n");
exec(uglifyjscmd + " -mc", function(err, stdout) {
if (err) throw err;
assert.strictEqual(stdout, "console.log({p:25}.p+{p:121}.p+{p:1024}.p);\n");
assert.strictEqual(stdout, "console.log(function(){var p={p:25},n={p:121},o={p:1024};return p.p+n.p+o.p}());\n");
assert.strictEqual(run_code(stdout), run_code(code));
done();
}).stdin.end(code);

View File

@@ -117,7 +117,6 @@ describe("comments", function() {
beautify: true,
comments: "all",
},
toplevel: false,
});
if (result.error) throw result.error;
assert.strictEqual(result.code, [
@@ -377,7 +376,6 @@ describe("comments", function() {
var result = UglifyJS.minify(js, {
compress: { collapse_vars: false, reduce_vars: false },
output: { comments: true },
toplevel: false,
});
assert.strictEqual(result.code, 'function f(){/*c1*/var/*c2*/n=/*c3*/!1;return n}');
});
@@ -386,7 +384,6 @@ describe("comments", function() {
var result = UglifyJS.minify(js, {
compress: { collapse_vars: false, reduce_vars: false },
output: { comments: false },
toplevel: false,
});
assert.strictEqual(result.code, 'function f(){var n=!1;return n}');
});
@@ -461,7 +458,6 @@ describe("comments", function() {
it("Should handle shebang and preamble correctly", function() {
var code = UglifyJS.minify("#!/usr/bin/node\nvar x = 10;", {
output: { preamble: "/* Build */" },
toplevel: false,
}).code;
assert.strictEqual(code, "#!/usr/bin/node\n/* Build */\nvar x=10;");
});
@@ -469,7 +465,6 @@ describe("comments", function() {
it("Should handle preamble without shebang correctly", function() {
var code = UglifyJS.minify("var x = 10;", {
output: { preamble: "/* Build */" },
toplevel: false,
}).code;
assert.strictEqual(code, "/* Build */\nvar x=10;");
});
@@ -483,7 +478,6 @@ describe("comments", function() {
js += "x; }";
var result = UglifyJS.minify(js, {
mangle: false,
toplevel: false,
});
assert.strictEqual(result.code, "function lots_of_comments(x){return 7-x}");
});

View File

@@ -8,7 +8,6 @@ describe("Input file as map", function() {
};
var result = UglifyJS.minify(jsMap, {
sourceMap: true,
toplevel: false,
});
if (result.error) throw result.error;
var map = JSON.parse(result.map);
@@ -31,7 +30,6 @@ describe("Input file as map", function() {
];
var result = UglifyJS.minify(jsSeq, {
sourceMap: true,
toplevel: false,
});
if (result.error) throw result.error;
var map = JSON.parse(result.map);
@@ -47,7 +45,6 @@ describe("Input file as map", function() {
sourceMap: {
includeSources: true,
},
toplevel: false,
});
if (result.error) throw result.error;
var map = JSON.parse(result.map);

View File

@@ -11,9 +11,7 @@ function read(path) {
describe("minify", function() {
it("Should test basic sanity of minify with default options", function() {
var js = "function foo(bar) { if (bar) return 3; else return 7; var u = not_called(); }";
var result = UglifyJS.minify(js, {
module: false,
});
var result = UglifyJS.minify(js);
if (result.error) throw result.error;
assert.strictEqual(result.code, "function foo(n){return n?3:7}");
});
@@ -48,9 +46,6 @@ describe("minify", function() {
].forEach(function(file) {
var code = read("test/input/issue-1242/" + file);
var result = UglifyJS.minify(code, {
compress: {
toplevel: false,
},
mangle: {
cache: cache,
toplevel: true,
@@ -83,9 +78,6 @@ describe("minify", function() {
].forEach(function(file) {
var code = read("test/input/issue-1242/" + file);
var result = UglifyJS.minify(code, {
compress: {
toplevel: false,
},
mangle: {
toplevel: true,
},
@@ -172,7 +164,6 @@ describe("minify", function() {
output: {
keep_quoted_props: true,
},
toplevel: false,
});
assert.strictEqual(result.code, 'var foo={"x":1,y:2,"z":3};');
});
@@ -183,7 +174,6 @@ describe("minify", function() {
keep_quoted_props: true,
quote_style: 3,
},
toplevel: false,
});
assert.strictEqual(result.code, 'var foo={"x":1,y:2,\'z\':3};');
});
@@ -194,7 +184,6 @@ describe("minify", function() {
keep_quoted_props: false,
quote_style: 3,
},
toplevel: false,
});
assert.strictEqual(result.code, 'var foo={x:1,y:2,z:3};');
});
@@ -248,7 +237,6 @@ describe("minify", function() {
comments: "all",
beautify: false,
},
toplevel: false,
});
var code = result.code;
assert.strictEqual(code, "var a=function(){foo()}();");
@@ -328,7 +316,6 @@ describe("minify", function() {
UglifyJS.minify(ast, {
compress: {
sequences: false,
toplevel: false,
},
mangle: false,
});

View File

@@ -333,6 +333,7 @@ describe("test/reduce.js", function() {
unsafe_math: true,
},
mangle: false,
module: false,
});
if (result.error) throw result.error;
assert.strictEqual(result.code, [
@@ -346,7 +347,8 @@ describe("test/reduce.js", function() {
'// "compress": {',
'// "unsafe_math": true',
'// },',
'// "mangle": false',
'// "mangle": false,',
'// "module": false',
"// }",
].join("\n"));
});

View File

@@ -109,7 +109,6 @@ describe("sourcemaps", function() {
"}",
].join("\n"), {
sourceMap: true,
toplevel: false,
});
if (result.error) throw result.error;
assert.strictEqual(result.code, "class A{static P=42;set#q(s){}}");
@@ -188,7 +187,6 @@ describe("sourcemaps", function() {
sourceMap: {
content: "inline",
},
toplevel: false,
warnings: true,
});
assert.strictEqual(result.code, "var bar=function(bar){return bar};");
@@ -203,7 +201,6 @@ describe("sourcemaps", function() {
content: "inline",
url: "inline",
},
toplevel: false,
warnings: true,
});
if (result.error) throw result.error;
@@ -301,7 +298,6 @@ describe("sourcemaps", function() {
sourceMap: {
url: "inline",
},
toplevel: false,
});
if (result.error) throw result.error;
var code = result.code;
@@ -309,9 +305,7 @@ describe("sourcemaps", function() {
"//# sourceMappingURL=data:application/json;charset=utf-8;base64,eyJ2ZXJzaW9uIjozLCJzb3VyY2VzIjpbIjAiXSwibmFtZXMiOlsiYSIsImZvbyJdLCJtYXBwaW5ncyI6IkFBQUEsSUFBSUEsRUFBSSxTQUFTQyxHQUFPLE9BQU9BLENBQUsifQ==");
});
it("Should not append source map to output js when sourceMapInline is not enabled", function() {
var result = UglifyJS.minify("var a = function(foo) { return foo; };", {
module: false,
});
var result = UglifyJS.minify("var a = function(foo) { return foo; };");
if (result.error) throw result.error;
var code = result.code;
assert.strictEqual(code, "var a=function(n){return n};");
@@ -327,7 +321,6 @@ describe("sourcemaps", function() {
sourceMap: {
url: "inline",
},
toplevel: false,
});
if (result.error) throw result.error;
assert.strictEqual(result.code, read("test/input/issue-505/output.js"));
@@ -342,7 +335,6 @@ describe("sourcemaps", function() {
includeSources: true,
url: "inline",
},
toplevel: false,
});
if (result.error) throw result.error;
var map = JSON.parse(result.map);
@@ -357,7 +349,6 @@ describe("sourcemaps", function() {
content: "inline",
includeSources: true,
},
toplevel: false,
});
if (result.error) throw result.error;
map = JSON.parse(result.map);