JoBoEVD/UglifyJS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix corner case with arguments (#4486)

Browse Source 
fixes #4485
This commit is contained in:
Alex Lam S.L
2020-12-31 06:55:05 +00:00
committed by GitHub
parent 8b954b022b
commit 0b7d65d331
3 changed files with 176 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/compress.js
View File

@@ -3344,7 +3344,9 @@ merge(Compressor.prototype, {
if (is_undeclared_ref(this) && this.is_declared(compressor)) return false; if (is_undeclared_ref(this) && this.is_declared(compressor)) return false;
if (this.is_immutable()) return false; if (this.is_immutable()) return false;
var def = this.definition(); var def = this.definition();
if (is_arguments(def)) return def.scope.uses_arguments > 2; if (is_arguments(def) && all(def.scope.argnames, function(argname) {
return argname instanceof AST_SymbolFunarg;
})) return def.scope.uses_arguments > 2;
var fixed = this.fixed_value(); var fixed = this.fixed_value();
if (!fixed) return true; if (!fixed) return true;
this._dot_throw = return_true; this._dot_throw = return_true;

86
test/compress/default-values.js
View File

@@ -1227,3 +1227,89 @@ issue_4483: {
expect_stdout: "PASS" expect_stdout: "PASS"
node_version: ">=6" node_version: ">=6"
} }
issue_4485_1: {
options = {
pure_getters: "strict",
side_effects: true,
}
input: {
(function(a = null) {
var arguments;
try {
arguments.length;
} catch (e) {
console.log("PASS");
}
})();
}
expect: {
(function(a = null) {
var arguments;
try {
arguments.length;
} catch (e) {
console.log("PASS");
}
})();
}
expect_stdout: true
node_version: ">=6"
}
issue_4485_2: {
options = {
pure_getters: "strict",
side_effects: true,
}
input: {
(function(a = null) {
var arguments = null;
try {
arguments.length;
} catch (e) {
console.log("PASS");
}
})();
}
expect: {
(function(a = null) {
var arguments = null;
try {
arguments.length;
} catch (e) {
console.log("PASS");
}
})();
}
expect_stdout: "PASS"
node_version: ">=6"
}
issue_4485_3: {
options = {
unused: true,
}
input: {
(function(a = null) {
var arguments;
try {
arguments.length;
} catch (e) {
console.log("PASS");
}
})();
}
expect: {
(function(a = null) {
var arguments;
try {
arguments.length;
} catch (e) {
console.log("PASS");
}
})();
}
expect_stdout: true
node_version: ">=6"
}

87
test/compress/destructured.js
View File

@@ -2215,3 +2215,90 @@ issue_4456: {
expect_stdout: "PASS" expect_stdout: "PASS"
node_version: ">=6" node_version: ">=6"
} }
issue_4485_1: {
options = {
pure_getters: "strict",
side_effects: true,
}
input: {
(function([]) {
var arguments;
try {
arguments.length;
} catch (e) {
console.log("PASS");
}
})([]);
}
expect: {
(function([]) {
var arguments;
try {
arguments.length;
} catch (e) {
console.log("PASS");
}
})([]);
}
expect_stdout: true
node_version: ">=6"
}
issue_4485_2: {
options = {
pure_getters: "strict",
side_effects: true,
}
input: {
(function([]) {
var arguments = null;
try {
arguments.length;
} catch (e) {
console.log("PASS");
}
})([]);
}
expect: {
(function([]) {
var arguments = null;
try {
arguments.length;
} catch (e) {
console.log("PASS");
}
})([]);
}
expect_stdout: "PASS"
node_version: ">=6"
}
issue_4485_3: {
options = {
keep_fargs: false,
unused: true,
}
input: {
(function([]) {
var arguments;
try {
arguments.length;
} catch (e) {
console.log("PASS");
}
})([]);
}
expect: {
(function([]) {
var arguments;
try {
arguments.length;
} catch (e) {
console.log("PASS");
}
})([]);
}
expect_stdout: true
node_version: ">=6"
}