fix corner case in evaluate & ie8 (#3751)

fixes #3750
This commit is contained in:
Alex Lam S.L
2020-03-21 00:55:24 +08:00
committed by GitHub
parent 03e968be62
commit 0a1c9b34ce
4 changed files with 35 additions and 5 deletions

View File

@@ -3373,15 +3373,18 @@ merge(Compressor.prototype, {
var args = eval_args(this.args); var args = eval_args(this.args);
if (!args) return this; if (!args) return this;
if (!stat.value) return undefined; if (!stat.value) return undefined;
fn.argnames.forEach(function(sym, i) { if (!all(fn.argnames, function(sym, i) {
var value = args[i]; var value = args[i];
sym.definition().references.forEach(function(node) { var def = sym.definition();
if (def.orig[def.orig.length - 1] !== sym) return false;
def.references.forEach(function(node) {
node._eval = function() { node._eval = function() {
return value; return value;
}; };
cached.push(node); cached.push(node);
}); });
}); return true;
})) return this;
fn.evaluating = true; fn.evaluating = true;
var val = stat.value._eval(compressor, ignore_side_effects, cached, depth); var val = stat.value._eval(compressor, ignore_side_effects, cached, depth);
delete fn.evaluating; delete fn.evaluating;

View File

@@ -219,7 +219,12 @@ AST_Toplevel.DEFMETHOD("figure_out_scope", function(options) {
var redef; var redef;
while (redef = new_def.redefined()) new_def = redef; while (redef = new_def.redefined()) new_def = redef;
} else { } else {
new_def = self.globals.get(name) || scope.def_variable(node); new_def = self.globals.get(name);
}
if (new_def) {
new_def.orig.push(node);
} else {
new_def = scope.def_variable(node);
} }
old_def.orig.concat(old_def.references).forEach(function(node) { old_def.orig.concat(old_def.references).forEach(function(node) {
node.thedef = new_def; node.thedef = new_def;

View File

@@ -185,7 +185,7 @@ function makePredicate(words) {
function all(array, predicate) { function all(array, predicate) {
for (var i = array.length; --i >= 0;) for (var i = array.length; --i >= 0;)
if (!predicate(array[i])) if (!predicate(array[i], i))
return false; return false;
return true; return true;
} }

View File

@@ -2398,3 +2398,25 @@ issue_3703: {
} }
expect_stdout: "PASS" expect_stdout: "PASS"
} }
issue_3750: {
options = {
evaluate: true,
ie8: true,
}
input: {
(function(a) {
return function a() {
return a && console.log("PASS");
}();
})();
}
expect: {
(function(a) {
return function a() {
return a && console.log("PASS");
}();
})();
}
expect_stdout: "PASS"
}