JoBoEVD/UglifyJS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

avoid v8 quirks in ufuzz (#5458)

Browse Source
This commit is contained in:
Alex Lam S.L
2022-05-19 17:00:24 +01:00
committed by GitHub
parent 27aa85f84b
commit 01f1e3fef8
2 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@@ -1331,11 +1331,9 @@ To allow for better optimizations, the compiler makes various assumptions:
- Later versions of JavaScript will throw `SyntaxError` with the following: - Later versions of JavaScript will throw `SyntaxError` with the following:
```javascript ```javascript
var await; var await;
async function f() {
class A { class A {
static p = await; static p = await;
} }
}
// SyntaxError: Unexpected reserved word // SyntaxError: Unexpected reserved word
``` ```
UglifyJS may modify the input which in turn may suppress those errors. UglifyJS may modify the input which in turn may suppress those errors.

10
test/ufuzz/index.js
View File

@@ -1826,13 +1826,13 @@ function createClassLiteral(recurmax, stmtDepth, canThrow, name) {
if (SUPPORT.class_field && rng(2)) { if (SUPPORT.class_field && rng(2)) {
if (internal) { if (internal) {
s += internal; s += internal;
} else if (fixed && bug_static_class_field) { } else if (fixed && bug_class_static_nontrivial) {
s += getDotKey(); s += getDotKey();
} else { } else {
s += createObjectKey(recurmax, stmtDepth, canThrow); s += createObjectKey(recurmax, stmtDepth, canThrow);
} }
if (rng(5)) { if (rng(5)) {
async = bug_async_class_await && fixed && 0; async = false;
generator = false; generator = false;
s += " = " + createExpression(recurmax, NO_COMMA, stmtDepth, fixed ? canThrow : CANNOT_THROW); s += " = " + createExpression(recurmax, NO_COMMA, stmtDepth, fixed ? canThrow : CANNOT_THROW);
generator = save_generator; generator = save_generator;
@@ -2037,7 +2037,7 @@ function isBannedKeyword(name) {
case "let": case "let":
return in_class; return in_class;
case "await": case "await":
return async !== false; return async || in_class && bug_class_static_await;
case "yield": case "yield":
return generator || in_class; return generator || in_class;
} }
@@ -2444,10 +2444,10 @@ if (SUPPORT.arrow && SUPPORT.async && SUPPORT.rest && sandbox.is_error(sandbox.r
return ex.name == "SyntaxError" && ex.message == "Rest parameter must be last formal parameter"; return ex.name == "SyntaxError" && ex.message == "Rest parameter must be last formal parameter";
}; };
} }
var bug_async_class_await = SUPPORT.async && SUPPORT.class_field && sandbox.is_error(sandbox.run_code("var await; async function f() { class A { static p = await; } }")); var bug_class_static_await = SUPPORT.async && SUPPORT.class_field && sandbox.is_error(sandbox.run_code("var await; class A { static p = await; }"));
var bug_class_static_nontrivial = SUPPORT.class_field && sandbox.is_error(sandbox.run_code("class A { static 42; static get 42() {} }"));
var bug_for_of_async = SUPPORT.for_await_of && sandbox.is_error(sandbox.run_code("var async; for (async of []);")); var bug_for_of_async = SUPPORT.for_await_of && sandbox.is_error(sandbox.run_code("var async; for (async of []);"));
var bug_for_of_var = SUPPORT.for_of && SUPPORT.let && sandbox.is_error(sandbox.run_code("try {} catch (e) { for (var e of []); }")); var bug_for_of_var = SUPPORT.for_of && SUPPORT.let && sandbox.is_error(sandbox.run_code("try {} catch (e) { for (var e of []); }"));
var bug_static_class_field = SUPPORT.class_field && sandbox.is_error(sandbox.run_code("class A { static 42; static get 42() {} }"));
if (SUPPORT.destructuring && sandbox.is_error(sandbox.run_code("console.log([ 1 ], {} = 2);"))) { if (SUPPORT.destructuring && sandbox.is_error(sandbox.run_code("console.log([ 1 ], {} = 2);"))) {
beautify_options.output.v8 = true; beautify_options.output.v8 = true;
minify_options.forEach(function(o) { minify_options.forEach(function(o) {